JDK 10 RFR of JDK-8181396: Refactor shell test java/nio/file/Files/delete_on_close.sh to java

2017-06-04 Thread Amy Lu
java/nio/file/Files/delete_on_close.sh Please review this patch to refactor the shell test to java. bug: https://bugs.openjdk.java.net/browse/JDK-8181396 webrev: http://cr.openjdk.java.net/~amlu/8181396/webrev.00/ Thanks, Amy

Re: JDK 10 RFR of JDK-8181394: Refactor shell test java/nio/file/Files/walkFileTree/find.sh to java

2017-06-04 Thread Amy Lu
Please review the updated webrev: http://cr.openjdk.java.net/~amlu/8181394/webrev.01 CreateFileTree is also used by other tests, no change. Thanks, Amy On 6/1/17 6:51 PM, Alan Bateman wrote: webrev: http://cr.openjdk.java.net/~amlu/8181394/webrev.00/ I think it would be cleaner if you merged F

Re: JDK 10 RFR of JDK-8181393: Refactor shell test Selector/lots_of_updates.sh and SocketChannel/Open.sh to java

2017-06-04 Thread Amy Lu
On 6/3/17 4:21 AM, Paul Sandoz wrote: webrev: http://cr.openjdk.java.net/~amlu/8181393/webrev.00/ +1 Out of curiosity is jtreg compilation of a test smart enough to know of at least some of its dependencies. 24 /* 25 * @test

Re: RFR 8181414/10, Refactor misc test/sun/net/www/protocol/jar shell tests to plain java tests

2017-06-04 Thread Felix Yang
Igor and Paul, thanks for the review. Pushed with typo fixed. -Felix On 2017/6/3 6:04, Igor Ignatyev wrote: http://cr.openjdk.java.net/~xiaofeya/8181414/webrev.00/test/sun/net/www/protocol/jar/B5105410.java.udiff.html

Re: RFR 8181413/10, Refactor test/sun/net/www/protocol/jar/jarbug/run.sh to plain java tests

2017-06-04 Thread Felix Yang
Hi Paul, this is from original test logic. According with the bug history, it is added by https://bugs.openjdk.java.net/browse/JDK-7152892 to avoid intermittent test failures. Thanks, Felix On 2017/6/3 5:08, Paul Sandoz wrote: It looks ok, but i wonder why need to chmod? Paul. On 1 J

Re: (10) RFR of JDK-8180927: refactor ./java/io/Serializable/class/run.sh to java test

2017-06-04 Thread Hamlin Li
Ping. Thank you -Hamlin On 2017/6/1 16:22, Hamlin Li wrote: Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8180927 webrev: http://cr.openjdk.java.net/~mli/8180927/webrev.00/ Thank you -Hamlin