Hi Peter,
Thanks for your feedback!
> Method.getName() returns an interned String and String literals are interned
> strings. Reference comparison is therefore possible
Good point.
> The pair (declaringClass, methodName) uniquely identifies the method for a
> bunch of interesting methods when
Hi Claes,
> Let's file a separate RFE and push this. I assume you need a sponsor to do
> both?
>
> Thanks!
>
> /Claes
Indeed, I would need a sponsor. Thank you!
Cheers,
Christoph
non-test be run as a test, the result may lead to confusion.
For example, if look at MockSimplePeriod.java test result, it shows:
===
java/time/test/java/time/MockSimplePeriod.java
Total tests run: 0, Failures: 0, Skips: 0
==
On Thu, Oct 12, 2017 at 5:32 PM, Paul Sandoz wrote:
>
> SplittableRandomTest.java
> —
>
> 592 int n = sr.nextInt(20);
>
> nextInt(1, 20) ? so you get a byte array of 1 or more in length.
>
Yes, I see now there is no testing at all when n == 0. Empty array and
null array are both worth
Looks good, one minor comment below.
> On 11 Oct 2017, at 14:42, Martin Buchholz wrote:
>
> This wave introduces a more clickable overview Home Page:
>
> http://cr.openjdk.java.net/~martin/webrevs/openjdk10/jsr166-integration/overview.html
>
> 8188900: ConcurrentLinkedDeque linearizability
> 8
That is interesting, thanks. I'll add the info to the bug report.
I can reproduce the crash on 10.9 when setting a non-default calendar
instead of a currency. But I still cannot reproduce it on 10.12.
-Brent
On 10/12/17 2:28 PM, Xueming Shen wrote:
Brent,
My mac build fails / crashes for
Brent,
My mac build fails / crashes for a while at exactly the same location.
The fix seems
have solved the problem. However my osx is 10.11.5/OSX El Capitan, and
in my case
the locale variable looks like "en-US@calendar=iso8601". It's not the
currency, but
the calendar is attached after "@"
Hi Phillip,
All of these bugs are in the core-libs area, so I am copying the
core-libs-dev list since that is where they should be discussed and
reviewed. I have -bcc-ed security-dev (where this was originally posted).
--Sean
On 10/2/17 1:24 PM, Philipp Kunz wrote:
Hi,
While fixing JDK-669
Looks fine, Brent.
Naoto
On 10/12/17 11:52 AM, Brent Christian wrote:
Hi,
Please review my change to prevent a startup crash on earlier versions
of MacOS.
Bug: https://bugs.openjdk.java.net/browse/JDK-8187772
Webrev: http://cr.openjdk.java.net/~bchristi/8187772/webrev.00/
When a non-de
Hi Mandy,
True in advertising, the FileDescriptor.close() method should be
declared to throw IOException.
Cleanup via the Cleaner.clean() method can't throw a checked exception
but the IOException can be
wrapped with UncheckedIOException that can be caught by Cleaner.clean()
callers.
They c
Hi,
Please review my change to prevent a startup crash on earlier versions
of MacOS.
Bug: https://bugs.openjdk.java.net/browse/JDK-8187772
Webrev: http://cr.openjdk.java.net/~bchristi/8187772/webrev.00/
When a non-default currency is set in the Language & Region control
panel, it's reflec
On 12.10.2017 16:23, Kirk Pepperdine wrote:
Hi,
On Oct 12, 2017, at 2:54 PM, Mario Torre wrote:
2017-10-12 11:58 GMT+02:00 Cédric Champeau :
1. an API in 18.3 which would let us refresh the environment variables,
even if inherently unsafe (we can take the risk, if the Javadocs explains
th
Hi,
Please review a cleanup of rawtypes and unchecked warnings from JAXP
sources.
The patch involved a good number of classes (278). However, the majority
of the changes are straight-forward replacement, e.g.
s/Vector/List[ArrayList] and their relevant methods e.g. s/elementAt/get
and etc.
On 10/4/17 7:35 AM, Roger Riggs wrote:
Updated the webrev in place:
http://cr.openjdk.java.net/~rriggs/webrev-fis-cleanup-8080225/
Looks good. One minor comment:
251 private static native void cleanupClose0(int fd);
75 Java_java_io_FileDescriptor_cleanupClose0(JNIEnv *env, jclass
fdClass,
Hi Amy,
I'm not convinced this is the right move. Moving parts of tests further
from the test
is not helpful from a maintenance point of view.
I'm not concerned about compilation time. Its not significant.
For example, AbstractDateTimeTest has @Test directives and is not just
library code.
Hi Alan,
On 10/12/2017 8:35 AM, Alan Bateman wrote:
On 04/10/2017 15:35, Roger Riggs wrote:
Hi Mandy,
Updated the webrev in place:
http://cr.openjdk.java.net/~rriggs/webrev-fis-cleanup-8080225/
I skimmed the latest webrev.
The @apiNote in FIS is copied from FOS so it needs
s/FileOutputStrea
Yes that's one option. Note that declaring environment variables is not a
small change. It has consequences on the project layout. Typically, if they
need to be in the settings.gradle file, then now the client would have to
compile, parse and potentially partially execute code. Similarly if it's in
Hi Cedric,
I think you should play like the JDK 9 i.e. help users to transition from th
old world to the new world where env variables need to be declared explicitly.
So warn user that the env variables should now be declared explicitly, use an
agent to simulate the old getenv+grapefruit, create
Hi Sherman,
On 10/11/2017 12:22 AM, Xueming Shen wrote:
Peter,
Webrev has been updated accordingly to remove the "inflater" from the
"streams" as the "value" of the map. As suggested, the "streams" now
itself is a "set".
And, a package private "Infater()" has been added to avoid registering t
Hi,
> On Oct 12, 2017, at 2:54 PM, Mario Torre
> wrote:
>
> 2017-10-12 11:58 GMT+02:00 Cédric Champeau :
>
>> 1. an API in 18.3 which would let us refresh the environment variables,
>> even if inherently unsafe (we can take the risk, if the Javadocs explains
>> that if you're really unlucky ca
> Hi,
>
> please review this bug fix to ensure we don't reject jar
> and zip files due to entries having malformed timestamps.
>
> Webrev: http://cr.openjdk.java.net/~redestad/8188869/jdk.00/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8188869
>
> I opted to only fall back to the mor
Sherman, Alan,
thanks for reviewing!
On 2017-10-12 15:48, Alan Bateman wrote:
I think this looks okay. Minor typo s/date/Date in "Use of date
constructor".
Will fix before push, thanks!
/Claes
On 11/10/2017 17:15, Claes Redestad wrote:
Hi,
please review this bug fix to ensure we don't reject jar
and zip files due to entries having malformed timestamps.
Webrev: http://cr.openjdk.java.net/~redestad/8188869/jdk.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8188869
I opted to only
On 12/10/2017 07:07, Kazunori Ogata wrote:
Hi Alan,
Thank you for your comment. I was not fully aware of the possibility of
attacking...
I updated the patch to check if the current thread is the same as the
thread cached the loader.
Updated webreb: http://cr.openjdk.java.net/~horii/8188858/we
2017-10-12 11:58 GMT+02:00 Cédric Champeau :
> 1. an API in 18.3 which would let us refresh the environment variables,
> even if inherently unsafe (we can take the risk, if the Javadocs explains
> that if you're really unlucky calling such a method could kill your VM).
Being a public API we would
On 04/10/2017 15:35, Roger Riggs wrote:
Hi Mandy,
Updated the webrev in place:
http://cr.openjdk.java.net/~rriggs/webrev-fis-cleanup-8080225/
I skimmed the latest webrev.
The @apiNote in FIS is copied from FOS so it needs
s/FileOutputStream/FileInputStream/.
I assume in FIS that we shoul
Hi folks,
Let me resurrect this thread now that Java 9 is out (congrats to the
team!). We still have the problem, and actually some users complained about
the poor performance of Gradle under JDK 9, and it turned out to be exactly
the problem I mentioned in this thread. Now with JDK 9, everytime a
Hi Roger,
Thanks for the review, i incorporated all review comments from you
except("you can use ExtendedSocketOptions.TCP_QUICKACK to check for the
option to omit without
embedding the name."). ExtendedSocketOptions.java is part of
"jdk.net" so we can not directly use it in java.base, hence
28 matches
Mail list logo
