Re: RFR 8196298 Add null Reader and Writer

On 2/1/18 10:35 AM, Patrick Reinhart wrote: Here is my first shot of the actual implementation and tests: http://cr.openjdk.java.net/~reinhapa/reviews/8196298/webrev.00 I looked at the specification of ready() vs the implementation. The spec says that ready(), among other methods, behaves a

Re: Collections.addAll: remove outdated performance advice and add a note about atomicity

Links to existing material in OpenJDK: http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-December/050326.html https://bugs.openjdk.java.net/browse/JDK-8193031 I agree with the removal of the performance advice. We should also remove "identical"; my suggested replacement was "a

Re: [PATCH] Reduce Chance Of Mistakenly Early Backing Memory Cleanup

> On Feb 1, 2018, at 4:03 PM, Hans Boehm wrote: > > > On Thu, Feb 1, 2018 at 2:50 PM, Paul Sandoz > wrote: > > > > Hi Ben, > > > > I don’t think you require the fence in all the cases you have currently > > placed it e.g. here for example > > > > $memty

Re: RFR 8196298 Add null Reader and Writer

On Feb 1, 2018, at 12:01 PM, Patrick Reinhart wrote: >> I believe read(CharBuffer), like read(char[], int, int), should test if >> there are remaining chars in the buffer. > > Does it make sense to check for remaining chars in the buffer, wen the source > is basically at the end of it’s data?

Re: JDK-8196298: Add null Reader and Writer

On Feb 1, 2018, at 2:49 PM, Patrick Reinhart wrote: >> Am 01.02.2018 um 22:26 schrieb Brian Burkhalter >> : >>> […] >> >> Yes: there is no such lock instance variable for those classes. Probably it >> would not hurt to add a one liner to each method’s doc as Alan suggested. >> > > As my eng

Re: [PATCH] Reduce Chance Of Mistakenly Early Backing Memory Cleanup

Hi Ben, I don’t think you require the fence in all the cases you have currently placed it e.g. here for example $memtype$ y = $toBits$(x); UNSAFE.put$Memtype$Unaligned(null, a, y, bigEndian); +Reference.reachabilityFence(this); return this; since “this” is being

Re: JDK-8196298: Add null Reader and Writer

> Am 01.02.2018 um 22:26 schrieb Brian Burkhalter : > > > On Jan 30, 2018, at 8:52 AM, Patrick Reinhart > wrote: > >>> Am 30.01.2018 um 16:02 schrieb Alan Bateman >> >: >>> >>> […] >>> >>> One other micro detail is that Reader/Writer

Re: Clarification for adding classes shipped with JDK to sun.rmi.registry.registryFilter property in java.security file

Hi Nasser, There is a tradeoff between convenience and security. The risk can be reduced, in part, by keeping the set of trusted classes as small as possible. White-lists should be application specific, with the selected classes carefully reviewed and only include what is needed. Regards, Ro

Re: RFR 8195059: Update java.net Socket and DatagramSocket implementations to use Cleaner

Hi Chris, Thanks for the review and suggestion. Webrev updated:    http://cr.openjdk.java.net/~rriggs/webrev-net-cleanup-8195059/ * Refactored SocketCleanup into a java.net package private SocketCleanable * Moved register and unregister into static methods in SocketCleanable * Simplified the

Re: JDK-8196298: Add null Reader and Writer

On Jan 30, 2018, at 8:52 AM, Patrick Reinhart wrote: >> Am 30.01.2018 um 16:02 schrieb Alan Bateman : >> >> […] >> >> One other micro detail is that Reader/Writer support implementations >> specifying the object to use for synchronization. This isn't interesting for >> the Reader/Writer obje

Re: java.time.Instant.getEpochSeconds() javadocs still has a typo

Hi, Filed: 8196609 Improve javadoc for java.time.Instant.getEpochSecond Thanks, Roger On 2/1/2018 3:46 PM, Kurt Alfred Kluever wrote: Hey folks, I had a quick question about the javadocs of this method. It looks like the `getNanosOfSecond`

Re: RFR (JDK11/JAXP) 8193830: Xalan Update: Xalan Java 2.7.2

Thanks Lance! The russian and polish files were the original ones submitted by the bug reporter. I double-checked with this https://en.wikipedia.org/wiki/Russian_alphabet :-) -Joe On 2/1/2018 12:06 PM, Lance Andersen wrote: Hi Joe, Changes look fine.  I assume the russian and polish is cor

Re: RFR (JDK11/JAXP) 8193830: Xalan Update: Xalan Java 2.7.2

Hi Joe, Changes look fine. I assume the russian and polish is correct :-) Best Lance > On Feb 1, 2018, at 1:07 PM, Joe Wang wrote: > > Hi, > > Please review an update to Xalan 2.7.2 release. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8193830 > webrev: http://cr.openjdk.java.net/~joehw

Re: RFR 8196298 Add null Reader and Writer

Hi Rémi, I also found, that I missed the throw an ReadOnlyBufferException on a passed in read only CharBuffer. > Am 01.02.2018 um 19:49 schrieb Remi Forax : > > Hi Patrick, > I believe read(CharBuffer), like read(char[], int, int), should test if there > are remaining chars in the buffer. Doe

Re: [11] 8196583 Update jib and test jtreg version to 4.2 b12

Looks good. Lois On 2/1/2018 1:44 PM, Paul Sandoz wrote: Hi, The constant dynamic test i recently updated and pushed to hs [*] requires a later version of jtreg to execute correctly (it requires an updated version of asmtools bundled with jtreg). Here are the changes: diff -r 11920d5d14a8 m

Re: RFR 8196298 Add null Reader and Writer

Hi Patrick, I believe read(CharBuffer), like read(char[], int, int), should test if there are remaining chars in the buffer. cheers, Rémi - Mail original - > De: "Patrick Reinhart" > À: "core-libs-dev" > Envoyé: Jeudi 1 Février 2018 19:35:11 > Objet: RFR 8196298 Add null Reader and Wri

Re: [11] 8196583 Update jib and test jtreg version to 4.2 b12

+1 Mandy On 2/1/18 10:44 AM, Paul Sandoz wrote: Hi, The constant dynamic test i recently updated and pushed to hs [*] requires a later version of jtreg to execute correctly (it requires an updated version of asmtools bundled with jtreg). Here are the changes: diff -r 11920d5d14a8 make/conf

[11] 8196583 Update jib and test jtreg version to 4.2 b12

Hi, The constant dynamic test i recently updated and pushed to hs [*] requires a later version of jtreg to execute correctly (it requires an updated version of asmtools bundled with jtreg). Here are the changes: diff -r 11920d5d14a8 make/conf/jib-profiles.js --- a/make/conf/jib-profiles.js Wed

RFR 8196298 Add null Reader and Writer

Hi, Here is my first shot of the actual implementation and tests: http://cr.openjdk.java.net/~reinhapa/reviews/8196298/webrev.00 Thanks for feedback -Patrick

RFR (JDK11/JAXP) 8193830: Xalan Update: Xalan Java 2.7.2

Hi, Please review an update to Xalan 2.7.2 release. JBS: https://bugs.openjdk.java.net/browse/JDK-8193830 webrev: http://cr.openjdk.java.net/~joehw/jdk11/8193830/webrev/index.html Thanks, Joe

Re: RFR 8195059: Update java.net Socket and DatagramSocket implementations to use Cleaner

Hi Roger, > On 31 Jan 2018, at 15:52, Roger Riggs wrote: > > Adding net-...@openjdk.java.net > > On 1/30/2018 5:08 PM, Roger Riggs wrote: >> Please review changes to replace finalizers in socket, datagram, and >> multicast networking >> with Cleaner based release of the raw file descriptors.

[PATCH] Reduce Chance Of Mistakenly Early Backing Memory Cleanup

This contribution forms a partial solution to the problem detailed here - http://thevirtualmachinist.blogspot.ca/2011/07/subtle-issue-of-reachability.html . In this context, this contribution provides "markers" such that a suitably "aware" compiler can reduce the chances of such a problem occurr

Re: [11] RFR 8195694: ConstantBootstraps.invoke does not preserve variable arity

On Feb 1, 2018, at 12:45 AM, Paul Sandoz wrote: > > > >> On Jan 31, 2018, at 3:49 PM, John Rose wrote: >> >> On second thought, you should also use invokeWithArguments to support jumbo >> arities. >> > > It does, but non-selectively based on the arity: > > 245 return handle.invok