Re: Collections.addAll: remove outdated performance advice and add a note about atomicity

Hello! Thank you for pointers to the previous discussions. Yes, I would suggest to consider a spec cleanup separately, because adding new Collection default method would certainly take much longer time to discuss. I agree that we can exclude the statement about atomicity if it causes doubts.

Re: RFR [11] (JAXP): 6857903: SAXException.initCause() does not correctly set Exception

Thank you for your comments, Jason! New webrev can be found at this location: http://cr.openjdk.java.net/~aefimov/6857903/dev/02/ The list of changes: - this.initCause() -> super.initCause() - 'readObject' has been modified to convert IllegalStateException to InvalidClassException. The test

RFR JDK-8164278: java.util.Base64.EncOutputStream/DecInputStream is slower than corresponding version in javax.mail package

Hi, Please help review the change for JDK-8164278. issue: https://bugs.openjdk.java.net/browse/JDK-8164278 webrev: http://cr.openjdk.java.net/~sherman/8164278/webrev jmh.src: http://cr.openjdk.java.net/~sherman/8164278/Base64BM.java jmh.result:

Re: Cannot add attribute into main attributes of a jar if there is no version

On 2/4/18 1:38 PM, Philipp Kunz wrote: duplicate of https://bugs.openjdk.java.net/browse/JDK-6910466? Yes it is.  I closed JDK-8196371 as a dup. thanks Mandy

Re: [PATCH] Reduce Chance Of Mistakenly Early Backing Memory Cleanup

Hi Ben, Thanks for looking into this. > On Feb 5, 2018, at 8:52 AM, Ben Walsh wrote: > > Running with the following test under the JMH benchmark framework (never > used this before, so please do point out any issues with the test) … > Your benchmark looks good, i

Re: RFR 8195059: Update java.net Socket and DatagramSocket implementations to use Cleaner

Hi Florian, Thanks for the reminder, I'll add it to 8196716 Refactor FileDescriptor FDCleanup Thanks, Roger On 2/4/2018 4:17 PM, Florian Weimer wrote: * Roger Riggs: Updated in place.  

Re: RFR [11] (JAXP): 6857903: SAXException.initCause() does not correctly set Exception

Aleksei, Looks good. We should avoid this.initCause in readObject and prefer super.initCause so subclasses can't alter the deserialization behavior. While I can't think of a case off the top of my head, I would prefer that we trap and convert IllegalStateException into a InvalidClassException

Re: RFR [11] (JAXP): 6857903: SAXException.initCause() does not correctly set Exception

Hi Roger, Jason, I've tried to avoid doing the same stuff as I did for XPathException to minimize the changes to the SAXException class. But I was naive to think so: Tried to keep the exception field in place to avoid modifications required to keep serial form intact (similar as it was done in

Re: [PATCH] Reduce Chance Of Mistakenly Early Backing Memory Cleanup

Running with the following test under the JMH benchmark framework (never used this before, so please do point out any issues with the test) ... --- package org.sample; import

RFR: 8194493 test for release file checking needs to be tier1

I need to add the negative test created for JDK-8192837 to the TEST.groups file. The related bug is https://bugs.openjdk.java.net/browse/JDK-8194493 The diff is very short and included below. Any comments/suggestions are welcome, also I will need a sponsor for it at the end… Randy

RFR: 8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java

Please review the added JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java, thanks It’s to verify capability to add a new entry to the directory using the ADD operation. This test will use LDAPServer to playback dump ldap message to simulate test environment. bug: