[JDK 11] RFR 8196759: Move two java/text/Normalizer tests into OpenJDK

Please review the changes to move two java/text/Normalizer tests to OpenJDK jdk_text group, thanks bug: https://bugs.openjdk.java.net/browse/JDK-8196759 webrev: http://cr.openjdk.java.net/~xiaofeya/8196759/webrev.00/

Re: RFR(XXS) : 8190679 : java/util/Arrays/TimSortStackSize2.java fails with "Initial heap size set to a larger value than the maximum heap size"

Hi Igor, On 27/02/2018 11:25 AM, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8190679/webrev.00/index.html 9 lines changed: 2 ins; 0 del; 7 mod; Hi all, could you please review the patch for TimSortStackSize2 test? the test failed when externally passed (via -javaoption or -v

Re: [PATCH] Reduce Chance Of Mistakenly Early Backing Memory Cleanup

Hi Ben, Here is the webrev online: http://cr.openjdk.java.net/~psandoz/jdk/buffer-reachability-fence/webrev/index.html (I don’t know if you have any colleagues with author or above roles in OpenJDK to upload for you, it might be faster.) Reference.java — 423 @ForceInline 424 publ

RFR(XXS) : 8190679 : java/util/Arrays/TimSortStackSize2.java fails with "Initial heap size set to a larger value than the maximum heap size"

http://cr.openjdk.java.net/~iignatyev//8190679/webrev.00/index.html > 9 lines changed: 2 ins; 0 del; 7 mod; Hi all, could you please review the patch for TimSortStackSize2 test? the test failed when externally passed (via -javaoption or -vmoption) -Xmx value is less than 770m or 385m, dependin

Re: RFR: Here are some URLClassPath patches

On Mon, Feb 26, 2018 at 3:38 PM, mandy chung wrote: > > > On 2/26/18 3:26 PM, Martin Buchholz wrote: > > > Looks okay. I also think no need to have a separate copyToArrayDeque >> method and just inline in the constructor. >> > > It's used twice. Also, it's likely to be replaced someday when we

Re: RFR: 8197594 - String and character repeat

On 2/18/18 1:37 AM, James Laskey wrote: Didn’t I hear someone mentioning “\U1D11A” at some point? On 2/19/18 7:55 AM, Martin Buchholz wrote: Oops, I already got it wrong - it's already at 6 hex digits because there are 17 planes, not 16.  MAX_CODE_POINT is U+10. Yes, we need a variable wi

Re: RFR: 8197594 - String and character repeat

To close the loop on this, I've reopened JDK-4993841, which requests adding an API Character.toString(int) which converts an int codepoint value to a String. (This seems like the obvious API, in parallel with Character.toString(char), but of course alternatives could be considered.) s'marks

Re: RFR: Here are some URLClassPath patches

On 2/26/18 3:26 PM, Martin Buchholz wrote: Looks okay.  I also think no need to have a separate copyToArrayDeque method and just inline in the constructor. It's used twice.  Also, it's likely to be replaced someday when we decide what to do with lambdas, so good to keep as a separa

Re: RFR: Here are some URLClassPath patches

On Mon, Feb 26, 2018 at 3:06 PM, mandy chung wrote: > > > On 2/21/18 12:30 PM, Martin Buchholz wrote: > line 63-64: ident further to the right as line 62 is the condition. > > Whitespace rejiggered. > Looks okay. I also think no need to have a separate copyToArrayDeque > method and just inline

Re: RFR: Here are some URLClassPath patches

On 2/26/18 3:10 PM, Martin Buchholz wrote: On Mon, Feb 26, 2018 at 3:06 PM, mandy chung > wrote: 8198480: Improve ClassLoaders static init block http://cr.openjdk.java.net/~martin/webrevs/jdk/ClassLoaders-static/

Re: RFR: Here are some URLClassPath patches

On Mon, Feb 26, 2018 at 3:06 PM, mandy chung wrote: > > 8198480: Improve ClassLoaders static init block > http://cr.openjdk.java.net/~martin/webrevs/jdk/ClassLoaders-static/ > https://bugs.openjdk.java.net/browse/JDK-8198480 > > > Can you rename initialModuleName to mainModule as Alan suggests (a

Re: RFR: Here are some URLClassPath patches

On 2/21/18 12:30 PM, Martin Buchholz wrote: OK, we have a reworked set of patches. (In my corner of openjdk we generally use real javadoc on private elements.) I reverted private doc comment style to the current maddening inconsistency, except I couldn't restrain myself from fixing -   

Re: RFR: Here are some URLClassPath patches

> On Feb 26, 2018, at 1:25 PM, Martin Buchholz wrote: > > > > On Mon, Feb 26, 2018 at 9:28 AM, Paul Sandoz > wrote: > > > > On Feb 23, 2018, at 2:09 PM, Martin Buchholz > > wrote: > > > > [+Paul] > > > > On Fri, Feb 23, 2018 at 6:

Re: RFR: Here are some URLClassPath patches

On Mon, Feb 26, 2018 at 9:28 AM, Paul Sandoz wrote: > > > > On Feb 23, 2018, at 2:09 PM, Martin Buchholz > wrote: > > > > [+Paul] > > > > On Fri, Feb 23, 2018 at 6:28 AM, Alan Bateman > wrote: > >> > >> 8198484: URLClassPath should use an ArrayDeque instead of a Stack > >> http://cr.openjdk.jav

Re: RFR 8181594: Efficient and constant-time modular arithmetic

Thanks for the initial feedback. Here is the latest webrev: http://cr.openjdk.java.net/~apetcher/8181594/webrev.01/ See inline below. On 2/23/2018 12:46 PM, Xuelei Fan wrote: ArrayUtil.java: === I'm not very sure how widely this utilities will be used in the future. Looks like on

Re: RFR: Here are some URLClassPath patches

> On Feb 23, 2018, at 2:09 PM, Martin Buchholz wrote: > > [+Paul] > > On Fri, Feb 23, 2018 at 6:28 AM, Alan Bateman wrote: >> >> 8198484: URLClassPath should use an ArrayDeque instead of a Stack >> http://cr.openjdk.java.net/~martin/webrevs/jdk/URLClassPath-ArrayDeque/ >> https://bugs.openjd

Re: [11] RFR: (JAXP) 8038043: Xerces Update: XInclude update

Looks good. Thanks! Best, Joe On 2/26/2018 7:34 AM, Aleks Efimov wrote: Hi Joe, Thank you for the review. I've updated XIncludeHandler and XIncludeTextReader files per your suggestions. XIncludeTextReader:191 line is still shown in Sdiffs as one line, but patch contains correct change that s

Re: RFR: 8198492: java/lang/StackWalker/CallerFromMain.java failed timeout.

On 2/25/18 3:51 PM, Claes Redestad wrote: Hi, the JDK-8198418[1] improvements to lambda bootstrapping meant initialization changed around to allow the possibility of a bootstrap race, which made it possible to cause a class loading deadlock when different threads try to initialize classes like

Re: Weird timezone issues with Timestamp.valueOf(String s)

Just to note that you really need someone from the JDBC maintenance group to comment. However, my understanding is that Timestamp conceptually represents a date and time **without reference to a time-zone**, exactly the same as LocalDateTime. But the implementation is poor, because it stores it us

Re: [11] RFR: (JAXP) 8038043: Xerces Update: XInclude update

Hi Joe, Thank you for the review. I've updated XIncludeHandler and XIncludeTextReader files per your suggestions. XIncludeTextReader:191 line is still shown in Sdiffs as one line, but patch contains correct change that splits it. New webrev: http://cr.openjdk.java.net/~aefimov/8038043/11/01

Re: JDK-6372077: JarFile.getManifest() should handle manifest attribute names up to 70 bytes

On 23/02/2018 19:58, Roger Riggs wrote: Please review this contribution from Philipp Kunz to handle manifest attribute names up to 70 bytes. The change passes the available regression tests. Manifest handling is somewhat sensitive so an additional review is appreciated. Webrev: (rebased from

Re: RFR: 8198492: java/lang/StackWalker/CallerFromMain.java failed timeout.

On 2018-02-26 12:21, Alan Bateman wrote: http://cr.openjdk.java.net/~redestad/8198492/jdk.00/ This looks okay to me to fix the current issue. There are several other bugs that look similar and I expect they will go away once you get this pushed. It might be useful to move JDK-8198492 to the

Re: RFR: 8198492: java/lang/StackWalker/CallerFromMain.java failed timeout.

On 25/02/2018 23:51, Claes Redestad wrote: Hi, the JDK-8198418[1] improvements to lambda bootstrapping meant initialization changed around to allow the possibility of a bootstrap race, which made it possible to cause a class loading deadlock when different threads try to initialize classes like