Re: Review Request JDK-8202113: Reflection API is causing caller classes to leak

2018-04-28 Thread Peter Levart
Hi Mandy, On 04/28/18 11:44, mandy chung wrote: Webrev: http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8202113/webrev.00/ The reflection machinery stores the caller class in each AccessibleObject such that it can skip the access check if access to a member has been verified for a given

Review Request JDK-8202113: Reflection API is causing caller classes to leak

2018-04-28 Thread mandy chung
Webrev: http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8202113/webrev.00/ The reflection machinery stores the caller class in each AccessibleObject such that it can skip the access check if access to a member has been verified for a given caller.  At the first time accessing the

Re: RFR: 8201650: Move iteration order randomization of unmodifiable Set and Map to iterators

2018-04-28 Thread Claes Redestad
Hi Stuart, On 2018-04-28 02:37, Stuart Marks wrote: Hi Claes, I finally got a chance to look at this. Overall looks fine. Although the randomness is "weaker" iterating in both directions will, I think, still have the desired effect of flushing out order dependencies. thanks, glad you

Re: Changed behavior of ParameterizedTypeImpl::toString in 1.8.0_171

2018-04-28 Thread Alan Bateman
On 27/04/2018 19:23, Rafael Winterhalter wrote: Hei Alan and David, thanks for pointing me to the issue, I have only searched the release notes for u172 by accident. The issue is mainly during builds. I run my library on multiple CI servers to cover Windows/Linux and different Java versions

Re: RFR (JDK11/NIO) 8201276: (fs) Add methods to Files for reading/writing a string from/to a file

2018-04-28 Thread Hamlin Li
Hi Joe, just a minor comment about the test in ReadWriteString.java. For both testMalformedWrite and testMalformedRead, temp files are not deleted, as Files.deleteIfExists(path); is skipped by the expected IOException. File.deleteOnExit​() may help. Thank you -Hamlin On 27/04/2018 12:50