Re: Question about libjava/childproc.c

2018-09-08 Thread Martin Buchholz
On Wed, Sep 5, 2018 at 11:43 AM, Thomas Stüfe wrote: > On Wed, Sep 5, 2018 at 6:43 PM, Martin Buchholz > wrote: > > > So before the readdir loop we should set errno to 0. Then when readdir > > returns NULL, we should check whether errno is non-zero. > > > > Note that if we fix this, we may run

Re: [RFR] 8205525 : Improve exception messages during manifest parsing of jar archives

2018-09-08 Thread Wang Weijun
Thinking about this again. Looks like the absolute path is not necessary. Even if there are multiple files using the same name, they will be in different directories, no matter absolute or relative. Suppose the jarPath info is used for debugging purpose mostly like the developer can find out wha

Re: [RFR] 8205525 : Improve exception messages during manifest parsing of jar archives

2018-09-08 Thread Sean Mullan
On 9/7/18 7:58 PM, Weijun Wang wrote: In my understanding, the author deliberately wants to show the absolute paths when there are multiple jar files with the same name (Ex: a jar hell). If you are very familiar with a particular application and understand the risks associated with running it,

RFR: JDK-8205461 Create Collector which merges results of two other collectors

2018-09-08 Thread Tomasz Linkowski
Hello, I'm responding to the thread at [1] (I'm not sure whether my message will get appended to it) and the CSR at [2]. I stumbled here from StackOverflow where - indepedently of all the others - I also came up with this type of "dual" *Collector* [3]. I named it "collectingBoth" there but I'd l

Re: RFR(M) : 8182404 : remove jdk.testlibrary.JDKToolFinder and JDKToolLauncher

2018-09-08 Thread Alan Bateman
On 07/09/2018 23:11, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8182404/webrev.00/index.html I skimmed through the changes and they look okay. One test to check is PatchSystemModules as it looks like /lib/testlibrary can be dropped from its @library tag. -Alan