RE: RFR (Enhancement): 6194856: Zip Files lose ALL ownership and permissions of the files

2018-09-30 Thread Langer, Christoph
Hi Sherman, thanks for getting back and bringing up these points. > (1) There is a "masked" security concern regarding adding the > "ownership/permission" into the jar file. > > "Security concern: > > The current signed jar spec only protects the name and content of the jar > entries. If any ex

Optimized HashSet.toArray()

2018-09-30 Thread Tagir Valeev
Hello! I think that HashSet.toArray(), HashMap.keySet().toArray() and HashMap.values().toArray() methods are used often enough to deserve a dedicated optimized implementation. Here's the patch I propose which is based on KeySet#forEach and AbstractCollection#toArray implementations: http://cr.open

Convert old-style array declarations (was: Re: ByteArrayOutputStream should not have a new writeBytes method in Java)

2018-09-30 Thread Tagir Valeev
Hello! Ok, let's start with smaller thing which is java.desktop. Created a JBS issue and posted a patch here: http://mail.openjdk.java.net/pipermail/2d-dev/2018-October/009486.html Jonathan, > Although cleanup like this is nice, I'll give a word of warning that pervasive > changes like that can

Re: RFR: 8207851 JEP Draft: Support ByteBuffer mapped over non-volatile memory

2018-09-30 Thread Alan Bateman
On 26/09/2018 14:27, Andrew Dinn wrote: : I'm not clear why we should only use one flag. The two flags I specified reflect two independent use cases, one where data stored in an NVM device is accessed read-only and another where it is accessed read-write. Are you suggesting that the read-only cas

Re: RFR(M) : 8211171 : move JarUtils to top-level testlibrary

2018-09-30 Thread Alan Bateman
On 27/09/2018 00:38, Igor Ignatyev wrote: here is the webrevs w/ JarUtils from default package inserted into jdk.test.lib.util.JarUtils: whole patch: http://cr.openjdk.java.net/~iignatyev//8211171/webrev.01/index.html 655

Re: RFR 8211295: DriverManager.getConnection fails when called from com.sun.rowset.JdbcRowSetImpl

2018-09-30 Thread Alan Bateman
On 29/09/2018 21:59, Lance Andersen wrote: Attached is the webrev for the JDBC RowSet/DriverManager issue, https://bugs.openjdk.java.net/browse/JDK-8211295 , that was raised on the thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/