Re: Review Request: JDK-8207146: Rename jdk.internal.misc.Unsafe::xxxObject to xxxReference

Hi Mandy, I took a look through all of this and it seems okay - though it was a little surprising how far the name change needed to spread. Thanks, David On 17/10/2018 2:08 AM, Mandy Chung wrote: Webrev: http://cr.openjdk.java.net/~mchung/jdk12/webrevs/8207146/webrev.00/ Unsafe::getObject r

[12]RFR 8210406: Refactor java.util.PluggableLocale:i18n shell tests to plain java tests

Hello, Please help review the fix for refactor java.util.PluggableLocale:i18n shell tests to plain java tests. Thank you. Bug: https://bugs.openjdk.java.net/browse/JDK-8210406 webrev: http://cr.openjdk.java.net/~dzhou/8210406/webrev.02/ Regards, Dora

Re: 6516099: InputStream.skipFully(int k) to skip exactly k bytes

Hi Roger, Updated patch: http://cr.openjdk.java.net/~bpb/6516099/webrev.01/ Thanks, Brian > On Oct 16, 2018, at 1:06 PM, Brian Burkhalter > wrote: > >> On Oct 16, 2018, at 12:53 PM, Roger Riggs > > wrote: >> >> InputStream.java: >> >> 584: Is there really a

Re: 6516099: InputStream.skipFully(int k) to skip exactly k bytes

Hi Roger, > On Oct 16, 2018, at 12:53 PM, Roger Riggs wrote: > > InputStream.java: > > 584: Is there really a case where line 585 would throw the exception? > > skip(n, true) != n > > With the 2nd argument = true, it will either skip the bytes or throw. > I think you can just call: "skip(

Re: 6516099: InputStream.skipFully(int k) to skip exactly k bytes

Hi Brian, Sorry for the delay in looking at this. InputStream.java: 584:  Is there really a case where line 585 would throw the exception? skip(n, true) != n With the 2nd argument = true, it will either skip the bytes or throw. I think you can just call:  "skip(n, true); Given subclasses

Re: RFR(JDK 12/NIO) 8202285: (fs) Add a method to Files for comparing file contents

On 16/10/2018 19:10, Joe Wang wrote: Hi Daniel, @linkplain it is!  Thanks!  And yes, int totalRead was fixed in the previous webrevs. Current version: specdiff: http://cr.openjdk.java.net/~joehw/jdk12/8202285/specdiff_v04/java/nio/file/Files.html webrevs: http://cr.openjdk.java.net/~jo

Re: RFR(JDK 12/NIO) 8202285: (fs) Add a method to Files for comparing file contents

Hi Daniel, @linkplain it is! Thanks! And yes, int totalRead was fixed in the previous webrevs. Current version: specdiff: http://cr.openjdk.java.net/~joehw/jdk12/8202285/specdiff_v04/java/nio/file/Files.html webrevs: http://cr.openjdk.java.net/~joehw/jdk12/8202285/webrev_v04/ Previous v

Review Request: JDK-8207146: Rename jdk.internal.misc.Unsafe::xxxObject to xxxReference

Webrev: http://cr.openjdk.java.net/~mchung/jdk12/webrevs/8207146/webrev.00/ Unsafe::getObject returns a reference to an object. Similarly Unsafe::putObject sets a reference in the given base+offset. This patch proposes to rename Unsafe xxxObject to xxxReference that will make the xxxReference API

Re: RFR(JDK 12/NIO) 8202285: (fs) Add a method to Files for comparing file contents

Hi Joe, There are a few places where {@linkplain } should be used instead of {@link }. For instance: 1545 * The two paths locate the {@link #isSameFile(Path, Path) same file}, This should be {@linkplain } - for the record {@link } will format the text as code, {@linkplain } will format