Re: [12] RFR JDK-8211266: [TESTBUG] jdk/nio/zipfs/ZipFSTester.java failed intermittently in ZipFSTester.checkRead()

Thank you Lance! Pushed. Thanks, Amy On 2018/11/22 2:34 AM, Lance Andersen wrote: Hi Amy, The changes seem reasonable. Best Lance On Nov 20, 2018, at 3:37 AM, Amy Lu > wrote: Please review. Thanks, Amy On 2018/11/12 2:17 PM, Amy Lu wrote: Please review this

Re: RFR JDK-8213909: jdeps --print-module-deps should report missing dependences

Hi Mandy, Delta webrev looks good. -Sundar On 21/11/18, 2:12 AM, Mandy Chung wrote: Hi Sundar, Per Joe's feedback on this CSR, a new `--no-recursive` option is added to restore the non-transitive behavior. Here is the delta webrev:

8214195: Align stdout messages in test/jdk/java/math/BigInteger/PrimitiveConversionTests.java

https://bugs.openjdk.java.net/browse/JDK-8214195 http://cr.openjdk.java.net/~bpb/8214195/webrev.00/ Print statements are different for float and double but should be the same. Thanks, Brian

Re: RFR 8177552: Compact Number Formatting support

Hi Nishit, On 11/21/18 12:53 AM, Nishit Jain wrote: Hi Naoto, Updated the webrev based on suggestions http://cr.openjdk.java.net/~nishjain/8177552/webrevs/webrev.01/ Changes made: - Replaced List with String[] to be added to the the resource bundles Good. - refactored

Re: [12] RFR JDK-8211266: [TESTBUG] jdk/nio/zipfs/ZipFSTester.java failed intermittently in ZipFSTester.checkRead()

Hi Amy, Looks fine, Thanks, Roger On 11/20/2018 03:37 AM, Amy Lu wrote: Please review. Thanks, Amy On 2018/11/12 2:17 PM, Amy Lu wrote: Please review this test fix for jdk/nio/zipfs/ZipFSTester.java bug: https://bugs.openjdk.java.net/browse/JDK-8211266 webrev:

Re: RFR 8177552: Compact Number Formatting support

Hi Nishit, Comments on the tests: - The tests looks to be quite complete. - Have the locale specific data been independently verified?    Or are they just assumed to be correct based on using CNF to generate the formatted strings? - Is there any overlap between the format and parse patterns

Re: [12] RFR JDK-8211266: [TESTBUG] jdk/nio/zipfs/ZipFSTester.java failed intermittently in ZipFSTester.checkRead()

Hi Amy, The changes seem reasonable. Best Lance > On Nov 20, 2018, at 3:37 AM, Amy Lu wrote: > > Please review. > > Thanks, > Amy > > On 2018/11/12 2:17 PM, Amy Lu wrote: >> Please review this test fix for jdk/nio/zipfs/ZipFSTester.java >> >> bug:

Re: 6516099: InputStream.skipFully(int k) to skip exactly k bytes

Looks fine Brian! On 11/21/2018 12:19 PM, Brian Burkhalter wrote: Hello, again, In response to comments on the CSR https://bugs.openjdk.java.net/browse/JDK-8214072 the following change to the verbiage is proposed: --- a/src/java.base/share/classes/java/io/InputStream.java +++

Re: 6516099: InputStream.skipFully(int k) to skip exactly k bytes

Hello, again, In response to comments on the CSR https://bugs.openjdk.java.net/browse/JDK-8214072 the following change to the verbiage is proposed: --- a/src/java.base/share/classes/java/io/InputStream.java +++ b/src/java.base/share/classes/java/io/InputStream.java @@ -562,7 +562,8 @@ *

Re: RFR: JDK-8214063: OpenJDK will not build on AIX while using the xlc 13.1 compiler

Hi Volker, Will do some digging and see if I can figure out the cause of the compilation problem. Also, I don't have a record of the original error after we added the JNIEXPORT/JNIIMPORT fix in, so I've got a build running now to reproduce it. Best Regards Adam Farley IBM Runtimes Volker

Re: Proposal: Add support for Process Groups to the JDK

Hi Thomas, I'd be interested in hearing more about the use cases. There seem to be many cases where containers are doing the management of groups of processes. The function will need to have an equivalent on Windows. The expressed use case is taking advantage of Posix/Unix signal behavior. But

Re: RFR: JDK-8214063: OpenJDK will not build on AIX while using the xlc 13.1 compiler

On Wed, Nov 21, 2018 at 12:44 PM Magnus Ihse Bursie wrote: > > > > On 2018-11-20 18:50, Volker Simonis wrote: > > On Tue, Nov 20, 2018 at 6:15 PM Thomas Stüfe > > wrote: > >> On Tue, Nov 20, 2018 at 6:12 PM Adam Farley8 > >> wrote: > >>> Heya Tom, > >>> > >>> "In JDK11 and JDK12, source files

Re: RFR: JDK-8214063: OpenJDK will not build on AIX while using the xlc 13.1 compiler

On Wed, Nov 21, 2018 at 1:46 PM Adam Farley8 wrote: > > Hi Volker, > > The NativeImageBuffer.cpp changes are best explained by the full text of > the referenced GitHub Pull Request, copied here for simplicity: > > - > Define JNIEXPORT and JNIIMPORT for xlc

Re: Proposal: Add support for Process Groups to the JDK

Hi David, On Wed, Nov 21, 2018 at 10:57 AM David Holmes wrote: > > On 21/11/2018 6:14 pm, Thomas Stüfe wrote: > > Ping.. no-one has any thoughts on this? > > I can see it being useful for test harnesses/frameworks. Oh, very much so! We use this feature in the framework that runs our nightlies.

Re: RFR: JDK-8214063: OpenJDK will not build on AIX while using the xlc 13.1 compiler

Hi Volker, The NativeImageBuffer.cpp changes are best explained by the full text of the referenced GitHub Pull Request, copied here for simplicity: - Define JNIEXPORT and JNIIMPORT for xlc version 13.1 or newer. Without this, almost no symbols are

Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

On 2018-11-21 11:08, Nick Gasson wrote: Hi Alan, Have you looked at replacing the remaining usages of stat changed to stat64 instead? I've tried this just now and it also resolves the issue. I can test on some more platforms and update the webrev if this is the preferred solution? I'd say

Re: RFR: JDK-8214063: OpenJDK will not build on AIX while using the xlc 13.1 compiler

On 2018-11-20 18:50, Volker Simonis wrote: On Tue, Nov 20, 2018 at 6:15 PM Thomas Stüfe wrote: On Tue, Nov 20, 2018 at 6:12 PM Adam Farley8 wrote: Heya Tom, "In JDK11 and JDK12, source files are compiled with -qvisibility=hidden when using xlc version other than 12.1. That doesn't seem

RE: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

Hi Alan, > Have you looked at replacing the remaining usages of stat changed to > stat64 instead? I've tried this just now and it also resolves the issue. I can test on some more platforms and update the webrev if this is the preferred solution? Thanks, Nick > -Original Message- >

Re: Proposal: Add support for Process Groups to the JDK

On 21/11/2018 6:14 pm, Thomas Stüfe wrote: Ping.. no-one has any thoughts on this? I can see it being useful for test harnesses/frameworks. It's not something I've ever looked at so have no first hand knowledge. I wonder how the semantics of Windows Jobs compare to *NIX process groups? Do

Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

On 21/11/2018 02:46, Nick Gasson wrote: Hi, Can someone please help me review this small makefile patch to fix an issue with java.io.File::setLastModified on 32-bit systems? https://bugs.openjdk.java.net/browse/JDK-8214077 http://cr.openjdk.java.net/~njian/8214077/webrev.0/ If the file size

Re: RFR 8177552: Compact Number Formatting support

Hi Naoto, Updated the webrev based on suggestions http://cr.openjdk.java.net/~nishjain/8177552/webrevs/webrev.01/ Changes made: - Replaced List with String[] to be added to the the resource bundles - refactored DecimalFormat.subparse() to be used by the CNF.parse(), to reduce code

Re: Proposal: Add support for Process Groups to the JDK

Ping.. no-one has any thoughts on this? Thanks, Thomas On Mon, Nov 12, 2018 at 6:29 PM Thomas Stüfe wrote: > > Dear all, > > may I please hear your thoughts about the following proposal? > > We would like to add support for process groups to the JDK: the > ability to put child processes into new