On 2018-12-17 07:42, Philipp Kunz wrote:
I did deliberately not touch the StringBuffer in the previous patch but
fully agree now I know it has a chance to be accepted. Would you accept
to replace StringBuffer with plain string concatenation afterhttp://op
enjdk.java.net/jeps/280 which was not
Hi Roger,
Thank you very much for your review and the feedback. Please find my
comments below and a new patch attached.
Philipp
On Wed, 2018-12-12 at 10:52 -0500, Roger Riggs wrote:
> Hi Phillip,
>
>
>
> Sorry, got busy...
>
>
>
> Can you rebase the patch to the current
Hi,
thanks Doug, this is nice reduction.
Here's the new webrev:
http://cr.openjdk.java.net/~mvala/jdk/jdk/JDK-8210280/webrev.03/
Just a nitpick, issue is in using linked-list in buckets. The same is used for
both HashMap and LinkedHashMap, so mentioning just LinkedHashMap might be
On 17/12/2018 12:51 pm, dean.l...@oracle.com wrote:
If we are adding JDK_EXPORT, does it make sense to add JDK_CALL as well?
It should never be necessary. JNICALL is only needed to ensure caller
and callee use the same calling convention. For JDK_EXPORT the caller
and callee are part of the
If we are adding JDK_EXPORT, does it make sense to add JDK_CALL as well?
dl
On 12/16/18 4:57 PM, David Holmes wrote:
Hi Magnus,
Thanks for explaining how addition of JNIEXPORT may have started this
problem.
One follow up:
This will also need a CSR request due to the change in linking
Hi Magnus,
Thanks for explaining how addition of JNIEXPORT may have started this
problem.
One follow up:
This will also need a CSR request due to the change in linking behaviour.
I'm not sure what you mean by this..? My entire intention here is that we should make no changes to documented
Den søn. 16. des. 2018 kl. 19:32 skrev Andy Herrick :
>
>
> On 12/15/2018 12:44 PM, Andy Herrick wrote:
> While investigating this, I found undocumented functionality left over
> from JavaFXPackager that may be the root of these class-path messages.
>
> This is both dangerous and powerful, and
On 12/15/2018 12:44 PM, Andy Herrick wrote:
I have yet to find out how to specify the bundle resources. It tells
to put them on the class path, but that cannot be right, as jpackage
is module.
Using default package resource [menu icon] (add package/movies.png
to the class path to
Den søn. 16. des. 2018 kl. 14:27 skrev Andy Herrick :
>
> The result of JDK-8213392 was not that there was any problem creating
> the package, but that the packaged app would not run, because the
> modules from the --module-path arg are never included in the packaged
> app, or referenced in the vm
On 12/14/18 1:37 AM, Michal Vala wrote:
> Thanks Martin for finding this serious issue and the testcase.
>
Sorry that I wasn't paying attention to this and so forced Martin to
discover the hard way that because of LinkeHashMap, you can't skip
doubling steps (at least not without a lot of
On 12/15/2018 2:48 PM, Sverre Moe wrote:
Den lør. 15. des. 2018 kl. 18:44 skrev Andy Herrick :
On 12/15/2018 11:26 AM, Sverre Moe wrote:
Some feedback from using this new JDK12 jpackage.
I have yet to find out how to specify the bundle resources. It tells to put
them on the class path,
11 matches
Mail list logo
