RE: RFR: 8207851 JEP Draft: Support ByteBuffer mapped over non-volatile memory

Hi Andrew, >>> Perhaps Intel also could provide help with testing? [Sadhya, is this an >>> option?] Yes, we can help with testing this feature as needed. Best Regards, Sandhya -Original Message- From: Andrew Dinn [mailto:ad...@redhat.com] Sent: Thursday, January 17, 2019 6:28 AM To: A

Re: Clarification in Attributes equal

Hi Philipp, I suspect the behavior dates back to the original implementation in JDK 1.2. I am not sure it should be changed at this point though the javadocs should be updated. Best Lance > On Jan 17, 2019, at 5:53 PM, Philipp Kunz wrote: > > Hi, > > In the JavaDoc comment for java.util.jar

Re: Compact Number Formatting and Fraction Digits

On Jan 17, 2019, at 2:22 PM, Gunnar Morling wrote: >> since you don’t actually want a minimum. > > I'd like to have 1 fractional digit unless it's 0: > > 1,000 -> 1K (*not* 1.0K) > 1,500 -> 1.5K > > --Gunnar That’s exactly what setting the maximum fraction digits to 1 does. Scott > >>

Re: RFR(XS): 8217349: Problem list java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java

Thanks Igor! Pushed. Cheers, Mikael > On Jan 17, 2019, at 2:07 PM, Igor Ignatyev wrote: > > Mikael, > > looks good and trivial to me. > > -- Igor > >> On Jan 17, 2019, at 2:02 PM, Mikael Vidstedt >> wrote: >> >> >> Please review this change which adds >> java/lang/invoke/LFCaching/LFM

Clarification in Attributes equal

Hi, In the JavaDoc comment for java.util.jar.Attributes#equals on line 269 it says: [...] Returns true if the given object is also an instance of Attributes [...] but that is not actually true. Passing a LinkedHashMap results also in true returned given equal content of both maps. Comment and impl

Re: RFR(XS): 8217349: Problem list java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java

Mikael, looks good and trivial to me. -- Igor > On Jan 17, 2019, at 2:02 PM, Mikael Vidstedt > wrote: > > > Please review this change which adds > java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java to the problem list > until the main bug has been addressed. > > Bug: https://bugs.op

RFR(XS): 8217349: Problem list java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java

Please review this change which adds java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java to the problem list until the main bug has been addressed. Bug: https://bugs.openjdk.java.net/browse/JDK-8217349 Webrev: http://cr.openjdk.java.net

Re: [13] RFR: 8210583: Base64.Encoder incorrectly throws NegativeArraySizeException

I agree with 'withOutputParam' comment. It does seem to require some explanation. Same for the newly introduced return value -1. The test: 46 // A separate output array is not required, as it is not used and 47 // the exception is thrown beforehand while calculating the siz

Re: RFR [test] 8217340: Compilation failed: tools/launcher/Test7029048.java

+1 > On Jan 17, 2019, at 3:20 PM, Roger Riggs wrote: > > Please review the addition of an @library /test/lib to ensure the compilation > succeeds. [1] > > diff --git a/test/jdk/tools/launcher/Test7029048.java > b/test/jdk/tools/launcher/Test7029048.java > --- a/test/jdk/tools/launcher/Test702

RFR [test] 8217340: Compilation failed: tools/launcher/Test7029048.java

Please review the addition of an @library /test/lib to ensure the compilation succeeds.  [1] diff --git a/test/jdk/tools/launcher/Test7029048.java b/test/jdk/tools/launcher/Test7029048.java --- a/test/jdk/tools/launcher/Test7029048.java +++ b/test/jdk/tools/launcher/Test7029048.java @@ -23,9 +

Re: Compact Number Formatting and Fraction Digits

> since you don’t actually want a minimum. I'd like to have 1 fractional digit unless it's 0: 1,000 -> 1K (*not* 1.0K) 1,500 -> 1.5K --Gunnar Am Do., 17. Jan. 2019 um 19:15 Uhr schrieb Scott Palmer : > > > On Jan 17, 2019, at 12:42 PM, Gunnar Morling wrote: > > >> this could be a good value ad

Re: Compact Number Formatting and Fraction Digits

On Jan 17, 2019, at 12:42 PM, Gunnar Morling wrote: >> this could be a good value add to introduce an API [...] > > Should I file a JDK issue then (not sure I can even)? > >> Wouldn’t this be accomplished with setMaximumFractionDigits(1) ? > > That wouldn't achieve that there's no fraction d

Re: Compact Number Formatting and Fraction Digits

> this could be a good value add to introduce an API [...] Should I file a JDK issue then (not sure I can even)? > Wouldn’t this be accomplished with setMaximumFractionDigits(1) ? That wouldn't achieve that there's no fraction digit(s) in case of trailing 0s. With min and max fraction digits set

Re: [RFR]: Per thread IO statistics in JFR

>Today we have File Read, File Write, Socket Read, and Socket Write > events. The hook points are added to the JDK using bytecode >instrumentation. This happens when you start a JFR recording, so there >is no overhead unless you use it. > >Erik However, in this context it's

Re: [RFR]: Per thread IO statistics in JFR

On Thu, Jan 17, 2019 at 1:31 PM Alan Bateman wrote: > > On 17/01/2019 07:23, Thomas Stüfe wrote: > > : > > > > Do you object against keeping these counters (which basically boils > > down to Thread::current->stat_structure->counter++)? Or do you even > > object against making upcalls into the jvm?

Re: [13] RFR: 8216969: ParseException thrown for certain months with russian locale

Hi Nishit, Thanks. Updated: http://cr.openjdk.java.net/~naoto/8216969/webrev.01/ Naoto On 1/17/19 2:57 AM, Nishit Jain wrote: Hi Naoto, Looks good to me. Just a small suggestion. - To improve readability, can we declare "standalone mask" (0x8000) as a static field and use that at all the p

Re: Jpackage Windows shortcuts

Note that the uninstall is still failing after I removed the spaces from the app name. I didn't mean to imply these issues were related. On Thu, Jan 17, 2019 at 11:00 AM Andy Herrick wrote: > yes - seeing several problems when space in app name - filed JDK-8217331 >

Re: [13] RFR: 8210583: Base64.Encoder incorrectly throws NegativeArraySizeException

Hi Nishit, In the test, there are a couple of RuntimeExceptions with messages that start with "As expected"... That's counter intuitive, that a failure of the test is reported with a message saying, its normal! I would use a message like:  "XXException should have been thrown..." The size o

Re: Jpackage Windows shortcuts

yes - seeing several problems when space in app name - filed JDK-8217331 and will address. /Andy On 1/17/2019 10:37 AM, Scott Palmer wrote: I'm creating a MSI installer. My application name did have spaces in it. I can confirm that changing t

Re: [RFR]: Per thread IO statistics in JFR

Hi Alan, On Thu, Jan 17, 2019 at 9:00 AM Alan Bateman wrote: > On 17/01/2019 07:23, Thomas Stüfe wrote: > > : > > Do you object against keeping these counters (which basically boils down > to Thread::current->stat_structure->counter++)? Or do you even object > against making upcalls into the jvm

Re: Jpackage Windows shortcuts

I'm creating a MSI installer. My application name did have spaces in it. I can confirm that changing the --name parameter to something without spaces avoids the issue, though this is still clearly a bug that needs to be fixed. It also seems that uninstall does not work. When I attempt it I get th

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation (update 2)

If I remove the line -nologo from lib-jdk.jpackage.gmk: 69 LDFLAGS_windows := -nologo, \ I get the logo during build (same with console andnon-console version): Microsoft (R) Incremental Linker Version 14.12.25835.0 Copyright (C) Microsoft Corporation.  All rights reserved. do I need so

Re: Compact Number Formatting and Fraction Digits

Wouldn’t this be accomplished with setMaximumFractionDigits(1) ? > On Jan 17, 2019, at 5:13 AM, Nishit Jain wrote: > > Hi Gunnar, > > Currently there is no way to obtain the below expected behavior (to get 1K) > when min fraction digit is set to non-zero value. I think that is not even > expe

jpackage OS X minimum OS version

It appears there is a minimum OS version? I created a toy app. From command line… open outputdir/TestApp.app LSOpenURLsWithRole() failed with error -10825 for the file /Users/mjh/HalfPipe/Test/outputdir/TestApp.app. Double click launching… You can’t use this version of the application “TestApp

Re: RFR: 8207851 JEP Draft: Support ByteBuffer mapped over non-volatile memory

Hi Alan, Thanks for your response. On 17/01/2019 12:53, Alan Bateman wrote: > I skimmed through the current draft. In the most recent discussion then > I think we had converged on "SYNC" rather than "PERSISTENT", the > reasoning being that there is persistence already with regular file > mapped f

Re: Jpackage Windows shortcuts

Simple tests of --win-menu and --win-shortcut options on Windows 7 are working for me.  Shortcuts are created as expected when running either the exe or msi installer generated. Can you share the full OS version and full command you use , perhaps some combination of options is not working. /

Re: RFR: 8207851 JEP Draft: Support ByteBuffer mapped over non-volatile memory

On 16/01/2019 11:23, Andrew Dinn wrote: Hi Alan/Brian, I have finally been able to shelve other commitments and return to this JEP (apologies for the hiatus). https://openjdk.java.net/jeps/8207851 The JEP has been reviewed positively by Stuart Marks (core libs) and Vladimir Kozlov (intrinsi

Re: [RFR]: Per thread IO statistics in JFR

On 2019-01-17 09:00, Alan Bateman wrote: On 17/01/2019 07:23, Thomas Stüfe wrote: : Do you object against keeping these counters (which basically boils down to Thread::current->stat_structure->counter++)? Or do you even object against making upcalls into the jvm? Note that, if deemed necessa

Re: [13] RFR: 8216969: ParseException thrown for certain months with russian locale

Hi Naoto, Looks good to me. Just a small suggestion. - To improve readability, can we declare "standalone mask" (0x8000) as a static field and use that at all the places? Regards, Nishit Jain On 17-01-2019 05:50, naoto.s...@oracle.com wrote: Hi, Please review the fix to the following issue:

Re: Compact Number Formatting and Fraction Digits

Hi Gunnar, Currently there is no way to obtain the below expected behavior (to get 1K) when min fraction digit is set to non-zero value. I think that is not even expected when min fraction digits is set, but considering the objective of compact number formatting this could be a good value add

Re: Jpackage Windows shortcuts

Does your application's name have spaces in it? I've found they don't work if it does. (Actually the bug is at the create-image step where it squashes those spaces in the filenames of the actual app launcher exe and cfg files; restoring them before doing the create-installer step fixes it for m

Compact Number Formatting and Fraction Digits

Hi, I took a look at the compact number formatting recently added in JDK 12. There's setMinimumFractionDigits() to control the number of fractional digits, so that e.g. 1,500 can be formatted as 1.5K. That's great, but it also will format 1,000 as 1.0K. Is there a way to have fractional digits bu

Re: [RFR]: Per thread IO statistics in JFR

On 17/01/2019 07:23, Thomas Stüfe wrote: : Do you object against keeping these counters (which basically boils down to Thread::current->stat_structure->counter++)? Or do you even object against making upcalls into the jvm? Note that, if deemed necessary, we could omit updating the counters un