Re: 8215976: OpenJDK fails to build with GCC when the #include inside zip.cpp comes from a non-sysroot path

2019-01-21 Thread David Holmes
Mach 5 tier 1 - 3 tests passed on Linux/OS X/Windows x64 and Solaris sparcv9. David On 22/01/2019 2:01 pm, David Holmes wrote: Hi Patrick, I'm putting this through our test system (again) and will report back when its complete. I also updated the bug report with the patch and assigned to

Re: 8215976: OpenJDK fails to build with GCC when the #include inside zip.cpp comes from a non-sysroot path

2019-01-21 Thread David Holmes
Hi Patrick, I'm putting this through our test system (again) and will report back when its complete. I also updated the bug report with the patch and assigned to Roger as the sponsor. Cheers, David On 22/01/2019 12:21 pm, Patrick Zhang wrote: Thanks Roger. I did a try to push the patch

RE: 8215976: OpenJDK fails to build with GCC when the #include inside zip.cpp comes from a non-sysroot path

2019-01-21 Thread Patrick Zhang
Thanks Roger. I did a try to push the patch within a branch to jdk/submit, and saw “Permission denied (publickey)”. I sent my SSH pub key to keys(at)openjdk.java.net but got no response. I heard only committers can have the access right, could you please help? Regards Patrick From: Roger

Re: Manifest copy constructor does not deeply copy individual section Attributes

2019-01-21 Thread Lance Andersen
Hi Philipp, This is going to take some further discussion/input as this has been documented for sometime as a shallow copy. If there is a consensus to move this forward, it will also require a CSR. I can help with that and sponsoring the updates, if the decision is to go ahead with the

Re: High memory usage / leaks was: Best mailing list for JVM embedding

2019-01-21 Thread David Holmes
Hi Robert, I've cc'd core-libs-dev as this is now about signed-jars and the launcher. David On 22/01/2019 4:48 am, Robert Marcano wrote: On 1/21/19 8:25 AM, Robert Marcano wrote: On 1/21/19 5:19 AM, Volker Simonis wrote: -- Moved to hotspot-dev -- Hi Robert, You can use

Re: RFR: 8207851 JEP Draft: Support ByteBuffer mapped over non-volatile memory

2019-01-21 Thread Brian Goetz
> Hi Alan/Brian, My apologies for having missed this the first time around; messages to lists get swept into folders, and staying on top of many lists is not an exact science. > I believe I have addressed all outstanding comments on the JEP per se, > including those made by Alan. Is it now

Re: RFR: 8207851 JEP Draft: Support ByteBuffer mapped over non-volatile memory

2019-01-21 Thread Andrew Dinn
Hi Alan, On 18/01/2019 13:32, Alan Bateman wrote: > I had a brief discussion with Brian about this yesterday. He brought up > the same concern about using MBB as it's not the right API for this in > the longer term.  So this JEP is very much about a short term/tactical > solution as we've

Re: RFR 8213031: (zipfs) Add support for POSIX file permissions

2019-01-21 Thread Alan Bateman
On 21/01/2019 09:17, Langer, Christoph wrote: : OK, I can see the point that in a PosixFileAttributeView as it is, there's no place for optionality/null values. However, with this approach the benefits would be that Files::get/setPosixPermissions would work and that's why I think we should

Re: RFR: JDK-8217269: jpackage Makefile improvments

2019-01-21 Thread Magnus Ihse Bursie
On 2019-01-18 15:18, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). The webrev includes all the jpackage Makefile Improvements listed in [1], other than what is covered by [4],

RE: RFR(XS): 8217438: Adapt tools//launcher/Test7029048.java for AIX

2019-01-21 Thread Langer, Christoph
Hi Goetz, looks good to me. I think it should rather be "AIX" than "Aix" in the output text - but it's a developer trace only, so probably nobody cares.  Best regards Christoph > -Original Message- > From: core-libs-dev On Behalf > Of Lindenmaier, Goetz > Sent: Montag, 21. Januar

Re: [13] RFR: 8210583: Base64.Encoder incorrectly throws NegativeArraySizeException

2019-01-21 Thread Nishit Jain
Hi Joe, Executing it on Mach5 platforms took around 3s to 5s. Below is the link https://java.se.oracle.com:10065/mdash/jobs/nishjain-jdk_04_09-20190121-0805-19402/results?search=status%3A* Also executed using JMH on local linux-64 VM (6GB RAM), it took ~2200 ms in SingleShotTime mode

Re: [13] RFR: 8210583: Base64.Encoder incorrectly throws NegativeArraySizeException

2019-01-21 Thread Nishit Jain
Thanks Roger, Updated. http://cr.openjdk.java.net/~nishjain/8210583/webrev.05/ Regards, Nishit Jain On 18-01-2019 21:13, Roger Riggs wrote: Hi Nishit, Looks good, with a minor fix. ok, the rationale for MAX_VALUE-2 make sense. TestEncodingDecodingLength: Line 61 and 68,   The error message

RFR(XS): 8217438: Adapt tools//launcher/Test7029048.java for AIX

2019-01-21 Thread Lindenmaier, Goetz
Hi, please review the following small test fix: http://cr.openjdk.java.net/~goetz/wr19/8217438-aix_launcherTest/01/ The Aix launcher always sets the path to the jdk libraries because Aix does not support $ORIGIN to find libjvm.so. So some of the test cases here fail. Skip them. Best regards,

RE: RFR 8213031: (zipfs) Add support for POSIX file permissions

2019-01-21 Thread Langer, Christoph
Hi Alan, first of all, thank you for your input on this. > I think the approach to explore are: > > 1. zipfs supports PosixFileAttributeView without subsetting. If > readAttribute(file, BasicFileAttributes.class) succeeds then > readAttribute(file, PosixFileAttributes.class) should also