Re: RFR: JDK-8224486: Arguments from jpackager cfg file not processed correctly

Hi, http://cr.openjdk.java.net/~almatvee/8224486/webrev.01/ - Original fix was missing (not sure why) setting Java options map flag to allow duplicates. Without it fix does not work. See OrderedMap.h line 92 and 261 and Package.cpp. - Old loop is kept to avoid possible regression in case if we

Re: JDK 14 RFR of JDK-8226809: Circular reference in printed stack trace is not correctly indented & ambiguous

Hi Joe, I think this patch and its revised output looks OK and agree about not adding a test for it. Brian > On Jun 28, 2019, at 4:42 PM, Joe Darcy wrote: > […] > > and the revised code prints this more helpfully as > > java.lang.Exception: first > at DejaVuStackTrace.main(DejaVuStackTra

Re: EnumSet.class serialization broken - twice

Daniel Fuchs pointed me to a weird thing they had to do with the serialVersionUID in one of the JMX classes: https://hg.openjdk.java.net/jdk/jdk/file/c59f36ed7b52/src/java.management/share/classes/javax/management/MBeanAttributeInfo.java#l46 Essentially the svuid for this class initialized in a

JDK 14 RFR of JDK-8226809: Circular reference in printed stack trace is not correctly indented & ambiguous

Hello, Please review the fix for     JDK-8226809: hCircular reference in printed stack trace is not correctly indented & ambiguous     http://cr.openjdk.java.net/~darcy/8226809.0/ Patch below. Consider the code which creates various circularities in the suppressed and caused links of an exc

Re: RFR (XS) 8224849 : Flag (?U:...) is allowed for non-capturing groups

Thank you Stuart for review and the edits! On 6/28/19 4:30 PM, Stuart Marks wrote: On 6/27/19 2:43 PM, Ivan Gerasimov wrote: Yes, good point about the spec change. Here's the CSR filed: https://bugs.openjdk.java.net/browse/JDK-8226914 Can you please review it at your convenience? Thanks fo

Re: RFR (XS) 8224849 : Flag (?U:...) is allowed for non-capturing groups

On 6/27/19 2:43 PM, Ivan Gerasimov wrote: Yes, good point about the spec change. Here's the CSR filed: https://bugs.openjdk.java.net/browse/JDK-8226914 Can you please review it at your convenience? Thanks for filing this. I've made some minor edits and have marked it reviewed. Note that when

Re: RFR: JDK-8226904: current working directory wrong running jpackage app

Hi Andy, http://cr.openjdk.java.net/~herrick/8226904/webrev.01/test/jdk/tools/jpackage/createappimage/JPackageCreateAppImageRuntimeBase.java.frames.html Do we need these extra System.out? Otherwise looks fine. Thanks, Alexander On 6/28/2019 10:59 AM, Andy Herrick wrote: Please review the jpac

Re: RFR: JDK-8226904: current working directory wrong running jpackage app

Looks good. - Alexey On 6/28/2019 1:59 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8226904 [2] http://cr.openjdk.java.net/

RFR: JDK-8226904: current working directory wrong running jpackage app

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8226904 [2] http://cr.openjdk.java.net/~herrick/8226904/webrev.01/ /Andy

Re: 8226863: [aix] jdk/java/lang/reflect/exeCallerAccessTest cannot launch on primordial thread

Hi Christoph, On Fri, Jun 28, 2019, 13:19 Langer, Christoph wrote: > Hi Thomas, > > > > I looked at this. > > > > One thing that catches my eye immediately: exeCallerAccessTest.c, line > 149: Looks like this #error would always fire on Windows. So the test > wouldn’t compile there…? Or am I wron

RFR: 8154520: java.time: appendLocalizedOffset() should return the localized "GMT" string

Hi, Request you to please review this change. JBS:https://bugs.openjdk.java.net/browse/JDK-8154520 Description:At present, the "DateTimeFormatterBuilder.appendLocalizedOffset()" method formulates the base string as "GMT", without accounting for locale-specific transformations. This

RE: 8226863: [aix] jdk/java/lang/reflect/exeCallerAccessTest cannot launch on primordial thread

Hi Thomas, I looked at this. One thing that catches my eye immediately: exeCallerAccessTest.c, line 149: Looks like this #error would always fire on Windows. So the test wouldn’t compile there…? Or am I wrong? Furthermore, if we do this new thread dance only on AIX, shouldn’t all the extra co