The rest of the CommandLine class uses nio Paths/Files, so the following
might be a better fit, and also checks whether the file can be read:
if (!Files.isReadable(Paths.of(name)))
The rest looks fine.
-- Kevin
On 6/29/2019 6:27 AM, Andy Herrick wrote:
Please review the jpackage fix for
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] https://bugs.openjdk.java.net/browse/JDK-8226751
[2] http://cr.openjdk.java.net/~herrick/8226751/
looks good
/Andy
On 6/28/2019 10:03 PM, Alexander Matveev wrote:
Hi,
http://cr.openjdk.java.net/~almatvee/8224486/webrev.01/
- Original fix was missing (not sure why) setting Java options map
flag to allow duplicates. Without it fix does not work. See
OrderedMap.h line 92 and 261 and
On 29/06/19 4:31 PM, Jaikiran Pai wrote:
> Hello Stuart,
>
> Thank you for the detailed response. Comments inline.
>
> On 28/06/19 2:48 AM, Stuart Marks wrote:
>> On 6/26/19 9:28 PM, Jaikiran Pai wrote:
>>> I am looking to contribute a patch for the enhancement noted in
>>>
Hello Stuart,
Thank you for the detailed response. Comments inline.
On 28/06/19 2:48 AM, Stuart Marks wrote:
> On 6/26/19 9:28 PM, Jaikiran Pai wrote:
>> I am looking to contribute a patch for the enhancement noted in
>> https://bugs.openjdk.java.net/browse/JDK-8225763. The change itself
>>
