Thank you Naoto for the review!
With kind regards,
Ivan
On 8/1/19 10:02 AM, naoto.s...@oracle.com wrote:
Hi Ivan,
The change looks good to me.
Naoto
On 7/31/19 9:21 PM, Ivan Gerasimov wrote:
Hello!
Pattern.compile fails with IOOB when normalizing a pattern that
contains a surrogate pair
Hi Joe,
It would be good to more closely define the semantics of the @Serial
annotation.
Suggestion for the first sentence:
"@Serial annotates each field or method specified by the Java
Object Serialization Specification of a {@linkplain Serializable
serializable} class."
This annotation
Hello, I tried to fix a bug in AnnotationParser that throws a
NullPointerException if an annotation enum property was refactored to an
enumeration type or vice versa but retained its old name.
There is currently no check if an annotation property is consistent with
the runtime type, only the exist
Hi Ivan,
The change looks good to me.
Naoto
On 7/31/19 9:21 PM, Ivan Gerasimov wrote:
Hello!
Pattern.compile fails with IOOB when normalizing a pattern that contains
a surrogate pair.
Would you please help review a trivial 1-line fix?
BUGURL: https://bugs.openjdk.java.net/browse/JDK-82283
Looks good to me, Thejasvi.
Naoto
On 8/1/19 6:42 AM, Thejasvi Voniadka wrote:
Hi,
Request you to please review this change.
JBS:https://bugs.openjdk.java.net/browse/JDK-8158880
(test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with
zh_CN locale)
Description:
Hi,
Request you to please review this change.
JBS:https://bugs.openjdk.java.net/browse/JDK-8158880
(test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with
zh_CN locale)
Description:The test "
test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java#
Hi Boris,
On 31/07/2019 13:01, Boris Ulasevich wrote:
> I did a quick check of the change across our platforms. Arm32 and x86_64
> built successfully. But I see it fails due to minor issues on aarch64
> and x86_32 with webrev.09.
> Can you please have a look at this?
>
>> src/hotspot/cpu/aarch64/
On 7/31/19 12:55 PM, Andrew Dinn wrote:
>> So if pre wbsync is no-op, why do we need to handle it everywhere? We seem
>> to be falling through all
>> the way to the stub to do nothing there, maybe we should instead cut much
>> earlier, e.g. when
>> inlining Unsafe.writeBackPresync0? Would it be b
Hello Dmitry,
On 01/08/2019 05:09, Dmitry Chuyko wrote:
> Just a small comment about the tests. As you can see, some of tests in
> jdk/java/nio/channels/FileChannel check various modes, arguments, and
> expected exceptions. E.g. see MapTest, Mode and Args.
>
> I noticed that in your changes for t
Hi Brent,
see my comments inline:
>Четверг, 1 августа 2019, 9:23 +03:00 от Laurent Bourgès
>:
>
>Hi Brent,
>
>Le jeu. 1 août 2019 à 02:32, Brent Christian < brent.christ...@oracle.com > a
>écrit :
>>Thanks, Laurent. I can sponsor this fix, get a RFR thread going for
>>JDK-8226297, keep webre
10 matches
Mail list logo