Hi Claes,
Some observations:
394 int u1 = CharacterDataLatin1.instance.toUpperCase(c1);
395 int u2 = CharacterDataLatin1.instance.toUpperCase(c2);
Changing u1 & u2 from char -> int, L399 now calls toLowerCase(int)
instead of toLowerCase(char). Should be fine, though. Speaking of:
399
An earlier version of this patch was reviewed [1] but I
didn't get back to explore the other approach. I rebase
the patch and take out the hotspot change which will be
covered by JDK-8229375:
http://cr.openjdk.java.net/~mchung/jdk14//8193325/webrev.01
David - can you re-review it?
thanks
Looks good.
On 8/9/2019 9:31 AM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Add build flag to statically link exe wrapper for msi files with MS
runtime lib.
[1]
looks good.
/Andy
On 8/9/19 12:31 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Add build flag to statically link exe wrapper for msi files with MS
runtime lib.
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Add build flag to statically link exe wrapper for msi files with MS
runtime lib.
[1] https://bugs.openjdk.java.net/browse/JDK-8229334
[2]
On 8/9/2019 9:25 AM, Roger Riggs wrote:
Hi Alexander,
I'm not sure we want to get into the business of telling people how
use use shell quoting.
It does vary from shell to shell and on Windows vs. Linux.
I'd pick one simple example that works on Windows as well as Linux.
I would have
I don't think we should put these examples in help text of
--java-options, and that we we should just close this bug as "not a bug".
The necessity of escaping option values with spaces and embedded quotes
applies to many other jpackage options as well.
The examples here don't really require
Hi Alexander,
I'm not sure we want to get into the business of telling people how use
use shell quoting.
It does vary from shell to shell and on Windows vs. Linux.
I'd pick one simple example that works on Windows as well as Linux.
I would have thought that the example in the bug report
On 2019-08-09 02:41, Jim Laskey wrote:
+1
Thanks, Jim!
/Claes
