Re: RFR [14/java.xml] 8230094: CCE in createXMLEventWriter(Result) over an arbitrary XMLStreamWriter

On 8/28/19 8:12 AM, Lance Andersen wrote: Hi Joe, The change and test look OK Thanks Lance! On Aug 27, 2019, at 1:20 PM, Joe Wang > wrote: Please review a patch for an issue where a custom impl of XMLStreamWriter caused a CCE. The problem was that our

Re: JDK 14 RFR of JDK-8230074: Improve specification for {Math, StrictMath}.negateExact

Hi Joe, Looks fine. Brian > On Aug 28, 2019, at 9:38 AM, Joe Darcy wrote: > > Please review the small amendment to make the specifications for some of the > "exact" methods in Math and StrictMath more explicit in their exceptional > behavior: > > JDK-8230074: Improve specification for

Re: 8229333: java/io/File/SetLastModified.java timed out

Looks fine Brian, fingers crossed the little bugger does not come back :-) > On Aug 27, 2019, at 2:00 PM, Brian Burkhalter > wrote: > > The failure reported in [1] was observed to occur on two Mac minis with HDDs. > Given the large file access it is possibly due to slow disk access. The >

Re: RFR: 8230302: GenerateJLIClassesPlugin can generate invalid DirectMethodHandle methods

Hi Mandy, On 2019-08-28 19:11, Mandy Chung wrote: On 8/28/19 7:38 AM, Claes Redestad wrote: Hi, we currently spin code for a non-sensical invokeVirtual DMH, so let's remove that. Such methods are benign since we won't ever attempt to resolve such nonsensical forms, but surely a waste of

Re: RFR: 8230302: GenerateJLIClassesPlugin can generate invalid DirectMethodHandle methods

On 8/28/19 7:38 AM, Claes Redestad wrote: Hi, we currently spin code for a non-sensical invokeVirtual DMH, so let's remove that. Such methods are benign since we won't ever attempt to resolve such nonsensical forms, but surely a waste of space. This patch tightens checks conservatively

Re: RFR: JDK-8229979: jpackage cleanup src files, help text, and javadoc

Understood. Thank you for explanation. - Alexey On 8/28/2019 12:43 PM, Andy Herrick wrote: On 8/28/2019 11:47 AM, Alexey Semenyuk wrote: Looks good. Some files in the review contain no diffs though, like

Re: JDK 14 RFR of JDK-8229997: Apply java.io.Serial annotations in java.base

Hi Joe, Looks fine, Roger On 8/27/19 9:28 PM, Joe Darcy wrote: Hello, Recent work for JDK-8202385: "Annotation to mark serial-related fields and methods" added the java.io.Serial annotation type to the platform. The intention of this new annotation type is to allow serialization-related

Re: RFR: JDK-8229979: jpackage cleanup src files, help text, and javadoc

On 8/28/2019 11:47 AM, Alexey Semenyuk wrote: Looks good. Some files in the review contain no diffs though, like http://cr.openjdk.java.net/~herrick/8229979/webrev.01/test/jdk/tools/jpackage/windows/exe/WinUpgradeUUIDTest.java.sdiff.html. Why are they in the review? I ran a script to

JDK 14 RFR of JDK-8230074: Improve specification for {Math, StrictMath}.negateExact

Hello, Please review the small amendment to make the specifications for some of the "exact" methods in Math and StrictMath more explicit in their exceptional behavior:     JDK-8230074: Improve specification for {Math, StrictMath}.negateExact     http://cr.openjdk.java.net/~darcy/8230074.0/

Re: JDK 14 RFR of JDK-8229997: Apply java.io.Serial annotations in java.base

On 28/08/2019 17:08, Joe Darcy wrote: The intention here is to be "mostly exhaustive" rather than "entirely exhaustive" in applying the annotation type so I'd prefer to defer updating generated exceptions to future work. Okay, although all you need is: $ hg diff make diff -r e17f768b3b71

Re: JDK 14 RFR of JDK-8229997: Apply java.io.Serial annotations in java.base

Should Serial.java have an @since 14 ?

Re: JDK 14 RFR of JDK-8229997: Apply java.io.Serial annotations in java.base

Hi Alan, On 8/27/2019 11:39 PM, Alan Bateman wrote: On 28/08/2019 02:28, Joe Darcy wrote: Hello, Recent work for JDK-8202385: "Annotation to mark serial-related fields and methods" added the java.io.Serial annotation type to the platform. The intention of this new annotation type is to

Re: RFR: JDK-8229979: jpackage cleanup src files, help text, and javadoc

Looks good. Some files in the review contain no diffs though, like http://cr.openjdk.java.net/~herrick/8229979/webrev.01/test/jdk/tools/jpackage/windows/exe/WinUpgradeUUIDTest.java.sdiff.html. Why are they in the review? - Alexey On 8/28/2019 9:36 AM, Andy Herrick wrote: Please review the

Re: RFR [14/java.xml] 8230094: CCE in createXMLEventWriter(Result) over an arbitrary XMLStreamWriter

Hi Joe, The change and test look OK > On Aug 27, 2019, at 1:20 PM, Joe Wang wrote: > > Please review a patch for an issue where a custom impl of XMLStreamWriter > caused a CCE. The problem was that our implementation was changed to an > internally extended interface. We could consider making

Re: RFR: JDK-8229979: jpackage cleanup src files, help text, and javadoc

Looks good. -- Kevin On 8/28/2019 6:36 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8229979 [2]

RFR: 8230302: GenerateJLIClassesPlugin can generate invalid DirectMethodHandle methods

Hi, we currently spin code for a non-sensical invokeVirtual DMH, so let's remove that. Such methods are benign since we won't ever attempt to resolve such nonsensical forms, but surely a waste of space. This patch tightens checks conservatively (could possibly apply the same restriction to

RFR: JDK-8229979: jpackage cleanup src files, help text, and javadoc

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8229979 [2] http://cr.openjdk.java.net/~herrick/8229979/ Thanks, Andy

Re: RFR: JDK-8224833: jpackages differences between platforms

This looks fine. /Andy On 8/27/2019 7:25 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8224833 [2]

Re: RFC: DMH lambda form arguments by jlink

Filed: https://bugs.openjdk.java.net/browse/JDK-8230302 to deal with the bug that the plugin can and does generate some invalid DMHs https://bugs.openjdk.java.net/browse/JDK-8230301 to re-examine the ability to hardcode default sets of DMHs, invokers etc. This can and should be controlled

Re: JDK 14 RFR of JDK-8229997: Apply java.io.Serial annotations in java.base

On 28/08/2019 02:28, Joe Darcy wrote: Hello, Recent work for JDK-8202385: "Annotation to mark serial-related fields and methods" added the java.io.Serial annotation type to the platform. The intention of this new annotation type is to allow serialization-related fields and methods to be