There's a strong expectation that ctrl-A and ctrl-a both map to \u0001, so
I support Ivan's initiative.
I'm surprised java regex gets this wrong.
Might need a transitional system property.
What's the best bit-twiddle? Untested:
if ((c ^= 0x40) < 0x20) return c;
if ((c ^=0x20) <= 26 && c > 0) ret
Looks good.
- Alexey
On 8/30/2019 7:44 PM, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
1) This file is not used and was removed.
2) This file was removed due to JDK-822
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
1) This file is not used and was removed.
2) This file was removed due to JDK-8221333.
3) Removed unused services code.
[1] https://bugs.openjdk.java.n
On 8/30/2019 7:15 PM, Alexander Matveev wrote:
Hi Alexey,
Looks good. Any plans to convert all tests to use new helper classes?
Yes, of course! I plan to do this is steps:
1. Refactor Linux tests;
2. Refactor Windows tests;
3. Refactor OSX tests;
I'll cover steps 1 and 2 myself once I sort
Hello!
In the two implementations of PermissionCollection.implies(Permission),
all the permissions are traversed, and their corresponding bit mask are
checked.
For example, here's a snippet from FilePermission.java:
int desired = fperm.getMask();
int effective = 0;
in
Hi Alexey,
Looks good. Any plans to convert all tests to use new helper classes?
Thanks,
Alexander
On 8/30/2019 2:55 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- ad
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- added jtreg test for --linux-app-category option;
- added jtreg test for --linux-release option; This is to address [3] issue;
- introduced helper cla
Not really a review, but:
For many years we've been using 10 seconds (scaled by timeout factor) as a
duration long enough that a timeout is a real failure.
Which is close to your own 20 seconds. Of course, no value is surely safe.
Probably, parallel testing infrastructure for timeouts should be
On 30/08/2019 13:54, Pavel Rappo wrote:
Updated,
http://cr.openjdk.java.net/~prappo/8151678/webrev.01/
Changes look good!
best regards,
-- daniel
Updated,
http://cr.openjdk.java.net/~prappo/8151678/webrev.01/
> On 30 Aug 2019, at 12:28, Daniel Fuchs wrote:
>
> Hi Pavel,
>
> Looks probably OK ;-)
>
> One thing though is that it's not always guaranteed that
> InetAddress.getByName("localhost") will resolve to the same
> address than
+1
> On Aug 29, 2019, at 11:34 PM, Amy Lu wrote:
>
> jdk/internal/jimage/JImageOpenTest.java
>
> This test is not a testng test, and is not running any test after
> TEST.properties was introduced at the same directory with:
> TestNG.dirs = .
>
> There are two tests in this directory: JImageRe
Hi Vyom
On Wed, 28 Aug 2019 at 08:26, Vyom Tewari26 wrote:
>
> Hi Milan,
>
> If i am reading code correctly then for each retry you are doubling the
> retryTimeout(int retryTimeout = (timeout * (1 << retry));) which is right
> retry strategy, So the timeout set to TCP instance is already doubl
Hi Pavel,
Looks probably OK ;-)
One thing though is that it's not always guaranteed that
InetAddress.getByName("localhost") will resolve to the same
address than that returned by InetAddess.getLoopbackAddress(),
so it may be better to use the literal address (which may be
an IPv6 literal requiri
//
// Dear maintainer:
//
// Once you are done trying to 'optimize' this routine,
// and have realized what a terrible mistake that was,
// please incremen
Thank you Alan!
Pushed.
Thanks,
Amy
On 8/30/19 2:50 PM, Alan Bateman wrote:
On 30/08/2019 03:34, Amy Lu wrote:
jdk/internal/jimage/JImageOpenTest.java
This test is not a testng test, and is not running any test after
TEST.properties was introduced at the same directory with:
TestNG.dirs =
Hi,
just a gentle reminder for a RFR of [1] (see [5] for the original request).
An efficient implementation can be found on [2] and in Brian
Burkhalter's webrev area [3]. This also requires a review. The full
details are discussed in [4].
Greetings
Raffaello
[1] https://bugs.openjdk.
16 matches
Mail list logo