Re: RFR 8235361 : JAR Class-Path no longer accepts relative URLs encoding absolute Windows paths (e.g "/C:/...")

Thank you all for the real quick fix for these 2 issues. In the context of Quarkus project, trying to get a decent workaround to get past these issues across all prominent Java versions (and OS) was starting to get a bit out of hand. But with this fixed consistently within in the JDK now, it's

Re: RFR(M):8167065: Add intrinsic support for double precision shifting on x86_64

Testing results are good after fixing the typo. We should consider implementing this intrinsic in Graal too. We have to upload AOT and Graal test changes anyway. Thanks, Vladimir On 12/20/19 3:47 PM, Vladimir Kozlov wrote: Hi Smita, You have typo (should be supports_vbmi2):

Re: RFR(M):8167065: Add intrinsic support for double precision shifting on x86_64

Hi Smita, You have typo (should be supports_vbmi2): src/hotspot/cpu/x86/assembler_x86.cpp:6547:22: error: 'support_vbmi2' is not a member of 'VM_Version' assert(VM_Version::support_vbmi2(), "requires vbmi2"); ^ Debug build failed. I am retesting with

Re: RFR(M):8167065: Add intrinsic support for double precision shifting on x86_64

We should have added core-libs to review since you modified BigInteger.java. webrev02 looks good to me. Let me test it. Thanks, Vladimir On 12/20/19 1:52 PM, Kamath, Smita wrote: Hi Vladimir, Thank you for reviewing the code. I have updated the code as per your recommendations ( please look

[15] RFR: 8227313: Support monetary grouping separator in DecimalFormat/DecimalFormatSymbols

Hi, Please review the fix for the following issue: https://bugs.openjdk.java.net/browse/JDK-8227313 The proposed CSR and changeset are located at: https://bugs.openjdk.java.net/browse/JDK-8235942 https://cr.openjdk.java.net/~naoto/8227313/webrev.00/ The change introduces the new monetary

RFR: JDK-8236132: Add missing properties to msi installers

Please review fix [2] for jpackage bug [1]. Add properties to msi installers to properly display installation location and icon of the application in the list of installed applications. - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8236132 [2]

Re: RFR: JDK-8233578: Document configurable parameters of msi packages

looks good. /Andy On 12/19/2019 8:52 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Comments added to the default WiX source file explaining how the default file is expected to be overridden. - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8233578 [2]

Re: RFR: JDK-8232077: Investigate if default behavior should allow downgrade scenario

fix looks fine. /Andy On 12/19/2019 8:02 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. The fix changes the default setting for Windows installers to allow downgrades. - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8232077 [2]

Re: RFR 8234362: k_standard.c is not needed and should be removed

* Florian Weimer: > * Florian Weimer: > >> __kernel_standard in src/java.base/share/native/libfdlibm/k_standard.c >> is built for _IEEE_LIBM targets as well, but it appears superfluous >> there. >> >> In noticed this because GCC 10 flags an uninitialized variable in this >> code: >> >>

Re: [PING] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy

Hi Bob, Sorry for the delay to get this updated. Changes done in this latest webrev: 1. Rebased on top of 8226575: OperatingSystemMXBean should be made container aware. File read ops now use privileged code. 2. Warning for mixed cgroup controllers and returning null for metrics.