Re: RFR: JDK-8239139 testmake fail with warning about strncpy using gcc version 8

2020-02-16 Thread Magnus Ihse Bursie
On 2020-02-17 08:48, linzang(臧琳) wrote: Hi, May I ask help to review one tiny fix of build failure described at https://bugs.openjdk.java.net/browse/JDK-8239139 Root cause is gcc version 8 prints warning for strncpy. The fix simply replace strncpy with snprintf. Thanks!

Re: JEP 370 - text example leads to exception

2020-02-16 Thread Chris T
Maurizio, thanks for pointing the bug out - however I don't think I was impacted by it. I agree with you that a more complex examples might distract the audience from the main presentation points. As mentioned in one of my previous email, I finalized some examples myself: 1. One example for

Re: JDK-8237818: Typo in Unsafe: resposibility

2020-02-16 Thread Aya Ebata
Hi, Thanks for pushing changes! regards, Aya Ebata 2020年2月17日(月) 11:37 Yasumasa Suenaga : > On 2020/02/17 11:21, David Holmes wrote: > > Hi Yasumasa, > > > > On 17/02/2020 11:38 am, Yasumasa Suenaga wrote: > >> Hi David, > >> > >> On 2020/02/17 8:10, David Holmes wrote: > >>> On 17/02/2020

Re: RFR: 8211917: (zipfs) Creating or updating a JAR file system should put the MANIFEST.MF at the start

2020-02-16 Thread Jaikiran Pai
Hello Lance, On 15/02/20 2:27 am, Lance Andersen wrote: > Hi Jaikiran, > > I think the changes to ZipFileSystem are OK. > > The test overall is good.  I am going to streamline it a bit and > remove the long lines (we try to keep lines to around 80 characters). > I'll keep that in mind for future

Re: JDK-8237818: Typo in Unsafe: resposibility

2020-02-16 Thread Yasumasa Suenaga
On 2020/02/17 11:21, David Holmes wrote: Hi Yasumasa, On 17/02/2020 11:38 am, Yasumasa Suenaga wrote: Hi David, On 2020/02/17 8:10, David Holmes wrote: On 17/02/2020 12:40 am, Aya Ebata wrote: Hi, I sent OCA today. So it hasn't been approved yet. I'm waiting for approval. For this

Re: JDK-8237818: Typo in Unsafe: resposibility

2020-02-16 Thread David Holmes
Hi Yasumasa, On 17/02/2020 11:38 am, Yasumasa Suenaga wrote: Hi David, On 2020/02/17 8:10, David Holmes wrote: On 17/02/2020 12:40 am, Aya Ebata wrote: Hi, I sent OCA today. So it hasn't been approved yet. I'm waiting for approval. For this trivial contribution an OCA is a not required,

Re: JDK-8237818: Typo in Unsafe: resposibility

2020-02-16 Thread Yasumasa Suenaga
Pushed: http://hg.openjdk.java.net/jdk/jdk/rev/f3f66f9e98ee Yasumasa On 2020/02/17 10:38, Yasumasa Suenaga wrote: Hi David, On 2020/02/17 8:10, David Holmes wrote: On 17/02/2020 12:40 am, Aya Ebata wrote: Hi, I sent OCA today. So it hasn't been approved yet. I'm waiting for approval.

Re: JDK-8237818: Typo in Unsafe: resposibility

2020-02-16 Thread Yasumasa Suenaga
Hi David, On 2020/02/17 8:10, David Holmes wrote: On 17/02/2020 12:40 am, Aya Ebata wrote: Hi, I sent OCA today. So it hasn't been approved yet. I'm waiting for approval. For this trivial contribution an OCA is a not required, so this can be sponsored before the OCA goes through

Re: JDK-8237818: Typo in Unsafe: resposibility

2020-02-16 Thread David Holmes
On 17/02/2020 12:40 am, Aya Ebata wrote: Hi, I sent OCA today. So it hasn't been approved yet. I'm waiting for approval. For this trivial contribution an OCA is a not required, so this can be sponsored before the OCA goes through processing. Cheers, David regards, Aya Ebata

Re: [PATCH] Enhancement proposal for java.util.StringJoiner

2020-02-16 Thread Сергей Цыпанов
Hello, I've complitely reworked the patch according to investigation in [1]. 1) usage of JavaLangAccess allows to rid reflection completely and access package-private String.isLatin1 via SharedSecrets only, so no black wizardry any more 2) now we have only a few cases with noticeable

Re: JDK-8237818: Typo in Unsafe: resposibility

2020-02-16 Thread Aya Ebata
Hi, I sent OCA today. So it hasn't been approved yet. I'm waiting for approval. regards, Aya Ebata 2020年2月16日(日) 16:49 Yasumasa Suenaga : > Hi Aya, > > It looks good to me. > BTW, have you signed to OCA? If so, I will sponsor you. > > > Thanks, > > Yasumasa > > > On 2020/02/16 16:42, 江畑 彩

Re: 8202469 / 8202473: Correct type annotation resolution for class type variables

2020-02-16 Thread Joel Borggrén-Franck
Hi Rafael, Thanks for reaching out and reminding me of this! I managed to find some time to look into 8202469 during the weekend. By swapping place of the TVars in the test I managed to isolate this without depending on 8202473, take a look at my hacky copy-paste update to your test at