Alexey, all,
In my case the update, as described, seems to work just fine. However once
I try to actually start the application nothing happens. It silently fails.
Could this be a reason why you don't encounter any issue? Just an idea
though...
-- Daniel
Alexey Semenyuk schrieb am Mi., 26.
On 2/26/20 7:50 PM, David Holmes wrote:
Hi Calvin,
Adding core-libs-dev as you are messing with their code :)
On 27/02/2020 1:19 pm, Calvin Cheung wrote:
JBS: https://bugs.openjdk.java.net/browse/JDK-8232081
webrev: http://cr.openjdk.java.net/~ccheung/jdk15/8232081/webrev.00/
The proposed
Hi Calvin,
Adding core-libs-dev as you are messing with their code :)
On 27/02/2020 1:19 pm, Calvin Cheung wrote:
JBS: https://bugs.openjdk.java.net/browse/JDK-8232081
webrev: http://cr.openjdk.java.net/~ccheung/jdk15/8232081/webrev.00/
The proposed changeset for this RFE adds a
Thanks for the review!
Dan
On 2/26/20 7:36 PM, David Holmes wrote:
Looks good.
Thanks,
David
On 27/02/2020 9:03 am, Daniel D. Daugherty wrote:
Greetings,
I'm trying to reduce the noise in the jdk/jdk CI. I'm ProblemListing
javax/script/Test7.java on all platforms due to this bug:
Looks good.
Thanks,
David
On 27/02/2020 9:03 am, Daniel D. Daugherty wrote:
Greetings,
I'm trying to reduce the noise in the jdk/jdk CI. I'm ProblemListing
javax/script/Test7.java on all platforms due to this bug:
JDK-8239361 javax/script/Test7.java failed due to ScriptException
Greetings,
I'm trying to reduce the noise in the jdk/jdk CI. I'm ProblemListing
javax/script/Test7.java on all platforms due to this bug:
JDK-8239361 javax/script/Test7.java failed due to ScriptException
https://bugs.openjdk.java.net/browse/JDK-8239361
I'm using the following subtask
Hi Bob,
On 27/02/2020 7:01 am, Bob Vandette wrote:
Here’s an updated webrev that implementes the suggestion that allows
JNIEXPORT in jni.h to be overridden
and the build limits visibility for static libraries.
! #if (defined(__GNUC__) && ((__GNUC__ > 4) || (__GNUC__ == 4) &&
On 26/02/2020 11:25 pm, Claes Redestad wrote:
On 2020-02-26 14:19, Claes Redestad wrote:
I don't think a CSR is required, but bringing it up since others think
otherwise.
s/since/in case/
An observable change in behaviour of a public API definitely needs a CSR
request.
Thanks,
David (CSR
Greetings,
I'm trying to reduce the noise in the jdk/jdk CI. I'm ProblemListing
javax/script/Test7.java on all platforms due to this bug:
JDK-8239361 javax/script/Test7.java failed due to ScriptException
https://bugs.openjdk.java.net/browse/JDK-8239361
I'm using the following subtask
Hi Andy,
Looks good.
Thanks,
Alexander
On 2/26/2020 2:01 PM, Alexey Semenyuk wrote:
Looks good.
Minor note: I'd declare isValidBundleIdentifier() as static private.
- Alexey
On 2/26/2020 12:48 PM, Andy Herrick wrote:
Please review the fix to issue [1] at [2].
The initial concern with
Looks good.
Minor note: I'd declare isValidBundleIdentifier() as static private.
- Alexey
On 2/26/2020 12:48 PM, Andy Herrick wrote:
Please review the fix to issue [1] at [2].
The initial concern with defaulting to the application or installer
name was that is might not be a valid mac
Daniel,
Interesting. We have jtreg tests for testing upgrade scenarios on
Windows and they work without Upgrade element in WiX template.
- Alexey
On 2/26/2020 11:10 AM, Daniel Peintner wrote:
All,
after some private discussions with James and @Kevinnns I believe the
necessary change to let
On 2020-02-26 19:27, Ivan Gerasimov wrote:
Looks good to me!
The copyright years need to be updated.
Done and pushed.
Thanks!
/Claes
Here’s an updated webrev that implementes the suggestion that allows JNIEXPORT
in jni.h to be overridden
and the build limits visibility for static libraries.
If this webrev is accepted, I’ll update the CSR solution to match this
implementation.
Takiguchi-san,
Some nits:
- Please add 'noreg-self' to the jira issue.
- Copyright year should be modified.
- Add the bug number to '@bug' tag.
Naoto
On 2/26/20 10:03 AM, Ichiroh Takiguchi wrote:
Hello.
Could you review the fix ?
Bug: https://bugs.openjdk.java.net/browse/JDK-8239965
Hi Florian,
This isn't a common usage.
For the below code:
String s1 = "s1".intern();
f.set("s1".intern(), f.get("s2"));
After calling reflection, the value of s1 is changed to "s2".
In some special scenarios, the original jar file can't be modified. But the
user
expects to change the value
Looks good to me!
The copyright years need to be updated.
With kind regards,
Ivan
On 2/26/20 6:12 AM, Claes Redestad wrote:
Hi,
I took the liberty to file
https://bugs.openjdk.java.net/browse/JDK-8240094 for this.
Webrev: http://cr.openjdk.java.net/~redestad/8240094/open.00/
I added a
Hello.
Could you review the fix ?
Bug:https://bugs.openjdk.java.net/browse/JDK-8239965
Change: https://cr.openjdk.java.net/~itakiguchi/8239965/webrev.00/
Sorry for side effect.
Test4625418.java should skip Cp943 and x-IBM943 should be skipped
after JDK-8235834 [1] was integrated.
[1]
Please review the fix to issue [1] at [2].
The initial concern with defaulting to the application or installer name
was that is might not be a valid mac package identifier (use only
alphanumeric, '.' , and '-' chars) but this can be true when the id is
derived from main class (as in
I filed issue:
JDK-8240111: issue upgrading app built with javapackager to one
built with jpackage.
and included your description and suggested fix.
/Andy
On 2/26/2020 11:10 AM, Daniel Peintner wrote:
I believe the
necessary change to let upgrades succeed is rather minimal.
The WIX
All,
after some private discussions with James and @Kevinnns I believe the
necessary change to let upgrades succeed is rather minimal.
The WIX template jpackage uses
needs to have
as well within the product element.
I wonder whether anyone in the jpackage team is willing to work or look
On 2020-02-26 15:56, Bob Vandette wrote:
On Feb 26, 2020, at 9:17 AM, Magnus Ihse Bursie
wrote:
On 2020-02-26 14:31, Bob Vandette wrote:
On Feb 26, 2020, at 7:31 AM, Magnus Ihse Bursie
wrote:
On 2020-02-26 08:41, David Holmes wrote:
Hi Bob,
Adding build-dev.
Thanks for noticing that
> On Feb 26, 2020, at 9:17 AM, Magnus Ihse Bursie
> wrote:
>
> On 2020-02-26 14:31, Bob Vandette wrote:
>>
>>> On Feb 26, 2020, at 7:31 AM, Magnus Ihse Bursie
>>> wrote:
>>>
>>> On 2020-02-26 08:41, David Holmes wrote:
Hi Bob,
Adding build-dev.
>>> Thanks for noticing
Hi,
On 2020-02-26 15:42, Сергей Цыпанов wrote:
Hello,
thanks for doing this!
thank you for the contribution!
I've checked it myself with similar benchmark > After
SubstringAndStripBenchmark.substring avgt
30 2.423 ± 0.172 ns/op
2.4ns... seems
Hello,
here's the periodic monthly reminder that the latest patches of [1] have
been submitted more than 10 months ago [2] and are waiting for a review.
Full background documentation is available at [3].
Greetings
Raffaello
[1] https://bugs.openjdk.java.net/browse/JDK-8202555
[2]
Hello,
thanks for doing this! I've checked it myself with similar benchmark
@Warmup(iterations = 10, time = 1)
@Measurement(iterations = 10, time = 1)
@BenchmarkMode(Mode.AverageTime)
@OutputTimeUnit(TimeUnit.NANOSECONDS)
@Fork(value = 3, jvmArgsAppend = {"-Xms4g", "-Xmx4g",
On 2020-02-26 14:31, Bob Vandette wrote:
On Feb 26, 2020, at 7:31 AM, Magnus Ihse Bursie
wrote:
On 2020-02-26 08:41, David Holmes wrote:
Hi Bob,
Adding build-dev.
Thanks for noticing that we were missing, David!
Sorry, I should have included you folks.
On 26/02/2020 6:37 am, Bob
Also, we've worked hard to get rid of the map files in the build system.
I'd be hesitant to say the least to re-introduce them.
/Magnus
On 2020-02-26 14:29, Bob Vandette wrote:
Thanks but I don’t like that idea for several reasons.
1. It’s too dramatic of a change for the immediate problem
Hi Vyom,
I tried out your patch and got no suspicious failures so
you have my review :-)
best regards,
-- daniel
On 15/02/2020 04:14, Vyom Tewari26 wrote:
I'll get back to you when I have managed to find some
cycles to do so.
best regards,
-- daniel
On 14/02/2020 04:57, Vyom Tiwari wrote:
Hi,
I took the liberty to file
https://bugs.openjdk.java.net/browse/JDK-8240094 for this.
Webrev: http://cr.openjdk.java.net/~redestad/8240094/open.00/
I added a trivial micro and verified that there's a roughly 2.5x
improvement in this targeted test on my machine (~10 ns/op -> ~4ns/op),
Thanks but I don’t like that idea for several reasons.
1. It’s too dramatic of a change for the immediate problem I’m trying to solve.
2. It creates a support issue. Every time a new native function is added or
removed, we’d have several files
that would need to be updated (1 per OS type).
3.
> On Feb 26, 2020, at 7:31 AM, Magnus Ihse Bursie
> wrote:
>
> On 2020-02-26 08:41, David Holmes wrote:
>> Hi Bob,
>>
>> Adding build-dev.
> Thanks for noticing that we were missing, David!
Sorry, I should have included you folks.
>
>>
>> On 26/02/2020 6:37 am, Bob Vandette wrote:
>>>
On 2020-02-26 14:19, Claes Redestad wrote:
I don't think a CSR is required, but bringing it up since others think
otherwise.
s/since/in case/
On 2020-02-26 11:01, Сергей Цыпанов wrote:
Currently we have
public static String stripLeading(byte[] value) {
int left = indexOfNonWhitespace(value);
if (left == value.length) {
return "";
}
return (left != 0) ? newString(value, left, value.length - left) : null;
}
With the
- Mail original -
> De: "向伟(识月)"
> À: "Florian Weimer"
> Cc: "core-libs-dev" , "hotspot-runtime-dev"
>
> Envoyé: Mercredi 26 Février 2020 13:45:52
> Objet: 回复：回复：VM crashed at StringTable expansion
> Hi Florian, Alan,
>
>public static void main(String[] args) throws Exception
On 26/02/2020 12:45, 向伟(识月) wrote:
:
It is an internal library, we may suggest the user to change their code.
But actually, it isn't easy to find the code if the other users have similar
usage.
If you with --illegal-access=debug then you'll get a stack trace that
should help you quickly
Hi Florian, Alan,
public static void main(String[] args) throws Exception {
String s1 = "s1".intern();
System.out.println("before reflect s1 = " + s1);
Field f = String.class.getDeclaredField("value");
f.setAccessible(true);
f.set("s1".intern(),
Hi Bob,
On 25/02/2020 20:37, Bob Vandette wrote:
>
> Please review this RFE that alters the visibility of JNI entrypoints to
> hidden when a shared library
> is created using static JDK libraries.
As David Holmes mentions in his ocmment on the JIRA it is possible to
control re-export of the JNI
On 2020-02-26 08:41, David Holmes wrote:
Hi Bob,
Adding build-dev.
Thanks for noticing that we were missing, David!
On 26/02/2020 6:37 am, Bob Vandette wrote:
Please review this RFE that alters the visibility of JNI entrypoints
to hidden when a shared library
is created using static JDK
On 26/02/2020 11:40, 向伟(识月) wrote:
Hi Florian,
This isn't a common usage.
For the below code:
String s1 = "s1".intern();
f.set("s1".intern(), f.get("s2"));
After calling reflection, the value of s1 is changed to "s2".
In some special scenarios, the original jar file can't be modified. But the
* 向伟(识月):
> Hi Florian,
>
> This isn't a common usage.
> For the below code:
>
> String s1 = "s1".intern();
> f.set("s1".intern(), f.get("s2"));
>
> After calling reflection, the value of s1 is changed to "s2".
> In some special scenarios, the original jar file can't be modified. But the
> user
* 向伟(识月):
> We create a simple case to reproduce the issue:
>
> import java.lang.reflect.Field;
> import java.lang.reflect.Modifier;
> public class StringTableTest {
> public static void main(String[] args) throws Exception {
> Field f = String.class.getDeclaredField("value");
>
Hello,
I've moved this fast-path into both
StringUTF16.newString/StringLatin1.newString.
Patch is attached.
Test-tier1 is OK, though I have a question about
StringLatin1/StringUTF16.stripLeading()
and StringLatin1/StringUTF16.stripTrailing():
Currently we have
public static String
* Bob Vandette:
> CSR:
>
> https://bugs.openjdk.java.net/browse/JDK-8239791
For ELF (at least in the GNU incarnation), a change to the installed
jni.h is not required to make the symbols hidden; a hidden definition
would be sufficient for that. The declaration may however allow the
compiler to
44 matches
Mail list logo
