Re: RFC: JEP JDK-8208089: Implement C++14 Language Features

> On Mar 3, 2020, at 4:49 PM, Alexey Semenyuk > wrote: > > How about C++11? I have a pending patch for jpackage that depends on C++11 > features that I hesitate to pull in jdk15. The reasons for HotSpot (at least) not already being on C++14 (cost of switching over the Solaris Studio based plat

Re: [15] RFR: 8239836: ZoneRules.of() doesn't check transitionList/standardOffsetTL arguments validity

I fear more changes are needed here. 1) The code is isFixedOffset() is indeed wrong, but the fix is insufficient. The zone is fixed if baseStandardOffset=baseWallOffset and all three other lists are empty. A fixed offset rule is the equivalent of a ZoneOffset. See ZoneId.normalized() for the code

Re: RFC: JEP JDK-8208089: Implement C++14 Language Features

How about C++11? I have a pending patch for jpackage that depends on C++11 features that I hesitate to pull in jdk15. - Alexey On 3/3/2020 5:22 AM, Volker Simonis wrote: On Tue, Mar 3, 2020 at 10:26 AM Andrew Haley wrote: On 3/2/20 10:46 PM, Volker Simonis wrote: As lead of the 8 and 11 up

Re: RFR(S): 8240333: jmod incorrectly updates .jar and .jmod files during hashing

On 03/03/2020 18:01, Volker Simonis wrote: : Thanks. Shortened the comments as suggested: http://cr.openjdk.java.net/~simonis/webrevs/2020/8240333.01/ OK, now? Thanks, looks good to me. -Alan

Re: [15] RFR: 8239836: ZoneRules.of() doesn't check transitionList/standardOffsetTL arguments validity

Looks good to me. Thanks, Joe On 3/3/20 10:15 AM, naoto.s...@oracle.com wrote: Thanks, Joe. Updated: http://cr.openjdk.java.net/~naoto/8239836/webrev.02/ Naoto On 3/3/20 8:59 AM, Joe Wang wrote: On 3/3/20 8:27 AM, naoto.s...@oracle.com wrote: Hi Joe, thanks for the review. Are you sugges

Re: [15] RFR: 8239836: ZoneRules.of() doesn't check transitionList/standardOffsetTL arguments validity

Thanks, Joe. Updated: http://cr.openjdk.java.net/~naoto/8239836/webrev.02/ Naoto On 3/3/20 8:59 AM, Joe Wang wrote: On 3/3/20 8:27 AM, naoto.s...@oracle.com wrote: Hi Joe, thanks for the review. Are you suggesting something like isFixedOffset() {     return isFixedOffset; } Yes, somethin

Re: RFR(S): 8240333: jmod incorrectly updates .jar and .jmod files during hashing

Looks good to me Thank you Volker > On Mar 3, 2020, at 1:03 PM, Volker Simonis wrote: > > Thanks Lance. > > I've just sent out an updated webrev with the shortened comments: > > http://cr.openjdk.java.net/~simonis/webrevs/2020/8240333.01/ >

Re: RFR(S): 8240333: jmod incorrectly updates .jar and .jmod files during hashing

Thanks Lance. I've just sent out an updated webrev with the shortened comments: http://cr.openjdk.java.net/~simonis/webrevs/2020/8240333.01/ On Tue, Mar 3, 2020 at 7:00 PM Lance Andersen wrote: > > I think this all looks OK. I would consider the same comment clean-up in > JmodTask.java as we

Re: RFR(S): 8240333: jmod incorrectly updates .jar and .jmod files during hashing

On Tue, Mar 3, 2020 at 5:27 PM Alan Bateman wrote: > > On 03/03/2020 11:01, Volker Simonis wrote: > > Hi, > > > > can I please get a review for the following small fix: > > > > http://cr.openjdk.java.net/~simonis/webrevs/2020/8240333/ > > https://bugs.openjdk.java.net/browse/JDK-8240333 > > > > >

Re: RFR(S): 8240333: jmod incorrectly updates .jar and .jmod files during hashing

On Tue, Mar 3, 2020 at 5:20 PM Martin Buchholz wrote: > > Looks Good To Me ... except you should fix that "delfated" typo. > Thanks. Corrected the typo along with some comment shortening suggested by Alan: http://cr.openjdk.java.net/~simonis/webrevs/2020/8240333.01/ > Those looking for a zip im

Re: RFR(S): 8240333: jmod incorrectly updates .jar and .jmod files during hashing

I think this all looks OK. I would consider the same comment clean-up in JmodTask.java as well Best Lance > On Mar 3, 2020, at 11:27 AM, Alan Bateman wrote: > > On 03/03/2020 11:01, Volker Simonis wrote: >> Hi, >> >> can I please get a review for the following small fix: >> >> http://cr.ope

Re: RFR: JDK-8237966,: Creating runtime pkg requires --mac-package-identifier

Looks fine to me. /Alex On 2/26/20 20:48, Andy Herrick wrote: Please review the fix to issue [1] at [2]. The initial concern with defaulting to the application or installer name was that is might not be a valid mac package identifier (use only alphanumeric, '.' , and '-' chars)  but this can

Re: RFR: JDK-8238692: MacOS runtime Installer issue

Last version looks fine to me. /Alex On 2/21/20 20:10, Andy Herrick wrote: After internal discussion of default values for mac-package-identifier I have removed the fix for [3] from this main fix to issue [2]. please review the revised webrev at [1] /Andy On 2/18/2020 2:46 PM, Andy Herrick

Re: [15] RFR: 8239836: ZoneRules.of() doesn't check transitionList/standardOffsetTL arguments validity

On 3/3/20 8:27 AM, naoto.s...@oracle.com wrote: Hi Joe, thanks for the review. Are you suggesting something like isFixedOffset() {     return isFixedOffset; } Yes, something like that. It could be initiated while the rules is constructed. I feel it might be semantically clearer as transiti

Re: [11u] RFR: 8232854: URLClassLoader.close() doesn't close cached JAR file on Windows when load() fails

On 02/03/2020 20:44, Alex Kashchenko wrote: Yes, I can work on this issue for jdk/jdk. I found this part of code complicated and would appreciate the guidance. JDK-8132359 is the main issue (yes, JDK-8232854 is a bit confusing). I think Michael is looking into whether it needs to touch or th

Re: [15] RFR: 8239836: ZoneRules.of() doesn't check transitionList/standardOffsetTL arguments validity

Hi Joe, thanks for the review. Are you suggesting something like isFixedOffset() { return isFixedOffset; } Naoto On 3/2/20 11:20 PM, Joe Wang wrote: Hi Naoto, The fix would be fine if you want to keep it as is since it does work. I noticed though that for standard zones (the ones loaded

Re: RFR(S): 8240333: jmod incorrectly updates .jar and .jmod files during hashing

On 03/03/2020 11:01, Volker Simonis wrote: Hi, can I please get a review for the following small fix: http://cr.openjdk.java.net/~simonis/webrevs/2020/8240333/ https://bugs.openjdk.java.net/browse/JDK-8240333 The code changes okay but I think the comment needs a bit of clean-up. Maybe drop L

Re: RFR(S): 8240333: jmod incorrectly updates .jar and .jmod files during hashing

Looks Good To Me ... except you should fix that "delfated" typo. Those looking for a zip implementation career path can try to fix up all the compressedSize in the local headers so that they are correctly filled in. Which is hard because you don't know the compressedSize when you are writing the

Re: RFR(s): 8240235: jdk.test.lib.util.JarUtils updates jar files incorrectly

For the truly desperate in search of a spam folder, recent emails from google.com can be viewed here: https://openjdk.markmail.org/search/?q=from%3Agoogle.com%20date%3A2020- On Mon, Mar 2, 2020 at 11:15 PM Langer, Christoph wrote: > Hi Volker, > > sure, looks good. Unfortunately I don't get the

Re: RFR: 8239365: ProcessBuilder/Basic.java test modifications for AIX execution

Hi Adam, It doesn't look like you saw my comments from 2/21. Please take another look. http://mail.openjdk.java.net/pipermail/core-libs-dev/2020-February/064878.html Roger On 3/3/20 5:43 AM, Adam Farley8 wrote: Hi All, Reviews and sponsor requested for a small test change. Short version: W

RFR(S): 8240333: jmod incorrectly updates .jar and .jmod files during hashing

Hi, can I please get a review for the following small fix: http://cr.openjdk.java.net/~simonis/webrevs/2020/8240333/ https://bugs.openjdk.java.net/browse/JDK-8240333 The "jmod" tool needs to update .jar files as well as .jmod files when adding hashes to the module-info file. This is handled in t

RFR 8129841 Update comment for Java_java_net_Inet6AddressImpl_getHostByAddr

Hi All, Please find the below changes for the issue https://bugs.openjdk.java.net/browse/JDK-8129841. Apart from the requested changes, I have made additional changes to the Signature where ever I found it incorrect. Thanks Vipin M V diff -r 387369ff21a4 src/java.base/unix/native/libnet/In

Re: RFR: 8239365: ProcessBuilder/Basic.java test modifications for AIX execution

This is why I always was against handing up the result of strerror to the user :) The same problem we would have when running with different locales. We should have a platform agnostic string table in the java lib for that purpose... As for the test, looks good, but I personally would shorten the

RFR: 8239365: ProcessBuilder/Basic.java test modifications for AIX execution

Hi All, Reviews and sponsor requested for a small test change. Short version: When an AIX machine has the file set "bos.msg.en_US.rte", the error messages are not in a form that the test expects, causing failure. The simplest option appears to be adding the second potential form of the messag

Re: RFC: JEP JDK-8208089: Implement C++14 Language Features

On Tue, Mar 3, 2020 at 10:26 AM Andrew Haley wrote: > > On 3/2/20 10:46 PM, Volker Simonis wrote: > > > As lead of the 8 and 11 update projects you probably know best, if this fix > > will eventually be considered for backporting and choose your means wisely > > :) > > Yeah, I know. Srsly. :-) > >

Re: RFC: JEP JDK-8208089: Implement C++14 Language Features

On 3/2/20 10:46 PM, Volker Simonis wrote: > As lead of the 8 and 11 update projects you probably know best, if this fix > will eventually be considered for backporting and choose your means wisely > :) Yeah, I know. Srsly. :-) But one of the few things of which I am certain is that we must not a

Re: RFC: JEP JDK-8208089: Implement C++14 Language Features

On 3/2/20 9:51 PM, Kim Barrett wrote: >> On Mar 2, 2020, at 7:00 AM, Andrew Haley wrote: >> >> On 11/19/18 8:39 PM, Kim Barrett wrote: >>> I don't see any benefit to making the first C++ code change that uses >>> a new feature also incorporate the needed build system changes. >>> Indeed, how does

RE: RFR(s): 8240235: jdk.test.lib.util.JarUtils updates jar files incorrectly

> On 03/03/20 12:45 pm, Langer, Christoph wrote: > > Unfortunately I don't get the mails from Martin ☹ > > Same for me. They always end up in spam folder which I usually check > once a month. I see that there's already > https://bugs.openjdk.java.net/browse/JDK-8213225 which seems to be the > same

Re: RFR(s): 8240235: jdk.test.lib.util.JarUtils updates jar files incorrectly

On 03/03/20 12:45 pm, Langer, Christoph wrote: > Unfortunately I don't get the mails from Martin ☹ Same for me. They always end up in spam folder which I usually check once a month. I see that there's already https://bugs.openjdk.java.net/browse/JDK-8213225 which seems to be the same issue. -Ja