Re: RFR: 8242283: Can't start JVM when java home path includes non-ASCII character

2020-04-10 Thread Yasumasa Suenaga
Thanks Sato-san! I added noreg-hard to JBS. Can I get reviewer(s) from HotSpot folks? This webrev changes HotSpot code (os_windows.cpp). Yasumasa On 2020/04/11 2:17, naoto.s...@oracle.com wrote: Suenaga-san, Looks good to me. Please add noreg-hard if you are not planning to provide test

Re: os::javaTimeSystemUTC to call nanosecond precision OS API, so Clock.systemUTC() can give nanosecond precision UTC

2020-04-10 Thread David Holmes
Update: On 11/04/2020 9:45 am, David Holmes wrote: Hi Mark, Thanks for the very detailed proposal and write up! It's a holiday weekend so I can't dig into this right now but we tried using a high-precision clock source for systemUTC() in the past but it didn't work because systemUTC() and

Re: os::javaTimeSystemUTC to call nanosecond precision OS API, so Clock.systemUTC() can give nanosecond precision UTC

2020-04-10 Thread David Holmes
Hi Mark, Thanks for the very detailed proposal and write up! It's a holiday weekend so I can't dig into this right now but we tried using a high-precision clock source for systemUTC() in the past but it didn't work because systemUTC() and currentTimeMillis() have to use the same time base,

Re: JarFile.getVersionedEntry scalability with new release cadence

2020-04-10 Thread Lance Andersen
Hi Eric Feel free to enter a feature request and better yet propose a fix :-) Have a good weekend! Best Lance > On Apr 10, 2020, at 2:59 PM, Eirik Bjørsnøs wrote: > > I recently needed to re-implement multi-release lookup logic for a > ModuleReader capable of reading modules from unpacked

Re: RFR 15 8242462: Residual Cleanup of rmic removal

2020-04-10 Thread mikhailo . seledtsov
Runtime test changes look good to me, Misha On 4/10/20 11:44 AM, Igor Ignatyev wrote: Hi Roger, removal of applications/ctw/modules/jdk_rmic.java and changes in doc (assuming .html was generated from .md) look good to me. adding hotspot-runtime alias to bring attention of runtime team. I'm

JarFile.getVersionedEntry scalability with new release cadence

2020-04-10 Thread Eirik Bjørsnøs
I recently needed to re-implement multi-release lookup logic for a ModuleReader capable of reading modules from unpacked (exploded) jar files [1] It occurred to me that JarFile.getVersionedEntry checks _every_ version between 8 and the runtime version when looking up paths. Since

Re: RFR 15 8242462: Residual Cleanup of rmic removal

2020-04-10 Thread Erik Joelsson
unshuffle_list.txt looks good to me. /Erik On 2020-04-10 11:44, Igor Ignatyev wrote: Hi Roger, removal of applications/ctw/modules/jdk_rmic.java and changes in doc (assuming .html was generated from .md) look good to me. adding hotspot-runtime alias to bring attention of runtime team. I'm

Re: RFR 15 8242462: Residual Cleanup of rmic removal

2020-04-10 Thread Igor Ignatyev
Hi Roger, removal of applications/ctw/modules/jdk_rmic.java and changes in doc (assuming .html was generated from .md) look good to me. adding hotspot-runtime alias to bring attention of runtime team. I'm not sure who are the right people to review bin/unshuffle_list.txt though,.. build team

Re: os::javaTimeSystemUTC to call nanosecond precision OS API, so Clock.systemUTC() can give nanosecond precision UTC

2020-04-10 Thread Roger Riggs
Hi, Created an entry to track the enhancement:     https://bugs.openjdk.java.net/browse/JDK-8242504 Changes affecting the Core Libraries APIs also need be reviewed by core-libs-dev. Regards, Roger On 4/10/20 1:03 PM, Mark Kralj-Taylor wrote: I'd like to help Java Clock.systemUTC() expose

Re: RFR: 8242283: Can't start JVM when java home path includes non-ASCII character

2020-04-10 Thread naoto . sato
Suenaga-san, Looks good to me. Please add noreg-hard if you are not planning to provide test cases. Thank you for fixing this issue. Naoto On 4/10/20 7:29 AM, Yasumasa Suenaga wrote: Hi all, Please review this change:   JBS: https://bugs.openjdk.java.net/browse/JDK-8242283   webrev:

RFR: 8242283: Can't start JVM when java home path includes non-ASCII character

2020-04-10 Thread Yasumasa Suenaga
Hi all, Please review this change: JBS: https://bugs.openjdk.java.net/browse/JDK-8242283 webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8242283/webrev.00/ After JDK-8240197 and JDK-8240725, java cannot start when java home path includes non-ASCII character e.g. Japanese Kanji. We've

Re: RFR 15 8242327: List spec should state that unmodifiable lists implement RandomAccess

2020-04-10 Thread Lance Andersen
Hi Stuart Looks good and I reviewed the CSR this morning also Best Lance > On Apr 9, 2020, at 10:52 PM, Stuart Marks wrote: > > Thanks Lance. > > Upon advice from Pavel Rappo, I've adjusted the link markup to use the full > reference form of a javadoc link. Revised patch below. Also, could