RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports - (core libraries)

2020-05-03 Thread Mikael Vidstedt
Please review this change which implements part of JEP 381: JBS: https://bugs.openjdk.java.net/browse/JDK-8244224 webrev: http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.00/corelibs/open/webrev/ JEP: https://bugs.openjdk.java.net/browse/JDK-8241787 Note: When reviewing this, please

8244293 : Remove outdated @apiNote in java.util.Objects

2020-05-03 Thread Anirvan Sarkar
Hi, The class level @apiNote in java.util.Objects refers to variation of static methods checkIndex(int, int), checkFromToIndex(int, int, int), and checkFromIndexSize(int, int, int), which support customization of the runtime exception, and corresponding exception detail message. But these static

Fix for warning related to stream api call chains in java.base

2020-05-03 Thread Vipin Sharma
Hi All, I have fixed some warnings in java.base module, following are 3 type of code changes in this patch: ! stream().filter(...).findFirst().isPresent() replaced with stream().noneMatch(...)) stream.filter(...).findFirst().isPresent() replaced with stream.anyMatch(...) stream.collect(Collecto

Re: RFR [15] 6394757: rev2: AbstractSet.removeAll semantics are surprisingly dependent on relative sizes

2020-05-03 Thread Jens Lideström
I will chip in once more on this topic. (I did so once before [1], perhaps in a much too wordy manner.) The proposed changes in AbstractSet.removeAll will be inherited by TreeSet. A TreeSet might use a comparator as a custom equality test. Because of this it seems backwards if TreeSet.removeAll w

RFR: JDK-8244288 Specialized implementations for putIfAbsent, merge, compute* methods in TreeMap derived maps

2020-05-03 Thread Tagir Valeev
Hello! Please review the following change: https://bugs.openjdk.java.net/browse/JDK-8244288 http://cr.openjdk.java.net/~tvaleev/webrev/8244288/r1/ We already implemented putIfAbsent, merge, computeIfAbsent, computeIfPresent, and compute for TreeMap class (see JDK-8176894). However, default implem

Re: RFR 8243491: Implementation of Foreign-Memory Access API (Second Incubator)

2020-05-03 Thread Peter Levart
On 5/1/20 4:36 PM, Maurizio Cimadamore wrote: Now there's dup(). I think implementing dup() on a root scope is not too hard - for the child you probably need some trick, but probably not too bad - in the sense that in a Child scope, the cleanup action is really the increment of the root exi