Re: [8u] RFR(S): 8244548: JDK 8u: sun.misc.Version.jdkUpdateVersion() returns wrong result

2020-05-17 Thread Andrew Hughes
On 15/05/2020 14:29, Andrew Haley wrote: > On 5/15/20 9:45 AM, Severin Gehwolf wrote: >> So, Andrew Haley, what's the verdict on this one? There is a risk, yes. >> Not fixing the bug seems riskier, though. Thoughts? > > Thanks for the detailed explanation. > > I think we have to keep sun.misc.

Re: RFR: JDK-8243454 - Redundant code for executable jar file manifests except SplashScreen-Image

2020-05-17 Thread Lance Andersen
; with a test and there is some potential for cleaning up unused code >> which certainly is not urgent at all and I would not know how >> desirable this really is. Also I'm not sure whether it's better or >> not to add SPLASHSCREEN_IMAGE to Attributes.Name.KNOWN_NAMES. >&g

RFR: JDK-8243454 - Redundant code for executable jar file manifests except SplashScreen-Image

2020-05-17 Thread Philipp Kunz
Hi, Essentially the same patch as last time [1] but this time with a bug number [2].The patch does not include the updated UnicodeTest.jar which I created with ../jtreg-5.0-b01/bin/jtreg -va -nr -jdk:build/linux-x86_64-server- release/images/jdk/ -Xshare:off test/jdk/tools/launcher/UnicodeTest.java