Hi Mikael,
Cleanup looks good to me.
Bikeshed: TimeGetNowMicros -> GetTimeMicros or CurrentTimeMicros ?
Thanks,
David
On 22/05/2020 1:28 pm, Mikael Vidstedt wrote:
Please review this change which cleans up the libjli related files a bit:
JBS:
Please review this change which cleans up the libjli related files a bit:
JBS: https://bugs.openjdk.java.net/browse/JDK-8245600
webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8245600/webrev.00/open/webrev/
Background:
During the review of JDK-8244224 it was noticed that the
Looks good.
- Alexey
On 5/21/2020 2:55 PM, Andy Herrick wrote:
looks good.
/Andy
On 5/21/2020 4:16 AM, alexander.matv...@oracle.com wrote:
Please review the jpackage fix for bug [1] at [2].
- Added support for unpacking pkg.
[1] https://bugs.openjdk.java.net/browse/JDK-8237908
[2]
https://openjdk.java.net/jeps/385
- Mark
Hi Naoto,
On 21/05/2020 20:00, naoto.s...@oracle.com wrote:
In fact, this piece of code should not happen as those adapter classes
are all JDK provided classes. I replaced the above code with
ServiceConfigurationError, like other similar locations (e.g,
HostLocaleProviderAdapter - line
Hi Daniel,
Thank you for your review!
On 5/21/20 3:42 AM, Daniel Fuchs wrote:
Hi Naoto,
Logging uses:
ZonedDateTime zdt = ZonedDateTime.ofInstant(
record.getInstant(), ZoneId.systemDefault());
and then
String.format("%1$tb %1$td, %1$tY %1$tl:%1$tM:%1$tS %1$Tp %2$s%n%4$s:
looks good.
/Andy
On 5/21/2020 4:16 AM, alexander.matv...@oracle.com wrote:
Please review the jpackage fix for bug [1] at [2].
- Added support for unpacking pkg.
[1] https://bugs.openjdk.java.net/browse/JDK-8237908
[2] http://cr.openjdk.java.net/~almatvee/8237908/webrev.00/
Thanks,
Hi Mandy,
Thanks for the suggestions. They have been incorporated in the revised
webrev.
http://cr.openjdk.java.net/~hseigel/webrev.01/webrev/
Harold
On 5/20/2020 1:05 PM, Mandy Chung wrote:
Hi Vicente,
On 5/20/20 8:40 AM, Vicente Romero wrote:
Hi David,
Hi David,
Thanks for looking at this! Please review this new webrev:
http://cr.openjdk.java.net/~hseigel/webrev.01/webrev/
This webrev contains the following significant changes:
1. The format/indentation issues in classFileParser.cpp were fixed.
2. Unneeded checks in
Hi Vicente,
looks very good. Some comments below.
* the parser logic is clever in its use of position to apply
context-dependent keyword detection; as Jan says, perhaps just share the
code so that the position checks are not repeated.
* I found one very edge-case quirk in the
On 2020-05-21 12:35, Alan Bateman wrote:
On 20/05/2020 16:21, Claes Redestad wrote:
Ok - I'll also update and resubmit the CSR with the edits and additions
that came up during review here.
For the test then you could expand it to test the views of heap and
direct buffers (asCharBuffer).
Hi Naoto,
Logging uses:
ZonedDateTime zdt = ZonedDateTime.ofInstant(
record.getInstant(), ZoneId.systemDefault());
and then
String.format("%1$tb %1$td, %1$tY %1$tl:%1$tM:%1$tS %1$Tp %2$s%n%4$s:
%5$s%6$s%n", ...)
to format the date.
If the locale provider can't be loaded,
On 20/05/2020 16:21, Claes Redestad wrote:
Ok - I'll also update and resubmit the CSR with the edits and additions
that came up during review here.
For the test then you could expand it to test the views of heap and
direct buffers (asCharBuffer).
How about this:
Please review the jpackage fix for bug [1] at [2].
- Added support for unpacking pkg.
[1] https://bugs.openjdk.java.net/browse/JDK-8237908
[2] http://cr.openjdk.java.net/~almatvee/8237908/webrev.00/
Thanks,
Alexander
Hello,
Could you please review the following patch:
JBS: https://bugs.openjdk.java.net/browse/JDK-8245527
Webrev: http://cr.openjdk.java.net/~abakhtin/8245527/webrev.v0/
The Windows LDAP server with LdapEnforceChannelBinding=2 uses the
tls-server-end-point channel binding
(based on the TLS
15 matches
Mail list logo
