Re: RFR: 8245527: LDAP Cnannel Binding support for Java GSS/Kerberos

2020-06-06 Thread Weijun Wang
Some comments: 1. I just noticed your 2 new files are using the plain GPU license, it should be GPL + Classpath. Read another source file for an example. 2. Please add some comments in InitialToken.java on what happens to the default type. 3. I still think "com.sun.security.sasl.tlschannelbind

Re: RFR: 8245527: LDAP Cnannel Binding support for Java GSS/Kerberos

2020-06-06 Thread Alexey Bakhtin
Hello Max, Daniel, Thank you for review. Please review new version of the patch : http://cr.openjdk.java.net/~abakhtin/8245527/webrev.v5/ In this version: - TlsChannelBinding class is moved into the com.sun.jndi.ldap.sasl package - SSL Ceritificate related code is moved from LdapClient into the

Re: 8202469 / 8202473: Correct type annotation resolution for class type variables

2020-06-06 Thread Joel Borggrén-Franck
Hi Rafael, Let's try to get this into 15, http://cr.openjdk.java.net/~winterhalter/8202473/webrev.00/test/jdk/java/lang/annotation/typeAnnotations/TypeVariableBoundParameterIndex.java.udiff.html looks strange did you unintentionally remove the test for 8202469? The issues are orthogonal so I'd li

Re: RFR: 8246032: Implementation of JEP 347: Adopt C++14 Language Features in HotSpot

2020-06-06 Thread James Laskey
I fully understand. I’ll set up a separate bug. Cheers, — Jim 📱 > On Jun 5, 2020, at 8:57 PM, Magnus Ihse Bursie > wrote: > > On 2020-06-05 13:59, Jim Laskey wrote: >> I know there was a discussion about this elsewhere but I would like to take >> the opportunity to correct this now >> >>