Re: RFR: 8248059: [macos] EmptyFolderPackageTest.java failed "hdiutil: create failed - No child processes"

2020-06-29 Thread Alexey Semenyuk
Looks good. - Alexey On 6/29/2020 5:37 PM, alexander.matv...@oracle.com wrote: Hi Alexey, No, it is not used. I forgot to remove it. Patch updated: http://cr.openjdk.java.net/~almatvee/8248059/webrev.02/ Thanks, Alexander On 6/29/20 7:47 AM, Alexey Semenyuk wrote: Alexander, Is `error.cann

Re: RFR: 8248059: [macos] EmptyFolderPackageTest.java failed "hdiutil: create failed - No child processes"

2020-06-29 Thread alexander . matveev
Hi Alexey, No, it is not used. I forgot to remove it. Patch updated: http://cr.openjdk.java.net/~almatvee/8248059/webrev.02/ Thanks, Alexander On 6/29/20 7:47 AM, Alexey Semenyuk wrote: Alexander, Is `error.cannot-calculate-folder-size` l10n property still used in the new patch? - Alexey

Re: Contributing to JEP 356: Enhanced Pseudo-Random Number Generators ?

2020-06-29 Thread Raffaello Giulietti
Hello, does anybody know what the progress of this JEP is? How could I contribute? Greetings Raffaello On 2020-06-24 19:22, Raffaello Giulietti wrote: Hi, seems like the last activity in JBS related to this JEP [1, 2] dates back to June 2019. Are there major stumbling blocks? Can I contr

Re: contributing to JDK-8222187: java.util.Base64.Decoder stream adds unexpected null bytes at the end

2020-06-29 Thread Raffaello Giulietti
Hello, here's a fix and an additional test, both in inline form and as an attachment. The fix also contains a reimplementation of encodedOutLength() that makes use of long arithmetic rather than relying on addExact(), multiplyExact(), etc. Further, lookup tables have been declared as byte[

Re: [aarch64-port-dev ] RFR (XXL): 8223347: Integration of Vector API (Incubator): AArch64 backend changes

2020-06-29 Thread Andrew Haley
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On 29/06/2020 08:48, Yang Zhang wrote: > 1. Instruct

RFR(s): 8247863: Unreachable code in OperatingSystemImpl.getTotalSwapSpaceSize()

2020-06-29 Thread Severin Gehwolf
Hi, Could I please get a review of this dead-code removal? During review of JDK-8244500 it was discovered that with the new cgroups implementation supporting v1 and v2 Metrics.getMemoryAndSwapLimit() will never return 0 when relevant cgroup files are missing. E.g. on a system where the kernel does

Re: RFR: 8248059: [macos] EmptyFolderPackageTest.java failed "hdiutil: create failed - No child processes"

2020-06-29 Thread Alexey Semenyuk
Alexander, Is `error.cannot-calculate-folder-size` l10n property still used in the new patch? - Alexey On 6/27/2020 12:00 AM, alexander.matv...@oracle.com wrote: Hi Alexey, http://cr.openjdk.java.net/~almatvee/8248059/webrev.01/ - Removed getFilesSizeInFolder() method and size will be calcu

RE: Explicitly constructed NPE is showing (wrong) message

2020-06-29 Thread Lindenmaier, Goetz
Hi, Thanks for reporting this issue. You analyzed it well, and the simple repro case was also helpful. I filed https://bugs.openjdk.java.net/browse/JDK-8248476 and will send RFR for this in a minute. It's probably best to continue discussion there. Best regards, Goetz. > -Original Mess

RE: [aarch64-port-dev ] RFR (XXL): 8223347: Integration of Vector API (Incubator): AArch64 backend changes

2020-06-29 Thread Yang Zhang
Hi Andrew, 1. Instructions that can be matched with NEON instructions directly. MulVB, SqrtVF and AbsV have been merged into jdk master already. 2. Instructions that jdk master has middle end support for, but they cannot be matched with NEON instructions directly. Such as AddReductionVL, MulRedu