Re: RFR[15/java.xml] Re: RFR [16/java.xml] 8248486: SafeThread illegal access to java.lang private fields should be removed

2020-07-12 Thread Alan Bateman
On 12/07/2020 23:21, Joe Wang wrote: Hi all, Alan updated the bug to indicate it fails since JDK 9. Given we still have a couple days for JDK 15, I've rebased the patch to the jdk15 repo and would like to check in the patch into JDK 15 instead (and let it be sync-ed to 16). Here's the webrev

RFR[15/java.xml] Re: RFR [16/java.xml] 8248486: SafeThread illegal access to java.lang private fields should be removed

2020-07-12 Thread Joe Wang
Hi all, Alan updated the bug to indicate it fails since JDK 9. Given we still have a couple days for JDK 15, I've rebased the patch to the jdk15 repo and would like to check in the patch into JDK 15 instead (and let it be sync-ed to 16). Here's the webrev for JDK 15: http://cr.openjdk.java.n

Re: RFR(S): 8249198: Faster Math.signum(fp) for positive and negative numbers

2020-07-12 Thread Dmitry Chuyko
Hello, After much more thorough analysis of benchmarks on different platforms I tend to cancel this patch proposal. As Brian rightly remarked [3], the benchmark has peculiar explicit iteration over the data. This is more like 2nd anti-pattern in safe looping JMH sample [4]. This actually cam