Hello,
Please review the patch below and CSR for
JDK-8249273: Documentation of BigInteger(String) constructor does
not mention leading plus
CSR: https://bugs.openjdk.java.net/browse/JDK-8251235
The fix for JDK-5017980 way back in JDK 7 omitted the spec update to one
of the two BigInt
Pushed with https://hg.openjdk.java.net/jdk/jdk/rev/b8231f177eaf
Thank you to all involved 😊
Hi Andy,
Looks good.
Thanks,
Alexander
On 8/5/20 1:17 PM, Andy Herrick wrote:
Please review this jpackage fix at [1] to issue [2]
[1] - http://cr.openjdk.java.net/~herrick/8251184/
[2] - https://bugs.openjdk.java.net/browse/JDK-8251184
/Andy
Hi Joe,
For the consistency with equals(), just wondering if the sub-second
element should be obtained with getFractionalSecond() instead of
getMillisecond(), as the equals() subsequently calls it in
internalCompare() method. Also should it call getEonAndYear()
appropriately for the year?
N
Hello,
Please review a fix for the hashCode generation.
JBS: https://bugs.openjdk.java.net/browse/JDK-8246816
webrev: http://cr.openjdk.java.net/~joehw/jdk16/8246816/webrev/
Thanks,
Joe
On 6/08/2020 7:37 am, Joe Darcy wrote:
Hello,
Addressing some feedback from off-list discussions with Mandy, I propose
changing the API notes to:
@apiNote While to date a wildcard may have at most one upper[lower]
bound, callers of this method should be written to accommodate multiple
This looks good. This will prepare for the future when Java supports
multiple bounds.
Mandy
On 8/5/20 2:37 PM, Joe Darcy wrote:
Hello,
Addressing some feedback from off-list discussions with Mandy, I
propose changing the API notes to:
@apiNote While to date a wildcard may have at most
Hello,
Addressing some feedback from off-list discussions with Mandy, I propose
changing the API notes to:
@apiNote While to date a wildcard may have at most one upper[lower]
bound, callers of this method should be written to accommodate multiple
bounds.
Thanks,
-Joe
On 8/3/2020 9:24
Please review this jpackage fix at [1] to issue [2]
[1] - http://cr.openjdk.java.net/~herrick/8251184/
[2] - https://bugs.openjdk.java.net/browse/JDK-8251184
/Andy
To fix [1], please consider the patch [2]. This follows on from the proposed
change [3] which in turn follows from [4].
Thanks,
Brian
[1] https://bugs.openjdk.java.net/browse/JDK-8181919
[2] http://cr.openjdk.java.net/~bpb/8181919/webrev.00/
[3]
https://mail.openjdk.java.net/pipermail/core-lib
Looks good
-Sundar
On 05/08/20 10:56 pm, Mandy Chung wrote:
Trivial update on license header.
diff --git
a/src/java.base/share/classes/java/lang/invoke/LambdaProxyClassArchive.java
b/src/java.base/share/classes/java/lang/invoke/LambdaProxyClassArchive.java
---
a/src/java.base/share/classe
Trivial update on license header.
diff --git
a/src/java.base/share/classes/java/lang/invoke/LambdaProxyClassArchive.java
b/src/java.base/share/classes/java/lang/invoke/LambdaProxyClassArchive.java
---
a/src/java.base/share/classes/java/lang/invoke/LambdaProxyClassArchive.java
+++
b/src/java.b
Also, instead of using the boolean “caughtException,” we usually just put,
e.g., the throwing of the RuntimeException on the line after where the IIOBE or
whatever would be thrown. I don’t think the “finally” block is necessary.
Thanks,
Brian
> On Aug 5, 2020, at 9:20 AM, Brian Burkhalter
>
HI Raffaello,
The implementation test looks right. In the test, you might consider using
try-with-resources.
Thanks,
Brian
> On Jul 29, 2020, at 10:44 AM, Raffaello Giulietti
> wrote:
>
> +FileInputStream in = new FileInputStream(file);
> +DataInputStream dis = new DataInput
Hi,
a gentle reminder to review this almost trivial patch.
Greetings
Raffaello
On 2020-07-29 19:44, Raffaello Giulietti wrote:
Hi Tagir,
here's yesterday's patch with added unit tests.
Greetings
Raffaello
On 2020-07-29 05:26, Tagir Valeev wrote:
Hello!
Having a unit-test would be ni
15 matches
Mail list logo
