Re: RFR: 8253153: Mentioning of "hour-of-minute" in java.time.temporal.TemporalField JavaDoc

2020-09-17 Thread Joe Wang
On Fri, 18 Sep 2020 01:49:09 GMT, Naoto Sato wrote: > Hi, > > Please review this simple doc fix. Marked as reviewed by joehw (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/234

Re: RFR: 8252999: Cleanup: replace .equals("") with .isEmpty() within all codebase

2020-09-17 Thread Stuart Marks
On Fri, 11 Sep 2020 15:17:58 GMT, Bradford Wetmore wrote: >> Ok, sorry for the distraction. > > Our local Santuario maintainer says: > > In general, changes to Apache Santuario should also be made at Apache so we > stay in sync. Hi @doom369, I hope we didn't end up wasting too much of your tim

RFR: 8253153: Mentioning of "hour-of-minute" in java.time.temporal.TemporalField JavaDoc

2020-09-17 Thread Naoto Sato
Hi, Please review this simple doc fix. - Commit messages: - 8253153: Mentioning of "hour-of-minute" in java.time.temporal.TemporalField JavaDoc Changes: https://git.openjdk.java.net/jdk/pull/234/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=234&range=00 Issue: htt

RFR: 8251548 Remove unnecessary explicit initialization of volatile variables in security-libs code

2020-09-17 Thread Сергей Цыпанов
Hello, is it possible to have a code review for the changes proposed in JDK-8251548 (originally contributed via https://mail.openjdk.java.net/pipermail/security-dev/2020-June/022137.html)? Sean Mullan has created an issue and web-review and can sponsor the patch as soos as it gets properly revi

Re: RFR: 8252730: jlink does not create reproducible builds on different servers [v8]

2020-09-17 Thread Ian Graves
> Related to [JDK-8252730 jlink does not create reproducible builds on different > servers](https://bugs.openjdk.java.net/browse/JDK-8252730). Introduces > ordering based on `Archive` module names to > ensure stable files (and file signatures) across generated JDK images by > jlink. Ian Graves h

Re: RFR: 8252730: jlink does not create reproducible builds on different servers [v7]

2020-09-17 Thread Ian Graves
> Related to [JDK-8252730 jlink does not create reproducible builds on different > servers](https://bugs.openjdk.java.net/browse/JDK-8252730). Introduces > ordering based on `Archive` module names to > ensure stable files (and file signatures) across generated JDK images by > jlink. Ian Graves h

Re: RFR: 8173585: Intrinsify StringLatin1.indexOf(char)

2020-09-17 Thread Jason Tatton
On Fri, 11 Sep 2020 23:04:01 GMT, Jason Tatton wrote: >> This is an implementation of the indexOf(char) intrinsic for StringLatin1 (1 >> byte encoded Strings). It is provided for >> x86 and ARM64. The implementation is greatly inspired by the indexOf(char) >> intrinsic for StringUTF16. To inco

Re: RFR: JDK-8230652: Improve verbose output

2020-09-17 Thread Alexander Zuev
On Sat, 12 Sep 2020 18:30:08 GMT, Andy Herrick wrote: > JDK-8230652 > Extracting the commands displayed by verbose output (including commands > called thru ToolProvider) , to contain the the > command, it's output, and it's return value on separate lines and formatted > in a way that they can b

Re: RFR: 8252204: AArch64: Implement SHA3 accelerator/intrinsic

2020-09-17 Thread Ard Biesheuvel
On Thu, 17 Sep 2020 05:18:28 GMT, Fei Yang wrote: >> Contributed-by: ard.biesheu...@linaro.org, dong...@huawei.com >> >> This added an intrinsic for SHA3 using aarch64 v8.2 SHA3 Crypto Extensions. >> Reference implementation for core SHA-3 transform using ARMv8.2 Crypto >> Extensions: >> https:

Integrated: 8253285: Some java/util/StringJoiner tests do not explicitly specify required -XX:+CompactStrings

2020-09-17 Thread Andrew Leonard
On Thu, 17 Sep 2020 11:30:40 GMT, Andrew Leonard wrote: > Signed-off-by: Andrew Leonard This pull request has now been integrated. Changeset: 24765e45 Author:Andrew Leonard Committer: Roger Riggs URL: https://git.openjdk.java.net/jdk/commit/24765e45 Stats: 3 lines in 2 files ch

Re: RFR: 8253285: Some java/util/StringJoiner tests do not explicitly specify required -XX:+CompactStrings

2020-09-17 Thread Jim Laskey
On Thu, 17 Sep 2020 11:30:40 GMT, Andrew Leonard wrote: > Signed-off-by: Andrew Leonard Marked as reviewed by jlaskey (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/223

Re: RFR: 8253285: Some java/util/StringJoiner tests do not explicitly specify required -XX:+CompactStrings

2020-09-17 Thread Andrew Leonard
On Thu, 17 Sep 2020 13:09:09 GMT, Roger Riggs wrote: >> Signed-off-by: Andrew Leonard > > Marked as reviewed by rriggs (Reviewer). @RogerRiggs thanks Roger, please can you Sponsor this PR ? thanks - PR: https://git.openjdk.java.net/jdk/pull/223

RE: RFR: 8253285: Some java/util/StringJoiner tests do not explicitly specify required -XX:+CompactStrings

2020-09-17 Thread Andrew Leonard
> You don't need to ask for RFRs yourself. Bots do that for you, and post on your behalf Yeah, I saw that just after I posted mine, that's cool :-) Andrew Leonard Java Runtimes Development IBM Hursley IBM United Kingdom Ltd internet email: andrew_m_leon...@uk.ibm.com From: Aleksey Shipilev

Integrated: 8251397: NPE on ClassValue.ClassValueMap.cacheArray

2020-09-17 Thread Galder Zamarreño
On Wed, 9 Sep 2020 12:35:06 GMT, Galder Zamarreño wrote: > * Release fence guarantees that cacheArray field will published with a > non-null value. > * Without this fix, CacheValueMap.cacheArray can sometimes be seen as null. > > This is a follow up to @PaulSandoz's feedback > [here](https://m

Re: RFR: 8253285: Some java/util/StringJoiner tests do not explicitly specify required -XX:+CompactStrings

2020-09-17 Thread Roger Riggs
On Thu, 17 Sep 2020 11:30:40 GMT, Andrew Leonard wrote: > Signed-off-by: Andrew Leonard Marked as reviewed by rriggs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/223

Re: RFR: 8253285: Some java/util/StringJoiner tests do not explicitly specify required -XX:+CompactStrings

2020-09-17 Thread Aleksey Shipilev
On 9/17/20 2:57 PM, Andrew Leonard wrote: Hi, Please can I request a review of this test fix to explicitly specify -XX:+CompactStrings which is required for the tests in question, specifically for VMs (openj9) that do not default to +CompactStrings, see: PR https://github.com/openjdk/jdk/pull

RFR: 8253285: Some java/util/StringJoiner tests do not explicitly specify required -XX:+CompactStrings

2020-09-17 Thread Andrew Leonard
Hi, Please can I request a review of this test fix to explicitly specify -XX:+CompactStrings which is required for the tests in question, specifically for VMs (openj9) that do not default to +CompactStrings, see: PR https://github.com/openjdk/jdk/pull/223 bug https://bugs.openjdk.java.net/br

RFR: 8253285: Some java/util/StringJoiner tests do not explicitly specify required -XX:+CompactStrings

2020-09-17 Thread Andrew Leonard
Signed-off-by: Andrew Leonard - Commit messages: - 8253285: Some java/util/StringJoiner tests do not explicitly specify required -XX:+CompactStrings Changes: https://git.openjdk.java.net/jdk/pull/223/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=223&range=00 Issue

Re: Request for review of JDK-8251548

2020-09-17 Thread David Holmes
On 17/09/2020 7:24 pm, Сергей Цыпанов wrote: Hi David, thanks for pointing this out! I've created a PR there [1], but GitHub for some reason wants me to sign OCA, which I have already signed in 2017. I've redone the procedure and now I'm waiting for verification. Did you not follow these ins

Re: RFR: 8250859: Address reliance on default constructors in the Accessibility APIs [v2]

2020-09-17 Thread Conor Cleary
On Wed, 16 Sep 2020 08:52:35 GMT, Chris Hegarty wrote: > The CSR lists `com.sun.java.accessibility.util.SwingEventMonitor` as being > changed, but I cannot find that class in > this PR. Changes to this class were indeed missing. This has now been addressed. Thanks for spotting that! -

Re: RFR: 8250859: Address reliance on default constructors in the Accessibility APIs [v2]

2020-09-17 Thread Conor Cleary
> This issue relates to JDK-8250639 '☂ Address reliance on default constructors > in the java.desktop module'. The > following classes have had an explicit no-arg constructor added, with a > protected access modifier and accompanying API > description: > - Default ctor on com.sun.java.accessibil

Re: Request for review of JDK-8251548

2020-09-17 Thread Сергей Цыпанов
Hi David, thanks for pointing this out! I've created a PR there [1], but GitHub for some reason wants me to sign OCA, which I have already signed in 2017. I've redone the procedure and now I'm waiting for verification. Regards, Sergey 1. https://github.com/openjdk/jdk/pull/218 17.09.2020, 09:

Re: RFR: 8251397: NPE on ClassValue.ClassValueMap.cacheArray [v2]

2020-09-17 Thread Sanne Grinovero
On Wed, 16 Sep 2020 12:25:05 GMT, Sanne Grinovero wrote: >> Updated PR. > > @galderz did you really update the PR? I still see the _storeFence_ before > the write. ah, sorry I got it now. Please ignore my previous comment. - PR: https://git.openjdk.java.net/jdk/pull/94

Integrated: 8202473: A type variable with multiple bounds does not correctly place type annotation

2020-09-17 Thread Rafael Winterhalter
On Mon, 14 Sep 2020 19:49:08 GMT, Rafael Winterhalter wrote: > This patch assures that an annotation on a type bound is placed on the > correct bound index. This pull request has now been integrated. Changeset: 53a4ef26 Author:Rafael Winterhalter Committer: Joel Borggrén-Franck URL:

Re: RFR: 8227745: Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents

2020-09-17 Thread Goetz Lindenmaier
On Thu, 10 Sep 2020 20:48:23 GMT, Richard Reingruber wrote: > Hi, > > this is the continuation of the review of the implementation for: > > https://bugs.openjdk.java.net/browse/JDK-8227745 > https://bugs.openjdk.java.net/browse/JDK-8233915 > > It allows for JIT optimizations based on escape an

Re: RFR: 8227745: Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents

2020-09-17 Thread Goetz Lindenmaier
On Thu, 17 Sep 2020 07:44:09 GMT, Goetz Lindenmaier wrote: >> Hi, >> >> this is the continuation of the review of the implementation for: >> >> https://bugs.openjdk.java.net/browse/JDK-8227745 >> https://bugs.openjdk.java.net/browse/JDK-8233915 >> >> It allows for JIT optimizations based on es

Re: Request for review of JDK-8251548

2020-09-17 Thread David Holmes
Hi Sergey, Since OpenJDK has moved to git/github, this needs to reformulated as a Pull Request (PR). Cheers, David On 17/09/2020 5:19 pm, Сергей Цыпанов wrote: Hello, is it possible to have a code review for the changes proposed in JDK-8251548? Sean Mullan has created an issue and web-revi

Request for review of JDK-8251548

2020-09-17 Thread Сергей Цыпанов
Hello, is it possible to have a code review for the changes proposed in JDK-8251548? Sean Mullan has created an issue and web-review and can sponsor the patch as soos as it gets properly reviewed. As Doug Lea claims in http://cs.oswego.edu/pipermail/concurrency-interest/2015-December/014770.htm