On Tue, 13 Oct 2020 19:07:33 GMT, Volker Simonis wrote:
>> ### Summary
>>
>> Work around wrong usage of `ZipOutputStream.putNextEntry()` in user code
>> which can lead to the `ZipException "invalid
>> entry compressed size"`.
>> ### Motivation
>>
>> In general it is not safe to directly write
> Finally returning to this review that was started in April 2020. I've
> recast it as a github PR. I think the security concern raised by Gil
> has been adequately answered.
> https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2020-April/029203.html
>
> On Oct 12, 2020, at 3:25 PM, Per Liden wrote:
>
> On Mon, 12 Oct 2020 15:56:59 GMT, Kim Barrett wrote:
>
>>> test/hotspot/jtreg/gc/TestReferenceRefersTo.java line 186:
>>>
184:
185: expectNotValue(testWeak2, testObject3, "testWeak2");
186:
On Tue, 13 Oct 2020 20:59:01 GMT, CoreyAshford
wrote:
>
> > Did you already find a 2nd reviewer for the PPC64 part?
>
> Your original comment said "2nd review", so I thought you meant you need to
> review it again after the changes. So, no,
> I haven't looked for or found a second reviewer.
On Tue, 13 Oct 2020 14:48:40 GMT, Andy Herrick wrote:
>> JDK-8252870: Finalize (remove "incubator" from) jpackage
>
> Andy Herrick has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8252870: Finalize (remove "incubator" from) jpackage
>
On Wed, 14 Oct 2020 00:40:14 GMT, Ioi Lam wrote:
>> Calvin Cheung has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now
>> contains ten commits:
>> - fix minimal vm build issues
>> - Merge branch 'master' into 8247666
>> - Merge branch
On Wed, 14 Oct 2020 00:34:04 GMT, Sandhya Viswanathan
wrote:
>> There are several gc tests crashed in panama-vector tier3 testing which
>> seems are not observed in openjdk repo.
>> The crashes look like:
>> # assert(oopDesc::is_oop(obj)) failed: not an oop: 0xfff1
>> #
>> # JRE
On Tue, 13 Oct 2020 23:08:22 GMT, Calvin Cheung wrote:
>> Following up on archiving lambda proxy classes in dynamic CDS archive
>> ([JDK-8198698](https://bugs.openjdk.java.net/browse/JDK-8198698)), this RFE
>> adds the functionality of archiving of
>> lambda proxy classes in static CDS archive.
On Tue, 13 Oct 2020 21:29:52 GMT, Ekaterina Pavlova
wrote:
>> Build changes look good.
>
> There are several gc tests crashed in panama-vector tier3 testing which seems
> are not observed in openjdk repo.
> The crashes look like:
> # assert(oopDesc::is_oop(obj)) failed: not an oop:
On Sat, 10 Oct 2020 08:34:23 GMT, Richard Reingruber wrote:
>> Hi,
>>
>> this is the continuation of the review of the implementation for:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8227745
>> https://bugs.openjdk.java.net/browse/JDK-8233915
>>
>> It allows for JIT optimizations based on
On Tue, 13 Oct 2020 19:51:30 GMT, Roger Riggs wrote:
>> java.util.HexFormat utility:
>>
>> - Format and parse hexadecimal strings, with parameters for delimiter,
>> prefix, suffix and upper/lowercase
>> - Static factories and builder methods to create HexFormat copies with
>> modified
On Tue, 13 Oct 2020 23:28:24 GMT, Alexander Matveev
wrote:
>> Andy Herrick has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JDK-8252870: Finalize (remove "incubator" from) jpackage
>> - reverting two auto-generated files, and
On Tue, 13 Oct 2020 14:48:40 GMT, Andy Herrick wrote:
>> JDK-8252870: Finalize (remove "incubator" from) jpackage
>
> Andy Herrick has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8252870: Finalize (remove "incubator" from) jpackage
>
On Tue, 13 Oct 2020 14:48:40 GMT, Andy Herrick wrote:
>> JDK-8252870: Finalize (remove "incubator" from) jpackage
>
> Andy Herrick has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8252870: Finalize (remove "incubator" from) jpackage
>
On Tue, 13 Oct 2020 21:30:05 GMT, Alexander Matveev
wrote:
>> Andy Herrick has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JDK-8252870: Finalize (remove "incubator" from) jpackage
>> - reverting two auto-generated files, and
> Following up on archiving lambda proxy classes in dynamic CDS archive
> ([JDK-8198698](https://bugs.openjdk.java.net/browse/JDK-8198698)), this RFE
> adds the functionality of archiving of
> lambda proxy classes in static CDS archive.
> When the -XX:DumpLoadedClassList is enabled, the constant
On Mon, 12 Oct 2020 12:56:10 GMT, Erik Joelsson wrote:
>> Paul Sandoz has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now
>> contains ten commits:
>> - Merge master
>> - Fix related to merge
>> - HotspotIntrinsicCandidate to
On Tue, 13 Oct 2020 16:24:32 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/java/util/HexFormat.java line 1015:
>>
>>> 1013: */
>>> 1014: @Override
>>> 1015: public String toString() {
>>
>> Might be useful to also include the class name?
>
> The caller may need to provide
On Tue, 13 Oct 2020 14:48:40 GMT, Andy Herrick wrote:
>> JDK-8252870: Finalize (remove "incubator" from) jpackage
>
> Andy Herrick has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8252870: Finalize (remove "incubator" from) jpackage
>
On Tue, 13 Oct 2020 19:51:30 GMT, Roger Riggs wrote:
>> java.util.HexFormat utility:
>>
>> - Format and parse hexadecimal strings, with parameters for delimiter,
>> prefix, suffix and upper/lowercase
>> - Static factories and builder methods to create HexFormat copies with
>> modified
On Tue, 13 Oct 2020 16:15:51 GMT, Roger Riggs wrote:
>> test/jdk/java/util/HexFormat/HexFormatTest.java line 406:
>>
>>> 404:
>>> 405: int byteVal = hex.fromHexDigits(byteStr);
>>> 406: assert(byteStr.equals("7f"));
>>
>> Why use regular `assert` statements in this test
On Tue, 13 Oct 2020 19:56:42 GMT, Martin Doerr wrote:
> Hi Corey, thanks for taking some stuff out of the “too short” path. There may
> be a performance regression when decoding
> many short arrays because of the stub call overhead and the usage of the
> slower part of the Java implementation.
On Tue, 13 Oct 2020 19:07:33 GMT, Volker Simonis wrote:
>> ### Summary
>>
>> Work around wrong usage of `ZipOutputStream.putNextEntry()` in user code
>> which can lead to the `ZipException "invalid
>> entry compressed size"`.
>> ### Motivation
>>
>> In general it is not safe to directly write
On Tue, 13 Oct 2020 19:07:33 GMT, Volker Simonis wrote:
>> ### Summary
>>
>> Work around wrong usage of `ZipOutputStream.putNextEntry()` in user code
>> which can lead to the `ZipException "invalid
>> entry compressed size"`.
>> ### Motivation
>>
>> In general it is not safe to directly write
On Mon, 12 Oct 2020 22:00:24 GMT, CoreyAshford
wrote:
>> This latest push passes the intrinsic regression test. I had run the
>> intrinsic TestBase64 regression test on the
>> previous push, but not the one in utils. Interesting. Somehow it didn't
>> occur to me that there could be a
On Tue, 13 Oct 2020 19:07:33 GMT, Volker Simonis wrote:
>> ### Summary
>>
>> Work around wrong usage of `ZipOutputStream.putNextEntry()` in user code
>> which can lead to the `ZipException "invalid
>> entry compressed size"`.
>> ### Motivation
>>
>> In general it is not safe to directly write
> java.util.HexFormat utility:
>
> - Format and parse hexadecimal strings, with parameters for delimiter,
> prefix, suffix and upper/lowercase
> - Static factories and builder methods to create HexFormat copies with
> modified parameters.
> - Consistent naming of methods for conversion of
On Tue, 13 Oct 2020 17:16:21 GMT, Lance Andersen wrote:
>> Volker Simonis has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev
>> excludes the unrelated changes brought in by the merge/rebase.
>
> test/jdk/java/util/zip/CopyZipFile.java line
On Tue, 13 Oct 2020 18:50:00 GMT, Lance Andersen wrote:
>> src/java.base/share/classes/java/util/jar/JarOutputStream.java line 87:
>>
>>> 85: *
>>> 86: * The current time will be used if the entry has no set
>>> modification
>>> 87: * time.
>>
>> I'm happy with the wording.
> ### Summary
>
> Work around wrong usage of `ZipOutputStream.putNextEntry()` in user code
> which can lead to the `ZipException "invalid
> entry compressed size"`.
> ### Motivation
>
> In general it is not safe to directly write a ZipEntry obtained from
> `ZipInputStream.getNextEntry()`,
>
> ### Summary
>
> Work around wrong usage of `ZipOutputStream.putNextEntry()` in user code
> which can lead to the `ZipException "invalid
> entry compressed size"`.
> ### Motivation
>
> In general it is not safe to directly write a ZipEntry obtained from
> `ZipInputStream.getNextEntry()`,
>
On Tue, 13 Oct 2020 18:46:59 GMT, Alan Bateman wrote:
>> Volker Simonis has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now
>> contains one commit:
>> 8253952: Refine ZipOutputStream.putNextEntry() to recalculate ZipEntry's
>> compressed
On Tue, 13 Oct 2020 11:40:36 GMT, Volker Simonis wrote:
>> ### Summary
>>
>> Work around wrong usage of `ZipOutputStream.putNextEntry()` in user code
>> which can lead to the `ZipException "invalid
>> entry compressed size"`.
>> ### Motivation
>>
>> In general it is not safe to directly write
On Tue, 13 Oct 2020 11:32:54 GMT, Kiran Sidhartha Ravikumar
wrote:
>> Looks good. I think we should release-note the removal of the
>> "US/Pacific-New" Link on the off chance that some
>> production/testing system is looking for such a zone.
>
> Thanks for the review everyone, I have added a
> This pull request is for integration of the Vector API. It was previously
> reviewed under conditions when mercurial was
> used for the source code control system. Review threads can be found here
> (searching for issue number 8223347 in the
> title):
>
On Tue, 13 Oct 2020 14:48:40 GMT, Andy Herrick wrote:
>> JDK-8252870: Finalize (remove "incubator" from) jpackage
>
> Andy Herrick has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8252870: Finalize (remove "incubator" from) jpackage
>
On Mon, 12 Oct 2020 23:05:44 GMT, Marcono1234
wrote:
> Also is it common practice to use `System.out` in JDK tests? In my opinion it
> often does not add much value once the
> unit test implementation has been completed because the output is not checked
> during tests automatically anyways
On Tue, 13 Oct 2020 11:40:36 GMT, Volker Simonis wrote:
>> ### Summary
>>
>> Work around wrong usage of `ZipOutputStream.putNextEntry()` in user code
>> which can lead to the `ZipException "invalid
>> entry compressed size"`.
>> ### Motivation
>>
>> In general it is not safe to directly write
On Mon, 12 Oct 2020 19:36:52 GMT, Kiran Sidhartha Ravikumar
wrote:
> Hi Guys,
>
> Please review the fix to remove jdk.internal.ref.SoftCleanable and
> WeakCleanable classes as there is no visible usage
> of them in JDK. Currently, only PhantomCleanable is used.
> More information can be
On Sun, 11 Oct 2020 07:20:07 GMT, Richard Reingruber wrote:
>>>
>>>
>>> I tried to run testing with latest changes and latest JDK and build failed:
>>> src/hotspot/share/runtime/escapeBarrier.cpp:310:35: error: no matching
>>> function for call to
>>>
On Wed, 7 Oct 2020 17:04:02 GMT, Lance Andersen wrote:
>> I totally agree. What about using just the last sentence (as you've
>> proposed) in the spec section and add the other to
>> as @implNote? O you think the last sentence will be enough?
>
> I think we can just go with the last
On Tue, 13 Oct 2020 16:39:51 GMT, Roger Riggs wrote:
>> Hi Guys,
>>
>> Please review the fix to remove jdk.internal.ref.SoftCleanable and
>> WeakCleanable classes as there is no visible usage
>> of them in JDK. Currently, only PhantomCleanable is used.
>> More information can be viewed at
>>
On Mon, 12 Oct 2020 19:36:52 GMT, Kiran Sidhartha Ravikumar
wrote:
> Hi Guys,
>
> Please review the fix to remove jdk.internal.ref.SoftCleanable and
> WeakCleanable classes as there is no visible usage
> of them in JDK. Currently, only PhantomCleanable is used.
> More information can be
On Mon, 12 Oct 2020 20:48:52 GMT, Marcono1234
wrote:
>> java.util.HexFormat utility:
>>
>> - Format and parse hexadecimal strings, with parameters for delimiter,
>> prefix, suffix and upper/lowercase
>> - Static factories and builder methods to create HexFormat copies with
>> modified
On Mon, 12 Oct 2020 22:36:34 GMT, Marcono1234
wrote:
>> java.util.HexFormat utility:
>>
>> - Format and parse hexadecimal strings, with parameters for delimiter,
>> prefix, suffix and upper/lowercase
>> - Static factories and builder methods to create HexFormat copies with
>> modified
On Tue, 13 Oct 2020 13:35:37 GMT, Pavel Rappo wrote:
>> The proposed implementation behaves differently from the existing
>> implementation in the case of `null` value. That is,
>> when `map.containsKey(key) == true && map.get(key) == null`. The difference
>> is that the proposed
On Mon, 12 Oct 2020 20:41:20 GMT, Marcono1234
wrote:
>> java.util.HexFormat utility:
>>
>> - Format and parse hexadecimal strings, with parameters for delimiter,
>> prefix, suffix and upper/lowercase
>> - Static factories and builder methods to create HexFormat copies with
>> modified
On Mon, 12 Oct 2020 19:36:52 GMT, Kiran Sidhartha Ravikumar
wrote:
> Hi Guys,
>
> Please review the fix to remove jdk.internal.ref.SoftCleanable and
> WeakCleanable classes as there is no visible usage
> of them in JDK. Currently, only PhantomCleanable is used.
> More information can be
> This pull request is for integration of the Vector API. It was previously
> reviewed under conditions when mercurial was
> used for the source code control system. Review threads can be found here
> (searching for issue number 8223347 in the
> title):
>
49 matches
Mail list logo
