Re: RFR: 8227745: Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents [v13]

2020-10-18 Thread Richard Reingruber
> Hi, > > this is the continuation of the review of the implementation for: > > https://bugs.openjdk.java.net/browse/JDK-8227745 > https://bugs.openjdk.java.net/browse/JDK-8233915 > > It allows for JIT optimizations based on escape analysis even if JVMTI agents > acquire capabilities to access

Integrated: 8253455: Record Classes javax.lang.model changes

2020-10-18 Thread Vicente Romero
On Mon, 21 Sep 2020 23:31:51 GMT, Vicente Romero wrote: > Please review the fix for > [JDK-8253455](https://bugs.openjdk.java.net/browse/JDK-8253455) which is part > of the effort > to make records a final feature of the Java Language. The rest of the code > has been published in >

RFR: 8228988: AnnotationParser throws NullPointerException on incompatible member type

2020-10-18 Thread Rafael Winterhalter
If an annotation member type is changed in an incompatible manner, the `AnnotationParser` currently throws a `NullPointerException` if: - An enumeration-typed member is changed to be an annotation type or a `Class` type. - An annotation type is changed to be a non-annotation type. This patch

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v4]

2020-10-18 Thread David Holmes
Hi Jorn, I'm not reviewing this but this exchange caught my attention ... On 16/10/2020 9:15 pm, Jorn Vernee wrote: On Thu, 15 Oct 2020 22:42:49 GMT, Coleen Phillimore wrote: Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8188055: (ref) Add Reference::refersTo predicate [v5]

2020-10-18 Thread David Holmes
On 17/10/2020 1:23 am, Kim Barrett wrote: On Fri, 16 Oct 2020 05:41:17 GMT, David Holmes wrote: Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request

Integrated: 8246774: implement Record Classes as a standard feature in Java

2020-10-18 Thread Vicente Romero
On Mon, 21 Sep 2020 21:30:51 GMT, Vicente Romero wrote: > 8246774: implement Record Classes as a standard feature in Java This pull request has now been integrated. Changeset: c17d5851 Author:Vicente Romero URL: https://git.openjdk.java.net/jdk/commit/c17d5851 Stats: 856 lines

Re: RFR: 8246774: implement Record Classes as a standard feature in Java [v13]

2020-10-18 Thread Vicente Romero
> 8246774: implement Record Classes as a standard feature in Java Vicente Romero has updated the pull request incrementally with one additional commit since the last revision: removing reference to unused jcod file from test - Changes: - all:

Re: RFR: 8246774: implement Record Classes as a standard feature in Java [v12]

2020-10-18 Thread Vicente Romero
> 8246774: implement Record Classes as a standard feature in Java Vicente Romero has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits: - Merge branch 'master' into JDK-8246774 - Merge branch 'master' into JDK-8246774 -

Re: RFR: 8159746: (proxy) Support for default methods

2020-10-18 Thread Peter Levart
On Fri, 16 Oct 2020 18:13:08 GMT, Mandy Chung wrote: >> Hi Mandy, >> >> I read your concerns and have an alternative API proposition here. Instread >> of an abstract class with protected final >> `invokeDefaultMethod` method, we can keep the public static >> `invokeDefaultMethod` and add a

Re: RFR: 8227745: Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents [v12]

2020-10-18 Thread Richard Reingruber
> Hi, > > this is the continuation of the review of the implementation for: > > https://bugs.openjdk.java.net/browse/JDK-8227745 > https://bugs.openjdk.java.net/browse/JDK-8233915 > > It allows for JIT optimizations based on escape analysis even if JVMTI agents > acquire capabilities to access