Re: RFR: 8188055: (ref) Add Reference::refersTo predicate [v5]

2020-10-19 Thread Kim Barrett
On Tue, 20 Oct 2020 03:25:45 GMT, Mandy Chung wrote: > @kimbarrett your reworded text is okay. I think "if it initially had some > other referent value" can be dropped. > > For a `Reference` constructed with a `null` referent, we can clarify in the > spec that such reference object will never

Re: RFR: 8188055: (ref) Add Reference::refersTo predicate [v5]

2020-10-19 Thread David Holmes
On 20/10/2020 12:40 pm, Kim Barrett wrote: On Oct 19, 2020, at 7:20 PM, Mandy Chung wrote: On Mon, 19 Oct 2020 23:10:23 GMT, Mandy Chung wrote: Looks good. That's the crux of it: what exactly is meant by "the referent"? Does it mean the original object that was used as the referent, or

Re: RFR: 8188055: (ref) Add Reference::refersTo predicate [v5]

2020-10-19 Thread Mandy Chung
On Mon, 19 Oct 2020 23:17:32 GMT, Mandy Chung wrote: >>> That's the crux of it: what exactly is meant by "the referent"? Does it >>> mean the original object that was used as the referent, or does it mean >>> the current value of the "referent" field inside the Reference (as get >>> might

Re: RFR: 8250625: Compiler implementation of Pattern Matching for instanceof (Final)

2020-10-19 Thread Vicente Romero
On Thu, 8 Oct 2020 11:49:17 GMT, Jan Lahoda wrote: > This is the current proposed patch for the upcoming JEP 394, for pattern > matching for instanceof. > > A summary of changes: > -making the feature permanent (non-preview) > -making the binding variables non-final (as per current

Re: RFR: 8188055: (ref) Add Reference::refersTo predicate [v5]

2020-10-19 Thread Kim Barrett
> On Oct 19, 2020, at 7:20 PM, Mandy Chung wrote: > > On Mon, 19 Oct 2020 23:10:23 GMT, Mandy Chung wrote: > >>> Looks good. >> >>> That's the crux of it: what exactly is meant by "the referent"? Does it >>> mean the original object that was used as the referent, or does it mean >>> the

Re: RFR: 8188055: (ref) Add Reference::refersTo predicate [v5]

2020-10-19 Thread David Holmes
Hi Mandy, On 20/10/2020 9:20 am, Mandy Chung wrote: On Mon, 19 Oct 2020 23:10:23 GMT, Mandy Chung wrote: Looks good. That's the crux of it: what exactly is meant by "the referent"? Does it mean the original object that was used as the referent, or does it mean the current value of the

RE: Howto replicate failure of 8254790?

2020-10-19 Thread Viswanathan, Sandhya
Hi Jason, I think I found the problem looking at the error log from Vladimir Kozlov. In stringL_indexof_char() function, the following snippet is the cause of problem: 2807 bind(FOUND_CHAR); 2808 if (UseAVX >= 2) { 2809 vpmovmskb(tmp, vec3); 2810 } else { 2811 pmovmskb(tmp, vec3);

Integrated: 8255016: ConstantDescs.FALSE claims it represents TRUE

2020-10-19 Thread Stuart Marks
On Mon, 19 Oct 2020 18:08:28 GMT, Stuart Marks wrote: > This is a fix for "just a typo" or copy/paste error, but it probably requires > a CSR since it changes a normative > portion of the spec. This pull request has now been integrated. Changeset: bf19581a Author:Stuart Marks URL:

Re: RFR: 8188055: (ref) Add Reference::refersTo predicate [v5]

2020-10-19 Thread Mandy Chung
On Mon, 19 Oct 2020 23:10:23 GMT, Mandy Chung wrote: >> Looks good. > >> That's the crux of it: what exactly is meant by "the referent"? Does it >> mean the original object that was used as the referent, or does it mean >> the current value of the "referent" field inside the Reference (as get >>

Re: RFR: 8188055: (ref) Add Reference::refersTo predicate [v5]

2020-10-19 Thread Mandy Chung
On Fri, 16 Oct 2020 17:04:51 GMT, Mandy Chung wrote: >> Kim Barrett has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev >> excludes the unrelated changes brought in by the merge/rebase. The pull >> request contains 11 additional commits

Re: RFR: 8251989: Hex formatting and parsing utility [v6]

2020-10-19 Thread Roger Riggs
> java.util.HexFormat utility: > > - Format and parse hexadecimal strings, with parameters for delimiter, > prefix, suffix and upper/lowercase > - Static factories and builder methods to create HexFormat copies with > modified parameters. > - Consistent naming of methods for conversion of

Question about InputStream.reset Contract and Behavior

2020-10-19 Thread Mathias Ricken
Hi, My team at OCI is trying to correctly implement retries for stream uploads, and we’ve come across the following comment in InputStream.reset(): https://docs.oracle.com/javase/7/docs/api/java/io/InputStream.html#reset() If the method markSupported returns true, then: · If

Re: RFR: 8188055: (ref) Add Reference::refersTo predicate [v5]

2020-10-19 Thread David Holmes
Hi Kim, On 19/10/2020 9:29 pm, Kim Barrett wrote: On Oct 18, 2020, at 5:36 PM, David Holmes wrote: On 17/10/2020 1:23 am, Kim Barrett wrote: src/java.base/share/classes/java/lang/ref/Reference.java line 348: 346: * Tests if this reference object refers to {@code obj}. If {@code obj}

Integrated: 8255020: Minor updates to docs jdk.incubator.vector

2020-10-19 Thread Paul Sandoz
On Mon, 19 Oct 2020 18:41:31 GMT, Paul Sandoz wrote: > Minor updates, with no specification changes, to the documentation of Vector > API. > > The compilation of the Vector module was updated to turn on doclint errors > for >= protected documentation. This pull request has now been

Re: RFR: 8252204: AArch64: Implement SHA3 accelerator/intrinsic [v9]

2020-10-19 Thread Vladimir Kozlov
On Mon, 19 Oct 2020 11:14:22 GMT, Fei Yang wrote: >> Contributed-by: ard.biesheu...@linaro.org, dong...@huawei.com >> >> This added an intrinsic for SHA3 using aarch64 v8.2 SHA3 Crypto Extensions. >> Reference implementation for core SHA-3 transform using ARMv8.2 Crypto >> Extensions: >>

RFR: 8255022: Documentation missing for Vector API zero methods

2020-10-19 Thread Paul Sandoz
The zero methods on `IntVector` and all other specializations are missing documentation. - Commit messages: - 8255022: Documentation missing for Vector API zero methods Changes: https://git.openjdk.java.net/jdk/pull/748/files Webrev:

Re: RFR: 8255020: Minor updates to docs jdk.incubator.vector

2020-10-19 Thread Joe Darcy
On Mon, 19 Oct 2020 18:41:31 GMT, Paul Sandoz wrote: > Minor updates, with no specification changes, to the documentation of Vector > API. > > The compilation of the Vector module was updated to turn on doclint errors > for >= protected documentation. Marked as reviewed by darcy (Reviewer).

Re: RFR: 8254982: (tz) Upgrade time-zone data to tzdata2020c

2020-10-19 Thread Naoto Sato
On Mon, 19 Oct 2020 18:44:28 GMT, Kiran Sidhartha Ravikumar wrote: > Hi Guys, > > Please review the integration of tzdata2020c to JDK. > > Details regarding the change can be viewed at - > https://mm.icann.org/pipermail/tz-announce/2020-October/60.html > Bug:

Re: RFR: 8227745: Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents [v10]

2020-10-19 Thread Richard Reingruber
On Wed, 14 Oct 2020 20:50:45 GMT, Richard Reingruber wrote: >> Good. > >> >> >> Good. > > Thanks for the review, Vladimir (@vnkozlov)! > I'm still (stress) testing adaptations to lazy/concurrent thread stack > processing for ZGC. > --Richard. Thanks once more @TheRealMDoerr, @GoeLin,

Re: RFR: 8255016: ConstantDescs.FALSE claims it represents TRUE

2020-10-19 Thread Roger Riggs
On Mon, 19 Oct 2020 18:08:28 GMT, Stuart Marks wrote: > This is a fix for "just a typo" or copy/paste error, but it probably requires > a CSR since it changes a normative > portion of the spec. Marked as reviewed by rriggs (Reviewer). - PR:

Re: RFR: 8255016: ConstantDescs.FALSE claims it represents TRUE

2020-10-19 Thread Mandy Chung
On Mon, 19 Oct 2020 18:08:28 GMT, Stuart Marks wrote: > This is a fix for "just a typo" or copy/paste error, but it probably requires > a CSR since it changes a normative > portion of the spec. +1 - Marked as reviewed by mchung (Reviewer). PR:

Re: RFR: 8255020: Minor updates to docs jdk.incubator.vector

2020-10-19 Thread Erik Joelsson
On Mon, 19 Oct 2020 18:41:31 GMT, Paul Sandoz wrote: > Minor updates, with no specification changes, to the documentation of Vector > API. > > The compilation of the Vector module was updated to turn on doclint errors > for >= protected documentation. Build change looks ok. -

Re: RFR: 8254982: (tz) Upgrade time-zone data to tzdata2020c

2020-10-19 Thread Erik Joelsson
On Mon, 19 Oct 2020 18:44:28 GMT, Kiran Sidhartha Ravikumar wrote: > Hi Guys, > > Please review the integration of tzdata2020c to JDK. > > Details regarding the change can be viewed at - > https://mm.icann.org/pipermail/tz-announce/2020-October/60.html > Bug:

Re: RFR: 8255016: ConstantDescs.FALSE claims it represents TRUE

2020-10-19 Thread Jorn Vernee
On Mon, 19 Oct 2020 18:08:28 GMT, Stuart Marks wrote: > This is a fix for "just a typo" or copy/paste error, but it probably requires > a CSR since it changes a normative > portion of the spec. Looks good, though I'm not a Reviewer™, I'm the one who introduced this code. It is indeed a typo.

RFR: 8255020: Minor updates to docs jdk.incubator.vector

2020-10-19 Thread Paul Sandoz
Minor updates, with no specification changes, to the documentation of Vector API. The compilation of the Vector module was updated to turn on doclint errors for >= protected documentation. - Commit messages: - 8255020:Minor updates to docs jdk.incubator.vector Changes:

RFR: 8254982: (tz) Upgrade time-zone data to tzdata2020c

2020-10-19 Thread Kiran Sidhartha Ravikumar
Hi Guys, Please review the integration of tzdata2020c to JDK. Details regarding the change can be viewed at - https://mm.icann.org/pipermail/tz-announce/2020-October/60.html Bug: https://bugs.openjdk.java.net/browse/JDK-8254982 Along with it, there is a test fix for

Re: RFR: 8227745: Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents [v14]

2020-10-19 Thread Richard Reingruber
> Hi, > > this is the continuation of the review of the implementation for: > > https://bugs.openjdk.java.net/browse/JDK-8227745 > https://bugs.openjdk.java.net/browse/JDK-8233915 > > It allows for JIT optimizations based on escape analysis even if JVMTI agents > acquire capabilities to access

Re: RFR: 8255016: ConstantDescs.FALSE claims it represents TRUE

2020-10-19 Thread Brian Burkhalter
On Mon, 19 Oct 2020 18:08:28 GMT, Stuart Marks wrote: > This is a fix for "just a typo" or copy/paste error, but it probably requires > a CSR since it changes a normative > portion of the spec. Approved. - Marked as reviewed by bpb (Reviewer). PR:

Integrated: 8247666: Support Lambda proxy classes in static CDS archive

2020-10-19 Thread Calvin Cheung
On Fri, 25 Sep 2020 17:52:24 GMT, Calvin Cheung wrote: > Following up on archiving lambda proxy classes in dynamic CDS archive > ([JDK-8198698](https://bugs.openjdk.java.net/browse/JDK-8198698)), this RFE > adds the functionality of archiving of > lambda proxy classes in static CDS archive. >

Re: RFR: 8255016: ConstantDescs.FALSE claims it represents TRUE

2020-10-19 Thread Brian Burkhalter
On Mon, 19 Oct 2020 18:08:28 GMT, Stuart Marks wrote: > This is a fix for "just a typo" or copy/paste error, but it probably requires > a CSR since it changes a normative > portion of the spec. Looks OK. - PR: https://git.openjdk.java.net/jdk/pull/744

Re: RFR: 8251989: Hex formatting and parsing utility [v5]

2020-10-19 Thread Roger Riggs
On Mon, 19 Oct 2020 16:35:19 GMT, Daniel Fuchs wrote: >> Roger Riggs has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev >> excludes the unrelated changes brought in by the merge/rebase. The pull >> request contains 10 additional commits

Re: RFR: 8247666: Support Lambda proxy classes in static CDS archive [v9]

2020-10-19 Thread Calvin Cheung
On Mon, 19 Oct 2020 16:56:19 GMT, Ioi Lam wrote: >> Calvin Cheung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> store symbolic name of ref kind (e.g. REF_invokeStatic) in classlist > > LGTM @iklam and @mlchung, thanks again for the

RFR: 8255016: ConstantDescs.FALSE claims it represents TRUE

2020-10-19 Thread Stuart Marks
This is a fix for "just a typo" or copy/paste error, but it probably requires a CSR since it changes a normative portion of the spec. - Commit messages: - 8255016: ConstantDescs.FALSE claims it represents TRUE Changes: https://git.openjdk.java.net/jdk/pull/744/files Webrev:

Re: RFR: 8247666: Support Lambda proxy classes in static CDS archive [v10]

2020-10-19 Thread Calvin Cheung
> Following up on archiving lambda proxy classes in dynamic CDS archive > ([JDK-8198698](https://bugs.openjdk.java.net/browse/JDK-8198698)), this RFE > adds the functionality of archiving of > lambda proxy classes in static CDS archive. > When the -XX:DumpLoadedClassList is enabled, the constant

Re: RFR: 8253525: Implement getInstanceSize/sizeOf intrinsics [v3]

2020-10-19 Thread Vladimir Kozlov
On Mon, 19 Oct 2020 06:57:24 GMT, Aleksey Shipilev wrote: >> This is fork off the SizeOf JEP, JDK-8249196. There is already the entry >> point in JDK that can use the intrinsic like >> this: `Instrumentation.getInstanceSize`. Therefore, we can implement the >> C1/C2 intrinsic now, hook it up

Re: RFR: 8247402: Documentation for Map::compute contains confusing implementation requirements

2020-10-19 Thread Daniel Fuchs
On Sat, 17 Oct 2020 02:50:28 GMT, John Lin wrote: > This is from the mailing list: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2020-June/067190.html > > - > ### Progress > - [x] Change must not contain extraneous whitespace > - [x] Commit message must refer to an issue > -

Re: RFR: 8238669: Long.divideUnsigned is extremely slow for certain values (Needs to be Intrinsic) [v2]

2020-10-19 Thread Brian Burkhalter
On Mon, 19 Oct 2020 15:18:58 GMT, Raffaello Giulietti wrote: >> I think the change looks good. >> >> Before the project was on GitHub, there was a change to the test posted in >> http://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068504.html >> to address the comment in >>

Re: RFR: 8251989: Hex formatting and parsing utility [v5]

2020-10-19 Thread Daniel Fuchs
On Fri, 16 Oct 2020 19:56:30 GMT, Roger Riggs wrote: >> java.util.HexFormat utility: >> >> - Format and parse hexadecimal strings, with parameters for delimiter, >> prefix, suffix and upper/lowercase >> - Static factories and builder methods to create HexFormat copies with >> modified

Re: RFR: 8247666: Support Lambda proxy classes in static CDS archive [v9]

2020-10-19 Thread Calvin Cheung
> Following up on archiving lambda proxy classes in dynamic CDS archive > ([JDK-8198698](https://bugs.openjdk.java.net/browse/JDK-8198698)), this RFE > adds the functionality of archiving of > lambda proxy classes in static CDS archive. > When the -XX:DumpLoadedClassList is enabled, the constant

Re: RFR: 8238669: Long.divideUnsigned is extremely slow for certain values (Needs to be Intrinsic) [v2]

2020-10-19 Thread Raffaello Giulietti
On Sat, 17 Oct 2020 00:16:57 GMT, Brian Burkhalter wrote: >> Hello, >> >> a reminder that this issue has not been formally reviewed. >> Estimated time: 10-15 min with "Hacker's delight" on the desk. >> >> Greetings >> Raffaello > > I think the change looks good. > > Before the project was on

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v6]

2020-10-19 Thread Maurizio Cimadamore
> This patch contains the changes associated with the first incubation round of > the foreign linker access API incubation > (see JEP 389 [1]). This work is meant to sit on top of the foreign memory > access support (see JEP 393 [2] and > associated pull request [3]). > The main goal of this API

Re: RFR: 8238669: Long.divideUnsigned is extremely slow for certain values (Needs to be Intrinsic) [v3]

2020-10-19 Thread Raffaello Giulietti
> This is a follow-up of the Mercurial-based workflow initiated on the > core-lib-devs mailing list [0]. Not sure if this > one is strictly necessary or if the patches sent on the list are sufficient. > Anyway, I exploit this PR as a test ;-) > [0] >

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12

2020-10-19 Thread Jan Lahoda
On Mon, 19 Oct 2020 14:22:17 GMT, Hannes Wallnöfer wrote: >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java >> line 2238: >> >>> 2236: if (previewTree != null) { >>> 2237: previewDiv.add(new >>>

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12

2020-10-19 Thread Hannes Wallnöfer
On Mon, 19 Oct 2020 14:09:51 GMT, Hannes Wallnöfer wrote: >> This is an update to javac and javadoc, to introduce support for Preview >> APIs, and generally improve javac and javadoc >> behavior to more closely adhere to JEP 12. >> The notable changes are: >> >> * adding support for Preview

Re: RFR: JDK-8254783: jpackage fails on Windows when application name differs …

2020-10-19 Thread Andy Herrick
On Mon, 19 Oct 2020 10:55:30 GMT, Alexey Semenyuk wrote: > > > I think we need a test for this use case. The automated test is complicated by the same incorrect assumptions in the test infrastructure (that installer name and app name are the same) . I am working on this . - PR:

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12

2020-10-19 Thread Hannes Wallnöfer
On Fri, 16 Oct 2020 15:20:03 GMT, Jan Lahoda wrote: > This is an update to javac and javadoc, to introduce support for Preview > APIs, and generally improve javac and javadoc > behavior to more closely adhere to JEP 12. > The notable changes are: > > * adding support for Preview APIs (javac

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v5]

2020-10-19 Thread Maurizio Cimadamore
> This patch contains the changes associated with the first incubation round of > the foreign linker access API incubation > (see JEP 389 [1]). This work is meant to sit on top of the foreign memory > access support (see JEP 393 [2] and > associated pull request [3]). > The main goal of this API

Re: RFR: JDK-8254843: Exception launching app on windows in some cases

2020-10-19 Thread Andy Herrick
On Fri, 16 Oct 2020 23:31:24 GMT, Alexander Matveev wrote: >> JDK-8254843: Exception launching app on windows in some cases >> loading splashscreen.dll in WinLaunchercpp would load java.dll from path >> instead of runtime/bin causing jni launcher to >> crash. instead we just use what used to

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v4]

2020-10-19 Thread Jorn Vernee
On Fri, 16 Oct 2020 11:12:01 GMT, Jorn Vernee wrote: >> src/hotspot/cpu/x86/foreign_globals_x86.cpp line 56: >> >>> 54: } >>> 55: >>> 56: const ABIDescriptor parseABIDescriptor(JNIEnv* env, jobject jabi) { >> >> I don't know if you care about performance but of these env->calls >> transition

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v4]

2020-10-19 Thread Jorn Vernee
On Thu, 15 Oct 2020 23:15:07 GMT, Coleen Phillimore wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Re-add file erroneously deleted (detected as rename) > > I looked through some Hotspot runtime code and

Re: RFR: 8188055: (ref) Add Reference::refersTo predicate [v5]

2020-10-19 Thread Kim Barrett
> On Oct 18, 2020, at 5:36 PM, David Holmes wrote: > > On 17/10/2020 1:23 am, Kim Barrett wrote: >>> src/java.base/share/classes/java/lang/ref/Reference.java line 348: >>> 346: * Tests if this reference object refers to {@code obj}. If {@code obj} is 347: * {@code

Re: RFR: JDK-8254783: jpackage fails on Windows when application name differs …

2020-10-19 Thread Alexey Semenyuk
On Sat, 17 Oct 2020 14:01:22 GMT, Andy Herrick wrote: > …from installer name > JDK-8254783: jpackage fails on Windows when application name differs from > installer name > When using --app-image, to create MSI installer, use the application name > from AppImageData instead of the Msi >

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v6]

2020-10-19 Thread Maurizio Cimadamore
On Mon, 12 Oct 2020 18:06:55 GMT, Maurizio Cimadamore wrote: >> Build changes look good. > > I've just uploaded a biggie update to the foreign memory access support. > While doing performance evaluation, we have > realized that mixing a multi-level hierarchy (`MappedMemorySegment extends >

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v13]

2020-10-19 Thread Maurizio Cimadamore
> This patch contains the changes associated with the third incubation round of > the foreign memory access API incubation > (see JEP 393 [1]). This iteration focus on improving the usability of the API > in 3 main ways: > * first, by providing a way to obtain truly *shared* segments, which can

Re: RFR: 8253525: Implement getInstanceSize/sizeOf intrinsics [v3]

2020-10-19 Thread Aleksey Shipilev
> This is fork off the SizeOf JEP, JDK-8249196. There is already the entry > point in JDK that can use the intrinsic like > this: `Instrumentation.getInstanceSize`. Therefore, we can implement the > C1/C2 intrinsic now, hook it up to > `Instrumentation`, and let the tools use that fast path

Re: RFR: 8253525: Implement getInstanceSize/sizeOf intrinsics [v2]

2020-10-19 Thread Aleksey Shipilev
> This is fork off the SizeOf JEP, JDK-8249196. There is already the entry > point in JDK that can use the intrinsic like > this: `Instrumentation.getInstanceSize`. Therefore, we can implement the > C1/C2 intrinsic now, hook it up to > `Instrumentation`, and let the tools use that fast path