Re: [jpackage] Issue with upgrading from javapackager to jpackage on Windows

2020-10-29 Thread Alexey Semenyuk
Hi Daniel, The original issue described in the CR is expected to persist with element in WiX source of  msi installers produced by jpackage. For the reasons described in the comment to the CR. Unfortunately there is no simple fix for the problem. Fortunately there is simple workaround for it

Re: Incorrect value of resource.wxl-file-name in WinResources_ja.properties and WinResources_zh_CN.properties

2020-10-29 Thread Andy Herrick
your right - I filed JDK-8255619 to fix this in JDK-16 /Andy On 10/29/2020 1:03 PM, Serban Iordache wrote: A China-based user of my Gradle plugin for creating installable packages reported getting the following light.exe error: LGHT0311 : A string was provided with characters that are not avail

Integrated: 8254975: lambda proxy fails to access a protected member inherited from a split package

2020-10-29 Thread Mandy Chung
On Tue, 20 Oct 2020 18:13:39 GMT, Mandy Chung wrote: > It's a bug in determining if a protected member inherited from a superclass > is in > a split package as its host class that it only checks on the package name. > > The fix is simple and compare the runtime package of the lambda class (wh

Re: RFR: JDK-8254920: Application launched with jpackage produced .exe crashes JVM

2020-10-29 Thread Alexey Semenyuk
On Thu, 29 Oct 2020 17:32:24 GMT, Andy Herrick wrote: > JVM test/jdk/tools/jpackage/helpers/jdk/jpackage/test/HelloApp.java line 276: > 274: AppOutputVerifier av = getVerifier(cmd, args); > 275: if (av != null) { > 276: // when running app launchers, clear users envi

Integrated: 8255449: Improve the exception message of MethodHandles::permuteArguments

2020-10-29 Thread Jorn Vernee
On Tue, 27 Oct 2020 12:43:47 GMT, Jorn Vernee wrote: > Hi, > > Currently, if MethodHandles::permuteArguments is used with a reorder array > that is the wrong size, or one of the indexes in it is out of bounds of the > new type, we simply get the exception message: > > bad reorder array [.

Re: RFR: 8254975: lambda proxy fails to access a protected member inherited from a split package

2020-10-29 Thread Roger Riggs
On Tue, 20 Oct 2020 18:13:39 GMT, Mandy Chung wrote: > It's a bug in determining if a protected member inherited from a superclass > is in > a split package as its host class that it only checks on the package name. > > The fix is simple and compare the runtime package of the lambda class (wh

RFR: 8186085: (opt) add filter(), flatMap(), and map() methods to OptionalDouble/Int/Long

2020-10-29 Thread Kartik Ohri
Hi all, This PR intends to add filter, map and flatMap methods to the Optional classes for primitives. The rationale is consistency with the Optional class for objects and user convenience. Thanks. Regards, Kartik - Commit messages: - 8186085: (opt) add filter(), flatMap(), and map

Re: RFR: 8254354: Add an asExact() VarHandle combinator [v9]

2020-10-29 Thread Jorn Vernee
> Hi, > > This patch adds an asExact() combinator to VarHandle, that will return a new > VarHandle that performs exact type checks, similar to > MethodHandle::invokeExact, to help developers catch inexact VarHandle usage, > which can lead to performance degradation. > > This is implemented usi

Re: RFR: 8254354: Add an asExact() VarHandle combinator [v2]

2020-10-29 Thread Jorn Vernee
On Tue, 27 Oct 2020 15:01:31 GMT, Jorn Vernee wrote: >> I've updated the implementation of accessModeType to work with the ordinal >> directly. Note that it was using the AccessType ordinal though, so I also >> had to change the parameter type of accessModeTypeUncached, and the >> respective i

RFR: JDK-8254920: Application launched with jpackage produced .exe crashes JVM

2020-10-29 Thread Andy Herrick
JVM - Commit messages: - JDK-8254920: Application launched with jpackage produced .exe crashes Changes: https://git.openjdk.java.net/jdk/pull/940/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=940&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8254920 Sta

Incorrect value of resource.wxl-file-name in WinResources_ja.properties and WinResources_zh_CN.properties

2020-10-29 Thread Serban Iordache
A China-based user of my Gradle plugin for creating installable packages reported getting the following light.exe error: LGHT0311 : A string was provided with characters that are not available in the specified database code page '1252'. I cannot reproduce the error because I don't have a machine r

RFR: 8247781: Day periods support

2020-10-29 Thread Naoto Sato
Hi, Please review the changes for the subject issue. This is to enhance the java.time package to support day periods, such as "in the morning", defined in CLDR. It will add a new pattern character 'B' and its supporting builder method. The motivation and its spec are in this CSR: https://bugs.

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator)

2020-10-29 Thread Maurizio Cimadamore
On Tue, 27 Oct 2020 14:40:29 GMT, Maurizio Cimadamore wrote: >> This patch contains the changes associated with the third incubation round >> of the foreign memory access API incubation (see JEP 393 [1]). This >> iteration focus on improving the usability of the API in 3 main ways: >> >> * f

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v18]

2020-10-29 Thread Maurizio Cimadamore
> This patch contains the changes associated with the third incubation round of > the foreign memory access API incubation (see JEP 393 [1]). This iteration > focus on improving the usability of the API in 3 main ways: > > * first, by providing a way to obtain truly *shared* segments, which can

Re: RFR: 8250625: Compiler implementation of Pattern Matching for instanceof (Final) [v5]

2020-10-29 Thread Jan Lahoda
> This is the current proposed patch for the upcoming JEP 394, for pattern > matching for instanceof. > > A summary of changes: > -making the feature permanent (non-preview) > -making the binding variables non-final (as per current specification > proposal) > -producing a compile-time error for

Integrated: 8254782: Fix benchmark issues in java/lang/StringIndexOfChar.java benchmark

2020-10-29 Thread Jason Tatton
On Wed, 28 Oct 2020 21:59:53 GMT, Jason Tatton wrote: > Please review the improvements which I have made to the > java/lang/StringIndexOfChar.java jmh benchmark. Please let me know if any > further improvements are required. > > Thanks, > Jason This pull request has now been integrated. Cha

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v4]

2020-10-29 Thread Jan Lahoda
On Tue, 27 Oct 2020 16:11:18 GMT, Jan Lahoda wrote: >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java >> line 2980: >> >>> 2978: } >>> 2979: >>> 2980: public enum DeclarationPreviewLanguageFeatures { >> >> General thinking aloud question ... how doe

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v4]

2020-10-29 Thread Jan Lahoda
On Fri, 23 Oct 2020 18:19:13 GMT, Jonathan Gibbons wrote: >> Jan Lahoda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removing unnecessary cast. > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java >

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v4]

2020-10-29 Thread Jan Lahoda
On Fri, 23 Oct 2020 17:58:42 GMT, Jonathan Gibbons wrote: >> Jan Lahoda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removing unnecessary cast. > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Navigation.jav

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v4]

2020-10-29 Thread Jan Lahoda
On Fri, 23 Oct 2020 18:28:12 GMT, Jonathan Gibbons wrote: >> Jan Lahoda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removing unnecessary cast. > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/ElementsTable.java > line 128

Re: [jpackage] Issue with upgrading from javapackager to jpackage on Windows

2020-10-29 Thread Daniel Peintner
Alexey, all, Thanks for keeping me updated. I agree with the statement that a full fledged procedure for updates is out of scope for jpackage. Note: It is mentioned that has been added also in the meantime. I did try it out with JDK-16-ea+21 and my application but the issue still persists (but

Re: RFR: 8254782: Fix benchmark issues in java/lang/StringIndexOfChar.java benchmark [v2]

2020-10-29 Thread Claes Redestad
On Thu, 29 Oct 2020 00:59:56 GMT, Jason Tatton wrote: >> Please review the improvements which I have made to the >> java/lang/StringIndexOfChar.java jmh benchmark. Please let me know if any >> further improvements are required. >> >> Thanks, >> Jason > > Jason Tatton has updated the pull requ