RFR: 8255625: AArch64: Implement Base64.encodeBlock accelerator/intrinsic

2020-11-01 Thread Dong Bo
Base64.encodeBlock stub is implemented for x86_64. We can also do the same thing for aarch64 with SIMD LD3/ST4/TBL. A basic idea can be found here: http://0x80.pl/articles/base64-simd-neon.html#encoding-quadwords. Patch passed jtreg tier1-3 tests with linux-aarch64-server-release build. Tests in

Re: RFR: 8255380: (zipfs) ZipFileSystem::readExtra can fail if zipinfo-time is not set to false [v3]

2020-11-01 Thread Lance Andersen
> Hi, > > Please review the fix for JDK-8255380 which addresses an issue when the Zip > file is > 4GB. Zip FS when processing the CEN extra data does not take into > account the fact that there is no specific order to how the extra data fields > are written. Info-ZIP writes the fields in a di

Re: RFR: 8255380: (zipfs) ZipFileSystem::readExtra can fail if zipinfo-time is not set to false [v2]

2020-11-01 Thread Lance Andersen
On Sun, 1 Nov 2020 23:44:53 GMT, Claes Redestad wrote: > Given the need to generate a 4Gb file on the fly I do feel this maybe ought > to be a manual test, or maybe there's some annotation to ensure it's not run > on systems with too little disk space (and no compatible zip). OK, I can make i

Re: RFR: 8255380: (zipfs) ZipFileSystem::readExtra can fail if zipinfo-time is not set to false [v2]

2020-11-01 Thread Claes Redestad
On Sun, 1 Nov 2020 23:41:43 GMT, Lance Andersen wrote: >>> To validate the test, requires info-zip which comes on Mac and linux. It is >>> not included with windows. There are no issues if the Zip is created via >>> java.util.zip or Zip FS >> >> Ah, gotcha. I see and understand the use of the

Re: RFR: 8255380: (zipfs) ZipFileSystem::readExtra can fail if zipinfo-time is not set to false [v2]

2020-11-01 Thread Lance Andersen
On Sun, 1 Nov 2020 23:04:47 GMT, Claes Redestad wrote: > > To validate the test, requires info-zip which comes on Mac and linux. It is > > not included with windows. There are no issues if the Zip is created via > > java.util.zip or Zip FS > > Ah, gotcha. I see and understand the use of the ex

Re: RFR: 8255380: (zipfs) ZipFileSystem::readExtra can fail if zipinfo-time is not set to false [v2]

2020-11-01 Thread Claes Redestad
On Sun, 1 Nov 2020 22:55:48 GMT, Lance Andersen wrote: > To validate the test, requires info-zip which comes on Mac and linux. It is > not included with windows. There are no issues if the Zip is created via > java.util.zip or Zip FS Ah, gotcha. I see and understand the use of the external zip

Re: RFR: 8255380: (zipfs) ZipFileSystem::readExtra can fail if zipinfo-time is not set to false [v2]

2020-11-01 Thread Lance Andersen
On Sun, 1 Nov 2020 22:21:25 GMT, Claes Redestad wrote: > LGTM. Some nits inline. > > I guess the test can be cause for issues in some test systems since it needs > to write out the 4Gb+ file. Is this why you've only enabled it on linux and > mac? Perhaps someone might have ideas on how to impr

Re: RFR: 8255380: (zipfs) ZipFileSystem::readExtra can fail if zipinfo-time is not set to false [v2]

2020-11-01 Thread Lance Andersen
> Hi, > > Please review the fix for JDK-8255380 which addresses an issue when the Zip > file is > 4GB. Zip FS when processing the CEN extra data does not take into > account the fact that there is no specific order to how the extra data fields > are written. Info-ZIP writes the fields in a di

Re: RFR: 8255380: (zipfs) ZipFileSystem::readExtra can fail if zipinfo-time is not set to false

2020-11-01 Thread Claes Redestad
On Sun, 1 Nov 2020 20:09:32 GMT, Lance Andersen wrote: > Hi, > > Please review the fix for JDK-8255380 which addresses an issue when the Zip > file is > 4GB. Zip FS when processing the CEN extra data does not take into > account the fact that there is no specific order to how the extra data f

RFR: 8255380: (zipfs) ZipFileSystem::readExtra can fail if zipinfo-time is not set to false

2020-11-01 Thread Lance Andersen
Hi, Please review the fix for JDK-8255380 which addresses an issue when the Zip file is > 4GB. Zip FS when processing the CEN extra data does not take into account the fact that there is no specific order to how the extra data fields are written. Info-ZIP writes the fields in a different orde

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator)

2020-11-01 Thread Alan Bateman
On Thu, 29 Oct 2020 14:13:40 GMT, Maurizio Cimadamore wrote: >>> @mcimadamore, if you pull from current master, you would get the Linux >>> x86_32 tier1 run "for free". >> >> Just did that - I also removed TestMismatch from the problem list in the >> latest iteration, and fixed the alignment

Withdrawn: 8186085: (opt) add filter(), flatMap(), and map() methods to OptionalDouble/Int/Long

2020-11-01 Thread Kartik Ohri
On Sun, 25 Oct 2020 10:49:01 GMT, Kartik Ohri wrote: > Hi all, > This PR intends to add filter, map and flatMap methods to the Optional > classes for primitives. The rationale is consistency with the Optional class > for objects and user convenience. > Thanks. > Regards, > Kartik This pull re

Re: RFR: 8186085: (opt) add filter(), flatMap(), and map() methods to OptionalDouble/Int/Long

2020-11-01 Thread Kartik Ohri
On Sun, 1 Nov 2020 14:27:41 GMT, Rémi Forax wrote: >> Thank you for the suggestions. I'll try fixing some bugs first. Should I >> close this PR as well or leave it open ? > > If it doesn't break your hart too much, yes please. Sure, no worries. I am new to the project and understand that it'll

Re: RFR: 8186085: (opt) add filter(), flatMap(), and map() methods to OptionalDouble/Int/Long

2020-11-01 Thread Rémi Forax
On Sun, 1 Nov 2020 13:20:20 GMT, Kartik Ohri wrote: >> Hi ! >> thanks for taking the time to craft that pull request but this is typically >> the kind of patch that should be discussed on the mailing list first before >> creating a pull request. >> >> There are several issues, one is that we

Re: RFR: 8186085: (opt) add filter(), flatMap(), and map() methods to OptionalDouble/Int/Long

2020-11-01 Thread Rémi Forax
On Sat, 31 Oct 2020 16:45:06 GMT, Kartik Ohri wrote: >> Hi all, >> This PR intends to add filter, map and flatMap methods to the Optional >> classes for primitives. The rationale is consistency with the Optional class >> for objects and user convenience. >> Thanks. >> Regards, >> Kartik > > Ki

Re: RFR: 8186085: (opt) add filter(), flatMap(), and map() methods to OptionalDouble/Int/Long

2020-11-01 Thread Kartik Ohri
On Sat, 31 Oct 2020 16:45:06 GMT, Kartik Ohri wrote: >> Hi all, >> This PR intends to add filter, map and flatMap methods to the Optional >> classes for primitives. The rationale is consistency with the Optional class >> for objects and user convenience. >> Thanks. >> Regards, >> Kartik > > Ki