Hello,
Thank you for your answer, I appreciate!
Indeed, it is clear to me that if the feature should be a concern of both
String and Stream (or more?), a common contract can be designed.
The impl. you sketch is the more natural one I think. (it's also the one I
gave in the other mailing grap
…AccessorImpl object
We met real problem when using protobuf with option optimized for code size,
detail in JBS https://bugs.openjdk.java.net/browse/JDK-8255883
Optimize solution is adding a new boolean field to detect concurrent method
accessor generation in same NativeMethodAccessorImpl
Hello!
> The min() and max() methods are not null hostile. If you pass a
> null-friendly comparator (such as returned by the `nullsFirst()` and
> `nullsLast()` comparator combinators), nulls are not a problem.
No, it is the problem, the same as with findFirst(). Try it:
Comparator nullFriendly
> This patch set encompasses the following commits:
>
> - Adds a new HotSpot intrinsic candidate to the java.lang.Base64 class -
> decodeBlock(), and provides a flexible API for the intrinsic. The API is
> similar to the existing encodeBlock intrinsic.
> - Adds the code in HotSpot to check and
On Wed, 4 Nov 2020 08:53:23 GMT, Zheka Kozlov
wrote:
>> This change introduces a new terminal operation on Stream. This looks like a
>> convenience method for Stream.collect(Collectors.toList()) or
>> Stream.collect(Collectors.toUnmodifiableList()), but it's not. Having this
>> method
On Wed, 4 Nov 2020 21:52:56 GMT, Rahul Yadav wrote:
> Hello,
>
> Request to review this small change, as HTML4 support has been dropped from
> javadoc.
> Have replaced valign="top" with style="vertical-align:top".
Marked as reviewed by mchung (Reviewer).
-
PR:
On Tue, 3 Nov 2020 01:33:32 GMT, Stuart Marks wrote:
> This change introduces a new terminal operation on Stream. This looks like a
> convenience method for Stream.collect(Collectors.toList()) or
> Stream.collect(Collectors.toUnmodifiableList()), but it's not. Having this
> method directly on
I wonder if we should not do the same with toList(), having toList() to be equivalent to
collect(Collectors.toUnmodifiableList()) and toList(IntFunction>)
allowing to use a null friendly List implementation like ArrayList.
If you pull on this string all the way, we end up with "let's just
> This patch set encompasses the following commits:
>
> - Adds a new HotSpot intrinsic candidate to the java.lang.Base64 class -
> decodeBlock(), and provides a flexible API for the intrinsic. The API is
> similar to the existing encodeBlock intrinsic.
> - Adds the code in HotSpot to check and
> Hi,
>
> Please review the changes for the subject issue. This is to enhance the
> java.time package to support day periods, such as "in the morning", defined
> in CLDR. It will add a new pattern character 'B' and its supporting builder
> method. The motivation and its spec are in this CSR:
>
Hello,
Request to review this small change, as HTML4 support has been dropped from
javadoc.
Have replaced valign="top" with style="vertical-align:top".
-
Commit messages:
- JDK-8255214 : Unsupported 'valign' attribute for 'th' tag used in
j.u.l.LogManager
Changes:
- Mail original -
> De: "Brian Goetz"
> À: "Tagir Valeev"
> Cc: "Remi Forax" , "Stuart Marks"
> , "core-libs-dev"
>
> Envoyé: Mercredi 4 Novembre 2020 18:58:59
> Objet: Re: RFR: 8180352: Add Stream.toList() method
>> As for nullity topic, I really welcome that the proposed toList() is
On Wed, 4 Nov 2020 18:44:33 GMT, Joe Wang wrote:
>> Changes requested by scolebourne (Author).
>
> Since 24:00 is not represented in for example LocalTime and H (hour-of-day)
> 0-23, it seems obvious midnight in the JDK would be 00:00, and the new
> DayPeriod tests proves that. The CLDR rule
On Tue, 13 Oct 2020 12:51:54 GMT, Andy Herrick wrote:
> JDK-8252870: Finalize (remove "incubator" from) jpackage
This pull request has now been integrated.
Changeset: 26e7ef78
Author:Andy Herrick
URL: https://git.openjdk.java.net/jdk/commit/26e7ef78
Stats: 1733 lines in 259
On Wed, 4 Nov 2020 14:51:06 GMT, Martin Doerr wrote:
> Thanks for removing the branch from the loop. (Maybe this affects unrolling
> decision.) Looks good.
Yeah, it does, and oddly enough the best loop unroll value is now 1. I will
re-run the benchmarks again to confirm, but that's what
On Mon, 2 Nov 2020 20:21:44 GMT, Jonathan Gibbons wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 46 commits:
>>
>> - Removing trailing whitespace.
>> - Merging master into JDK-8250768.
>> - Updating tests
> This is an update to javac and javadoc, to introduce support for Preview
> APIs, and generally improve javac and javadoc behavior to more closely adhere
> to JEP 12.
>
> The notable changes are:
>
> * adding support for Preview APIs (javac until now supported primarily only
> preview
On 04/11/2020 14:18, Justin Dekeyser wrote:
Hello everyone,
I have been following this mailing list for several months, and
earlier today my attention was drawn to
https://bugs.openjdk.java.net/browse/JDK-8140283. Actually I've been
dreaming of such a feature for a long time now.
I would
On Wed, 4 Nov 2020 01:34:13 GMT, Vipin Sharma wrote:
>> ... is replaced with {@code ...} in java.sql classes.
>> Please review and sponsor this change.
>
> Vipin Sharma has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated copyright year
> JDK-8252870: Finalize (remove "incubator" from) jpackage
Andy Herrick has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains seven commits:
- Merge branch 'master' into JDK-8252870
- Merge branch 'master' into JDK-8252870
- Merge
On Fri, 30 Oct 2020 11:42:49 GMT, Stephen Colebourne
wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed TCK test failures, added the new pattern char description in
>> DateTimeFormatter
>
> Changes requested by
Hello.
I would like to contribute for JDK-8250678.
The 'parse' method of ModuleDescriptor.Version class behaves incorrectly
when the input string contains consecutive delimiters.
The 'parse' method treats strings as three sections, but the parsing method
differs between the method for the
As for nullity topic, I really welcome that the proposed toList() is
null-tolerant but it worth mentioning that existing terminal
operations like findFirst(), findAny(), min() and max() are already
null-hostile.
The min() and max() methods are not null hostile. If you pass a
null-friendly
On Tue, 3 Nov 2020 23:55:24 GMT, Mandy Chung wrote:
> test/jdk/java/lang/invoke/defineHiddenClass/BasicTest.java tests a record
> class.
> This test no longer needs to be run with --enable-preview.
This pull request has now been integrated.
Changeset: 94ace035
Author:Mandy Chung
URL:
On Tue, 3 Nov 2020 23:56:34 GMT, Mandy Chung wrote:
> Record classes are now a standard feature in 16. @SuppressWarnings can be
> removed from sun.misc.Unsafe.
This pull request has now been integrated.
Changeset: 2da9981e
Author:Mandy Chung
URL:
On Wed, 4 Nov 2020 10:13:59 GMT, Kim Barrett wrote:
>> Hello!
>>
>> As an IDE developer, I'm thinking about IDE inspection that may suggest the
>> new method. My idea is to suggest replacing every `ref.get() == obj` with
>> `ref.refersTo(obj)`. Is this a good idea or there are cases when
On Tue, 3 Nov 2020 00:04:58 GMT, Brian Burkhalter wrote:
> InputStream::readNBytes() invokes read(byte[],int,int) repeatedly to load
> bytes into a sequence of intermediate arrays. If an intermediate array is not
> completely filled before being added to the list of arrays the contents of
>
On Tue, 3 Nov 2020 22:25:08 GMT, Magnus Ihse Bursie wrote:
> With clang 10.0, the compiler now detects a new class of warnings. The
> `misleading-indentation` warning has previously been disabled on gcc for
> hotspot and libfdlibm. Now we need to disable it for clang as well.
This pull
On Tue, 3 Nov 2020 23:56:34 GMT, Mandy Chung wrote:
> Record classes are now a standard feature in 16. @SuppressWarnings can be
> removed from sun.misc.Unsafe.
Marked as reviewed by chegar (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/1049
On Tue, 3 Nov 2020 23:55:24 GMT, Mandy Chung wrote:
> test/jdk/java/lang/invoke/defineHiddenClass/BasicTest.java tests a record
> class.
> This test no longer needs to be run with --enable-preview.
Marked as reviewed by chegar (Reviewer).
-
PR:
On Tue, 3 Nov 2020 03:01:09 GMT, CoreyAshford
wrote:
>> This patch set encompasses the following commits:
>>
>> - Adds a new HotSpot intrinsic candidate to the java.lang.Base64 class -
>> decodeBlock(), and provides a flexible API for the intrinsic. The API is
>> similar to the existing
On Tue, 3 Nov 2020 03:01:09 GMT, CoreyAshford
wrote:
>> This patch set encompasses the following commits:
>>
>> - Adds a new HotSpot intrinsic candidate to the java.lang.Base64 class -
>> decodeBlock(), and provides a flexible API for the intrinsic. The API is
>> similar to the existing
On Tue, 3 Nov 2020 23:55:24 GMT, Mandy Chung wrote:
> test/jdk/java/lang/invoke/defineHiddenClass/BasicTest.java tests a record
> class.
> This test no longer needs to be run with --enable-preview.
Marked as reviewed by rriggs (Reviewer).
-
PR:
On Tue, 3 Nov 2020 22:25:08 GMT, Magnus Ihse Bursie wrote:
> With clang 10.0, the compiler now detects a new class of warnings. The
> `misleading-indentation` warning has previously been disabled on gcc for
> hotspot and libfdlibm. Now we need to disable it for clang as well.
Marked as
> This is the current proposed patch for the upcoming JEP 394, for pattern
> matching for instanceof.
>
> A summary of changes:
> -making the feature permanent (non-preview)
> -making the binding variables non-final (as per current specification
> proposal)
> -producing a compile-time error for
Hello everyone,
I have been following this mailing list for several months, and
earlier today my attention was drawn to
https://bugs.openjdk.java.net/browse/JDK-8140283. Actually I've been
dreaming of such a feature for a long time now.
I would really be interested in solving it, but I do not
On Mon, 2 Nov 2020 19:59:10 GMT, Jonathan Gibbons wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 46 commits:
>>
>> - Removing trailing whitespace.
>> - Merging master into JDK-8250768.
>> - Updating tests
On Mon, 2 Nov 2020 19:41:08 GMT, Jonathan Gibbons wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 46 commits:
>>
>> - Removing trailing whitespace.
>> - Merging master into JDK-8250768.
>> - Updating tests
On Tue, 3 Nov 2020 23:56:34 GMT, Mandy Chung wrote:
> Record classes are now a standard feature in 16. @SuppressWarnings can be
> removed from sun.misc.Unsafe.
Looks okay. Given some of the changes in the pipeline then we might be want to
think about deprecating these methods soon too.
- Mail original -
> De: "Stuart Marks"
> À: "core-libs-dev"
> Envoyé: Mercredi 4 Novembre 2020 01:14:54
> Objet: Re: RFR: 8180352: Add Stream.toList() method
> On Tue, 3 Nov 2020 18:53:23 GMT, Stuart Marks wrote:
>
>>> Should there be a test that tests the default implementation in
On Mon, 2 Nov 2020 19:37:39 GMT, Jonathan Gibbons wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 46 commits:
>>
>> - Removing trailing whitespace.
>> - Merging master into JDK-8250768.
>> - Updating tests
On Mon, 2 Nov 2020 18:39:59 GMT, Jonathan Gibbons wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 46 commits:
>>
>> - Removing trailing whitespace.
>> - Merging master into JDK-8250768.
>> - Updating tests
On Wed, 4 Nov 2020 09:31:13 GMT, Tagir F. Valeev wrote:
> Hello!
>
> As an IDE developer, I'm thinking about IDE inspection that may suggest the
> new method. My idea is to suggest replacing every `ref.get() == obj` with
> `ref.refersTo(obj)`. Is this a good idea or there are cases when
Hello,
Ah that's a super good news, thanks a lot for sharing !
I dream of this since 2 years <3
Best regards,
Justin Dekeyser
On Wed, Nov 4, 2020 at 10:24 AM Tagir Valeev wrote:
>
> Hello!
>
> On Wed, Nov 4, 2020 at 4:16 PM Justin Dekeyser
> wrote:
> > What about trying to make the Stream
On Tue, 3 Nov 2020 01:33:32 GMT, Stuart Marks wrote:
> This change introduces a new terminal operation on Stream. This looks like a
> convenience method for Stream.collect(Collectors.toList()) or
> Stream.collect(Collectors.toUnmodifiableList()), but it's not. Having this
> method directly on
On Wed, 4 Nov 2020 09:31:13 GMT, Tagir F. Valeev wrote:
>> The API looks good, thanks for getting this in.
>
> Hello!
>
> As an IDE developer, I'm thinking about IDE inspection that may suggest the
> new method. My idea is to suggest replacing every `ref.get() == obj` with
>
On Wed, 28 Oct 2020 15:56:48 GMT, Alan Bateman wrote:
>> Kim Barrett has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> improve wording in refersTo javadoc
>
> The API looks good, thanks for getting this in.
Hello!
As an IDE developer,
On Wed, 4 Nov 2020 08:50:49 GMT, Zheka Kozlov
wrote:
>> This change introduces a new terminal operation on Stream. This looks like a
>> convenience method for Stream.collect(Collectors.toList()) or
>> Stream.collect(Collectors.toUnmodifiableList()), but it's not. Having this
>> method
Hello!
On Wed, Nov 4, 2020 at 4:16 PM Justin Dekeyser
wrote:
> What about trying to make the Stream interface *flexible* to users,
> instead of adding new functionalities that we could regret later?
> Then, as the language usages and the trends evolve, we could really
> see which of the "utils"
On Sun, 4 Oct 2020 03:59:59 GMT, Kim Barrett wrote:
> Finally returning to this review that was started in April 2020. I've
> recast it as a github PR. I think the security concern raised by Gil
> has been adequately answered.
>
On Tue, 3 Nov 2020 23:56:34 GMT, Mandy Chung wrote:
> Record classes are now a standard feature in 16. @SuppressWarnings can be
> removed from sun.misc.Unsafe.
Looks fine to me. I see there are Shenandoah-related failures in testing,
that's not the fault of this patch.
-
Marked
Hello,
I think the `collect(toList())` is interesting, as the developer
really knows that the internal operation is collect-like.
I say this because there would be another, much more functional
approach, that would be of the form
`stream.map(List::of).reduce(List.empty, List::concat)`,
(if ever
> Finally returning to this review that was started in April 2020. I've
> recast it as a github PR. I think the security concern raised by Gil
> has been adequately answered.
> https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2020-April/029203.html
>
On Tue, 3 Nov 2020 01:33:32 GMT, Stuart Marks wrote:
> This change introduces a new terminal operation on Stream. This looks like a
> convenience method for Stream.collect(Collectors.toList()) or
> Stream.collect(Collectors.toUnmodifiableList()), but it's not. Having this
> method directly on
Hello!
On Wed, Nov 4, 2020 at 2:55 AM Brian Goetz wrote:
> (In fact, we would be entirely justified to change the behavior of
> Collectors::toList tomorrow, to match the proposed Stream::toList; the
> spec was crafted to preserve this option. We probably won't, because
> there are too many
On Tue, 3 Nov 2020 01:33:32 GMT, Stuart Marks wrote:
> This change introduces a new terminal operation on Stream. This looks like a
> convenience method for Stream.collect(Collectors.toList()) or
> Stream.collect(Collectors.toUnmodifiableList()), but it's not. Having this
> method directly on
56 matches
Mail list logo
