On Tue, 15 Dec 2020 19:52:31 GMT, Andrey Turbanov
wrote:
>> 8258422: Cleanup unnecessary null comparison before instanceof check in
>> java.base
>
> Andrey Turbanov has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains two commits:
>
On Tue, 15 Dec 2020 23:14:14 GMT, Brent Christian wrote:
>> This is part of an effort in the JDK to replace archaic/non-inclusive words
>> with more neutral terms (see JDK-8253315 for details).
>>
>> Here are the changes covering core libraries code and tests. Terms were
>> changed as
On Wed, 16 Dec 2020 00:24:20 GMT, Alexey Semenyuk wrote:
> Ignore files created by prefs subsystem when checking if source runtime
> contains the same files as packed runtime.
Marked as reviewed by almatvee (Committer).
-
PR: https://git.openjdk.java.net/jdk16/pull/31
Ignore files created by prefs subsystem when checking if source runtime
contains the same files as packed runtime.
-
Commit messages:
- 8258293: tools/jpackage/share/RuntimePackageTest.java#id0 with
RuntimePackageTest.testUsrInstallDir2
Changes:
On Tue, 15 Dec 2020 23:14:14 GMT, Brent Christian wrote:
>> This is part of an effort in the JDK to replace archaic/non-inclusive words
>> with more neutral terms (see JDK-8253315 for details).
>>
>> Here are the changes covering core libraries code and tests. Terms were
>> changed as
On Thu, 10 Dec 2020 23:36:13 GMT, Brian Burkhalter wrote:
>> Please review this small verbiage change to specify clearly the behavior of
>> `Reader::read(char[] cbuf)` when the length of `cbuf` is zero, and that of
>> `Reader::read(char[] cbuf, int off, int len)` when `len` is zero.
>
> Brian
> This is part of an effort in the JDK to replace archaic/non-inclusive words
> with more neutral terms (see JDK-8253315 for details).
>
> Here are the changes covering core libraries code and tests. Terms were
> changed as follows:
> 1. grandfathered -> legacy
> 2. blacklist -> filter or
On Tue, 15 Dec 2020 22:13:58 GMT, Stuart Marks wrote:
>> It's an adverb, since it's the act of 'defining' that is being done too
>> restrictively or broadly. If you want to have an adjective you would need to
>> rephrase it so it applies to the noun, like 'defining a too restrictive
>>
On Thu, 10 Dec 2020 23:07:52 GMT, Naoto Sato wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Move to share/data, and move jdwp.spec to java.se
>
> Reviewed changes to `characterdata`, `charsetmapping`,
> A lot (but not all) of the data in make/data is tied to a specific module.
> For instance, the publicsuffixlist is used by java.base, and fontconfig by
> java.desktop. (A few directories, like mainmanifest, is *actually* used by
> make for the whole build.)
>
> These data files should move
On Tue, 15 Dec 2020 22:21:12 GMT, Brent Christian wrote:
>> This is part of an effort in the JDK to replace archaic/non-inclusive words
>> with more neutral terms (see JDK-8253315 for details).
>>
>> Here are the changes covering core libraries code and tests. Terms were
>> changed as
On Tue, 15 Dec 2020 22:21:12 GMT, Brent Christian wrote:
>> This is part of an effort in the JDK to replace archaic/non-inclusive words
>> with more neutral terms (see JDK-8253315 for details).
>>
>> Here are the changes covering core libraries code and tests. Terms were
>> changed as
> A lot (but not all) of the data in make/data is tied to a specific module.
> For instance, the publicsuffixlist is used by java.base, and fontconfig by
> java.desktop. (A few directories, like mainmanifest, is *actually* used by
> make for the whole build.)
>
> These data files should move
> This is part of an effort in the JDK to replace archaic/non-inclusive words
> with more neutral terms (see JDK-8253315 for details).
>
> Here are the changes covering core libraries code and tests. Terms were
> changed as follows:
> 1. grandfathered -> legacy
> 2. blacklist -> filter or
On Tue, 15 Dec 2020 09:17:03 GMT, Magnus Ihse Bursie wrote:
>> Your call, I'm not a native English speaker :-) It felt to me it's
>> 'restrictive' than 'restrictively', an adj placed after the noun, e.g. a
>> restrictive allow-list.
>
> It's an adverb, since it's the act of 'defining' that is
On Tue, 15 Dec 2020 21:57:17 GMT, Brian Burkhalter wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> updates, per code review
>
> test/jdk/java/lang/ClassLoader/Assert.java line 65:
>
>> 63:
>> 64: int
On Tue, 15 Dec 2020 22:02:00 GMT, Lance Andersen wrote:
>> test/jdk/java/lang/ClassLoader/Assert.java line 65:
>>
>>> 63:
>>> 64: int switchSource = 0;
>>> 65: if (args.length == 0) { // This is the coordinator version
>>
>> Perhaps s/coordinator/controller/?
>
> Let's change
On Tue, 15 Dec 2020 01:46:08 GMT, Brent Christian wrote:
>> This is part of an effort in the JDK to replace archaic/non-inclusive words
>> with more neutral terms (see JDK-8253315 for details).
>>
>> Here are the changes covering core libraries code and tests. Terms were
>> changed as
On Wed, 2 Dec 2020 17:34:00 GMT, Anton Kozlov wrote:
> Please review a small change that replaces use of objc_msgSend_stret in macOS
> platform code with pure ObjC code. It's also a prerequisite for macOS/AArch64
> support, where objc_msgSend_stret is not available.
Marked as reviewed by ihse
> 8258422: Cleanup unnecessary null comparison before instanceof check in
> java.base
Andrey Turbanov has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains
On Tue, 15 Dec 2020 19:28:15 GMT, Julia Boes wrote:
> This change is in line with upcoming changes in the JLS terminology ('type'
> versus 'class and interface').
>
> For background see:
> https://download.java.net/java/early_access/jdk16/docs/specs/class-terminology-jls.html
>
> For easier
This change is in line with upcoming changes in the JLS terminology ('type'
versus 'class and interface').
For background see:
https://download.java.net/java/early_access/jdk16/docs/specs/class-terminology-jls.html
For easier reviewing, paragraphs will only be reflowed before the PR is
On Sat, 31 Oct 2020 19:37:10 GMT, Stuart Marks wrote:
>> I believe this changes is useful and still actual:
>> 1. improve code to make it easier to read.
>> 2. performance should be improved a bit too
>
> I’ll see if I can get somebody to take a look at this.
This seems like a reasonable
On Wed, 2 Dec 2020 20:15:02 GMT, Andrey Turbanov
wrote:
>> This seems like a reasonable change, which improves readability.
>>
>> My preference is to wait a little longer (hopefully no more than a couple of
>> weeks), until [JEP 394](https://openjdk.java.net/jeps/394) - "Pattern
>> Matching
On Mon, 2 Nov 2020 09:15:31 GMT, Chris Hegarty wrote:
>> I’ll see if I can get somebody to take a look at this.
>
> This seems like a reasonable change, which improves readability.
>
> My preference is to wait a little longer (hopefully no more than a couple of
> weeks), until [JEP
On Sun, 4 Oct 2020 11:55:50 GMT, Andrey Turbanov
wrote:
>> 8258422: Cleanup unnecessary null comparison before instanceof check in
>> java.base
>
> I believe this changes is useful and still actual:
> 1. improve code to make it easier to read.
> 2. performance should be improved a bit too
8258422: Cleanup unnecessary null comparison before instanceof check in
java.base
-
Commit messages:
- [PATCH] Cleanup unnecessary null comparison before instanceof check in
java.base
Changes: https://git.openjdk.java.net/jdk/pull/20/files
Webrev:
On Sat, 5 Sep 2020 18:55:53 GMT, Andrey Turbanov
wrote:
> 8258422: Cleanup unnecessary null comparison before instanceof check in
> java.base
I believe this changes is useful and still actual:
1. improve code to make it easier to read.
2. performance should be improved a bit too
On Tue, 15 Dec 2020 07:32:12 GMT, Alan Bateman wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> updates, per code review
>
> test/jdk/java/nio/channels/SocketChannel/CloseRegisteredChannel.java line 45:
>
>>
> java.util.HexFormat utility:
>
> - Format and parse hexadecimal strings, with parameters for delimiter,
> prefix, suffix and upper/lowercase
> - Static factories and builder methods to create HexFormat copies with
> modified parameters.
> - Consistent naming of methods for conversion of
On Sun, 6 Dec 2020 22:12:54 GMT, Martin Buchholz wrote:
> 8254350: CompletableFuture.get may swallow InterruptedException
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.java.net/jdk/pull/1651
On Tue, 8 Dec 2020 07:53:17 GMT, Alan Bateman wrote:
>> Martin Buchholz has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR.
>
> Marked as reviewed by alanb
Hi Remi,
I raised a PR for improving the complexity of size() method of HeadMap/
TailMap https://github.com/openjdk/jdk/pull/1255 .
I am getting jcheck failed exception because of wrong commit message as it
is not yet assigned to any issue id. Could you please help here ?
Thanks.
On Sun, Nov 8,
See bug for details. Tested:
$ java -XX:+StressLdcRewrite -version
Error: VM option 'StressLdcRewrite' is diagnostic and must be enabled via
-XX:+UnlockDiagnosticVMOptions.
Error: The unlock option must precede 'StressLdcRewrite'.
Error: Could not create the Java Virtual Machine.
Error: A fatal
On Sat, 12 Dec 2020 18:40:16 GMT, Joe Darcy wrote:
> Given upcoming changes in the JLS terminology around the term "type", various
> sections were renamed:
>
>
> https://download.java.net/java/early_access/jdk16/docs/specs/class-terminology-jls.html
>
> The @jls tags in the java.base
On Mon, 14 Dec 2020 19:33:44 GMT, Alexey Semenyuk wrote:
> Adds support for "uninstall" parameter for exe uninstallers created by
> jpackage.
> Added logging and error reporting to exe uninstallers.
>
> - jpackage jni lib (jpackage.cpp): added functionality to extract ProductCode
> property
On Sat, 12 Dec 2020 18:40:16 GMT, Joe Darcy wrote:
> Given upcoming changes in the JLS terminology around the term "type", various
> sections were renamed:
>
>
> https://download.java.net/java/early_access/jdk16/docs/specs/class-terminology-jls.html
>
> The @jls tags in the java.base
On Mon, 14 Dec 2020 19:33:44 GMT, Alexey Semenyuk wrote:
> Adds support for "uninstall" parameter for exe uninstallers created by
> jpackage.
> Added logging and error reporting to exe uninstallers.
>
> - jpackage jni lib (jpackage.cpp): added functionality to extract ProductCode
> property
On Mon, 14 Dec 2020 14:46:41 GMT, Maurizio Cimadamore
wrote:
> This patch fixes a problem with type profile pollution when segments of
> different kinds are used on the same memory access var handle, or on the same
> `MemoryAccess` static method.
>
> In principle, argument profiling should
On Mon, 23 Nov 2020 19:58:20 GMT, Severin Gehwolf wrote:
>>> With respect to JDK-8255908, the changes look good to me.
>>
>> Thanks!
>
> @bobvandette Please review when you've got some cycles to spare. Much
> appreciated!
Ping? Anyone?
-
PR:
On Sun, 13 Dec 2020 00:19:59 GMT, Jonathan Gibbons wrote:
> This is for JDK16, as a precursor to fixing JDK-8258002.
>
> While it is good to be using localized strings in the generated output, the
> significance for JDK-8258002 is that the strings are now obtained from a
> resource file, and
On Sun, 13 Dec 2020 00:22:04 GMT, Jonathan Gibbons wrote:
>> This is for JDK16, as a precursor to fixing JDK-8258002.
>>
>> While it is good to be using localized strings in the generated output, the
>> significance for JDK-8258002 is that the strings are now obtained from a
>> resource file,
On Tue, 15 Dec 2020 01:41:07 GMT, Joe Wang wrote:
>> I agree that there is room for improvement here. How about:
>> "...an allow-list too restrictively, or a reject-list too broadly, may..."
>> ?
>
> Your call, I'm not a native English speaker :-) It felt to me it's
> 'restrictive' than
43 matches
Mail list logo
