Re: java.io.Console (was: Is SharedSecrets thread-safe?)

2021-01-04 Thread Alan Bateman
On 04/01/2021 23:09, Johannes Kuhn wrote: This brings up some stuff I wanted to mention for some time: * Console.cs is one of the fields projects like JRuby hack into (at least in the past). My guess is that they handle encodings in Ruby, and not using the Java facilities for that. The fact

Re: java.io.Console (was: Is SharedSecrets thread-safe?)

2021-01-04 Thread Johannes Kuhn
This brings up some stuff I wanted to mention for some time: * Console.cs is one of the fields projects like JRuby hack into (at least in the past). My guess is that they handle encodings in Ruby, and not using the Java facilities for that. The fact that it is also exported as shared secret

[jdk16] RFR: 8259213: Vector conversion with part > 0 is not getting intrinsic implementation

2021-01-04 Thread Sandhya Viswanathan
Vector conversion with part > 0 is implemented using slice(origin, vector) instead of slice(origin). The slice(origin) has intrinsic implementation whereas slice(origin, vector) doesn’t. Slice(origin) is written using vector API methods like rearrange and blend which all have intrinsic

Re: RFR: 4926314: Optimize Reader.read(CharBuffer)

2021-01-04 Thread Brian Burkhalter
On Thu, 31 Dec 2020 10:11:58 GMT, Philippe Marschall wrote: >> Implement three optimiztations for Reader.read(CharBuffer) >> >> * Add a code path for heap buffers in Reader#read to use the backing array >> instead of allocating a new one. >> * Change the code path for direct buffers in

Re: RFR: 8166026: Refactor java/lang shell tests to java [v4]

2021-01-04 Thread Roger Riggs
On Mon, 7 Dec 2020 20:15:29 GMT, Ivan Šipka wrote: >> Refactor `test/jdk/java/lang/Thread/UncaughtExceptions.sh` as java test. > > Ivan Šipka has updated the pull request incrementally with two additional > commits since the last revision: > > - 8166026: Refactor java/lang shell tests to java

Re: Is SharedSecrets thread-safe?

2021-01-04 Thread Peter Levart
Hello 99206970363698485155, Thanks for these pointers. I would prefer to untangle those knots one at a time, if you don't mind, since some of them touch other parts of code while this change to SharedSecrets is pretty straightforward and localized. Regards, Peter On 12/31/20 6:25 PM,

Re: RFR: 8257733: Move module-specific data from make to respective module [v4]

2021-01-04 Thread Phil Race
On Tue, 15 Dec 2020 22:56:15 GMT, Magnus Ihse Bursie wrote: >> A lot (but not all) of the data in make/data is tied to a specific module. >> For instance, the publicsuffixlist is used by java.base, and fontconfig by >> java.desktop. (A few directories, like mainmanifest, is *actually* used by

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v9]

2021-01-04 Thread Jim Laskey
> This PR is to introduce a new random number API for the JDK. The primary API > is found in RandomGenerator and RandomGeneratorFactory. Further description > can be found in the JEP https://openjdk.java.net/jeps/356 . > > javadoc can be found at >

Re: RFR: 8258878: (tz) Upgrade time-zone data to tzdata2020e

2021-01-04 Thread Erik Joelsson
On Mon, 4 Jan 2021 18:11:05 GMT, Kiran Sidhartha Ravikumar wrote: > Hi Guys, > > Please review the integration of tzdata2020e to JDK. > > Details regarding the change can be viewed at - > https://mm.icann.org/pipermail/tz-announce/2020-December/63.html > Bug:

Re: RFR: 8258878: (tz) Upgrade time-zone data to tzdata2020e

2021-01-04 Thread Naoto Sato
On Mon, 4 Jan 2021 18:11:05 GMT, Kiran Sidhartha Ravikumar wrote: > Hi Guys, > > Please review the integration of tzdata2020e to JDK. > > Details regarding the change can be viewed at - > https://mm.icann.org/pipermail/tz-announce/2020-December/63.html > Bug:

Re: RFR: 8259021: SharedSecrets should avoid double racy reads from non-volatile fields [v2]

2021-01-04 Thread Richard Reingruber
On Mon, 4 Jan 2021 14:27:09 GMT, Peter Levart wrote: >> See: https://bugs.openjdk.java.net/browse/JDK-8259021 >> See also discussion in thread: >> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-December/072798.html > > Peter Levart has updated the pull request incrementally with one

Re: RFR: 8259021: SharedSecrets should avoid double racy reads from non-volatile fields [v2]

2021-01-04 Thread Richard Reingruber
On Mon, 4 Jan 2021 17:45:25 GMT, Mandy Chung wrote: >> Peter Levart has updated the pull request incrementally with one additional >> commit since the last revision: >> >> revert the unrelated change > > Marked as reviewed by mchung (Reviewer). > > > _Mailing list message from [Hans

Re: RFR: 8259021: SharedSecrets should avoid double racy reads from non-volatile fields [v2]

2021-01-04 Thread Mandy Chung
On Mon, 4 Jan 2021 14:27:09 GMT, Peter Levart wrote: >> See: https://bugs.openjdk.java.net/browse/JDK-8259021 >> See also discussion in thread: >> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-December/072798.html > > Peter Levart has updated the pull request incrementally with one

Re: RFR: 4926314: Optimize Reader.read(CharBuffer) [v2]

2021-01-04 Thread Philippe Marschall
> Implement three optimiztations for Reader.read(CharBuffer) > > * Add a code path for heap buffers in Reader#read to use the backing array > instead of allocating a new one. > * Change the code path for direct buffers in Reader#read to limit the > intermediate allocation to

Re: RFR: 8259021: SharedSecrets should avoid double racy reads from non-volatile fields [v2]

2021-01-04 Thread Aleksey Shipilev
On Mon, 4 Jan 2021 14:27:09 GMT, Peter Levart wrote: >> See: https://bugs.openjdk.java.net/browse/JDK-8259021 >> See also discussion in thread: >> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-December/072798.html > > Peter Levart has updated the pull request incrementally with one

Re: RFR: 8259021: SharedSecrets should avoid double racy reads from non-volatile fields [v2]

2021-01-04 Thread Peter Levart
On Mon, 4 Jan 2021 15:57:33 GMT, Richard Reingruber wrote: >> The bug title and the PR title need to be the same. >> Editing either one is fine. > > But wouldn't it be legal for a compiler (java to bytecode or bytecode to > machinecode) to replace references of my_local_copy with references to >

Re: RFR: 8259021 avoid double racy reads from non-volatile fields of SharedSecrets [v2]

2021-01-04 Thread Richard Reingruber
On Mon, 4 Jan 2021 15:11:27 GMT, Roger Riggs wrote: >> Peter Levart has updated the pull request incrementally with one additional >> commit since the last revision: >> >> revert the unrelated change > > The bug title and the PR title need to be the same. > Editing either one is fine. But

Re: RFR: 8257733: Move module-specific data from make to respective module [v4]

2021-01-04 Thread Erik Joelsson
On Tue, 15 Dec 2020 22:56:15 GMT, Magnus Ihse Bursie wrote: >> A lot (but not all) of the data in make/data is tied to a specific module. >> For instance, the publicsuffixlist is used by java.base, and fontconfig by >> java.desktop. (A few directories, like mainmanifest, is *actually* used by

Re: RFR: JDK-8223322: Improve concurrency in jpackage instances [v2]

2021-01-04 Thread Andy Herrick
> Remove all non final static variables in jpackage java code (using > InheritableThreadLocal for Logger and Argument instances) and remove > sychronization in JPackageToolProvider. Andy Herrick has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8259021 avoid double racy reads from non-volatile fields of SharedSecrets [v2]

2021-01-04 Thread Roger Riggs
On Mon, 4 Jan 2021 14:27:09 GMT, Peter Levart wrote: >> See: https://bugs.openjdk.java.net/browse/JDK-8259021 >> See also discussion in thread: >> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-December/072798.html > > Peter Levart has updated the pull request incrementally with one

Re: RFR: 8259021 avoid double racy reads from non-volatile fields of SharedSecrets [v2]

2021-01-04 Thread Claes Redestad
On Mon, 4 Jan 2021 14:27:09 GMT, Peter Levart wrote: >> See: https://bugs.openjdk.java.net/browse/JDK-8259021 >> See also discussion in thread: >> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-December/072798.html > > Peter Levart has updated the pull request incrementally with one

Re: RFR: 8259021 avoid double racy reads from non-volatile fields of SharedSecrets [v2]

2021-01-04 Thread Peter Levart
> See: https://bugs.openjdk.java.net/browse/JDK-8259021 > See also discussion in thread: > https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-December/072798.html Peter Levart has updated the pull request incrementally with one additional commit since the last revision: revert the

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators

2021-01-04 Thread Jim Laskey
On Wed, 18 Nov 2020 13:45:12 GMT, Jim Laskey wrote: > This PR is to introduce a new random number API for the JDK. The primary API > is found in RandomGenerator and RandomGeneratorFactory. Further description > can be found in the JEP https://openjdk.java.net/jeps/356 . > > javadoc can be

Re: RFR: 8198540: Dynalink leaks memory when generating type converters [v3]

2021-01-04 Thread Peter Levart
On Sat, 2 Jan 2021 16:28:19 GMT, Johannes Kuhn wrote: >> Attila Szegedi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> jtreg runs with assertions on, so using the assert keyword is sufficient > > Just a small suggestion using

Re: RFR: 8259021 avoid double racy reads from non-volatile fields of SharedSecrets

2021-01-04 Thread Aleksey Shipilev
On Thu, 31 Dec 2020 10:02:01 GMT, Peter Levart wrote: > See: https://bugs.openjdk.java.net/browse/JDK-8259021 > See also discussion in thread: > https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-December/072798.html Looks good, but can we not do the behavioral change in