Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v13]

2021-01-07 Thread Jonathan Gibbons
On Fri, 8 Jan 2021 01:58:07 GMT, Jonathan Gibbons wrote: >> Jan Lahoda has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 57 commits: >> >> - Fixing tests after a merge. >> - Merging master into JDK-8250768 >> - Merging recent mas

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v13]

2021-01-07 Thread Jonathan Gibbons
On Thu, 7 Jan 2021 20:23:16 GMT, Jan Lahoda wrote: >> This is an update to javac and javadoc, to introduce support for Preview >> APIs, and generally improve javac and javadoc behavior to more closely >> adhere to JEP 12. >> >> The notable changes are: >> >> * adding support for Preview APIs

Re: RFR: 8259319: Illegal package access when SunPKCS11 requires SunJCE's classes

2021-01-07 Thread Sean Mullan
On Wed, 6 Jan 2021 15:33:59 GMT, Martin Balao wrote: > As described in JDK-8259319 [1], this fix proposal is to set proper access > permissions so the SunPKCS11 provider can create instances of SunJCE classes > when a Security Manager is installed and the fallback scheme is used. > > No regres

Integrated: Merge jdk16

2021-01-07 Thread Jesper Wilhelmsson
On Thu, 7 Jan 2021 20:40:49 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 16 -> JDK 17 This pull request has now been integrated. Changeset: 555641ed Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/555641ed Stats: 2957 lines in 68 files changed: 751 ins

RFR: Merge jdk16

2021-01-07 Thread Jesper Wilhelmsson
Forwardport JDK 16 -> JDK 17 - Commit messages: - Merge - 8249633: doclint reports missing javadoc for JavaFX property methods that have a property description - 8251200: False positive messages about missing comments for serialization - 8259312: VerifyCACerts.java fails as soner

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v12]

2021-01-07 Thread Jan Lahoda
On Wed, 9 Dec 2020 13:30:14 GMT, Magnus Ihse Bursie wrote: >> Jan Lahoda has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 55 commits: >> >> - Merging recent master changes into JDK-8250768 >> - Fixing navigator for the PREVIEW pa

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v13]

2021-01-07 Thread Jan Lahoda
> This is an update to javac and javadoc, to introduce support for Preview > APIs, and generally improve javac and javadoc behavior to more closely adhere > to JEP 12. > > The notable changes are: > > * adding support for Preview APIs (javac until now supported primarily only > preview langua

Re: RFR: 8259319: Illegal package access when SunPKCS11 requires SunJCE's classes

2021-01-07 Thread Valerie Peng
On Wed, 6 Jan 2021 15:33:59 GMT, Martin Balao wrote: > As described in JDK-8259319 [1], this fix proposal is to set proper access > permissions so the SunPKCS11 provider can create instances of SunJCE classes > when a Security Manager is installed and the fallback scheme is used. > > No regres

[jdk16] Integrated: 8039278: console.sh failed Automatically with exit code 1

2021-01-07 Thread Rajan Halade
On Thu, 7 Jan 2021 19:19:32 GMT, Rajan Halade wrote: > Reviewed-by: xuelei, weijun This pull request has now been integrated. Changeset: 1973fbee Author:Rajan Halade URL: https://git.openjdk.java.net/jdk16/commit/1973fbee Stats: 130 lines in 2 files changed: 0 ins; 129 del; 1 mod

[jdk16] Integrated: 8039278: console.sh failed Automatically with exit code 1

2021-01-07 Thread Rajan Halade
Reviewed-by: xuelei, weijun - Commit messages: - 8039278: console.sh failed Automatically with exit code 1 Changes: https://git.openjdk.java.net/jdk16/pull/93/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk16&pr=93&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK

Integrated: 8039278: console.sh failed Automatically with exit code 1

2021-01-07 Thread Rajan Halade
On Thu, 7 Jan 2021 18:26:12 GMT, Rajan Halade wrote: > 8039278: console.sh failed Automatically with exit code 1 This pull request has now been integrated. Changeset: 4ce83f2a Author:Rajan Halade URL: https://git.openjdk.java.net/jdk/commit/4ce83f2a Stats: 130 lines in 2 files ch

Re: RFR: 8039278: console.sh failed Automatically with exit code 1

2021-01-07 Thread Weijun Wang
On Thu, 7 Jan 2021 18:26:12 GMT, Rajan Halade wrote: > 8039278: console.sh failed Automatically with exit code 1 Marked as reviewed by weijun (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/1981

Re: RFR: 8039278: console.sh failed Automatically with exit code 1

2021-01-07 Thread Xue-Lei Andrew Fan
On Thu, 7 Jan 2021 18:26:12 GMT, Rajan Halade wrote: > 8039278: console.sh failed Automatically with exit code 1 Marked as reviewed by xuelei (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/1981

RFR: 8039278: console.sh failed Automatically with exit code 1

2021-01-07 Thread Rajan Halade
8039278: console.sh failed Automatically with exit code 1 - Commit messages: - 8039278: update TEST.groups to remove console.sh - 8039278: console.sh failed Automatically with exit code 1 Changes: https://git.openjdk.java.net/jdk/pull/1981/files Webrev: https://webrevs.openjdk.jav

Re: Monitoring wrapped ThreadPoolExecutor returned from Executors

2021-01-07 Thread Jason Mehrens
Hi Doug, What are your thoughts on promoting monitoring methods from TPE and or FJP to AbstractExecutorService? The default implementations could just return -1. An example precedent is OperatingSystemMXBean::getSystemLoadAverage. The Executors.DelegatedExecutorService could then be modified

Re: RFR: 8258588: MD5 MessageDigest in java.util.UUID should be cached

2021-01-07 Thread Claes Redestad
On Thu, 7 Jan 2021 16:39:48 GMT, Peter Levart wrote: >>> I have to say that introducing a ThreadLocal here seems like a step in the >>> wrong direction. With a ThreadLocal, if I read this correctly, a >>> MessageDigest will be cached with each thread that ever calls this API, and >>> it won't

Re: RFR: 8258588: MD5 MessageDigest in java.util.UUID should be cached

2021-01-07 Thread Peter Levart
On Sun, 20 Dec 2020 22:41:33 GMT, PROgrm_JARvis wrote: >>> I have to say that introducing a ThreadLocal here seems like a step in the >>> wrong direction. With a ThreadLocal, if I read this correctly, a >>> MessageDigest will be cached with each thread that ever calls this API, and >>> it won

Re: Monitoring wrapped ThreadPoolExecutor returned from Executors

2021-01-07 Thread Doug Lea
On 1/5/21 10:11 PM, Tommy Ludwig wrote: In the Micrometer project, we provide metrics instrumentation of `ExectorService`s. For `ThreadPoolExecutor`s, we track the number of completed tasks, active tasks, thread pool sizes, task queue size and remaining capacity via methods from `ThreadPoolExe