On Tue, 16 Feb 2021 17:20:37 GMT, Julia Boes wrote:
>> 8080272 Refactor I/O stream copying to use
>> InputStream.transferTo/readAllBytes and Files.copy
>
> Hi @turbanoff, I'm happy to sponsor but I see two comments by @marschall -
> have they been addressed?
> https://github.com/openjdk/jdk/pu
Noticed by some of Jon Gibbons's doc linting & checking tooling, this
changeset fixes two javadoc issues for BigDecimal's serialization-related
methods, improving the serial form page.
-
Commit messages:
- 8261940: Fix references to IOException in BigDecimal javadoc
Changes: http
On Fri, 12 Feb 2021 15:22:15 GMT, Roger Riggs wrote:
>
>
> The table is informative and should not be construed as specification.
> The wording "has supported" should be sufficient.
If this is not specification then doesn't that imply that any provider of any
version of OpenJDK would be free
> Hi all,
>
> ASN1Formatter.annotate should be able to throw an IOException according to
> this comment [1].
> But it fails to do so due to the return [2] in the finally block, which would
> swallow the IOException.
>
> Generally, it seems not good to put a return statement in a finally block
Hi all,
ASN1Formatter.annotate should be able to throw an IOException according to this
comment [1].
But it fails to do so due to the return [2] in the finally block, which would
swallow the IOException.
Generally, it seems not good to put a return statement in a finally block
because it would
On Wed, 17 Feb 2021 20:21:57 GMT, Naoto Sato wrote:
>> Please review this simple doc fix. A CSR will be filed accordingly.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Made the additional text an @apiNote
Marked as review
On Wed, 17 Feb 2021 23:10:57 GMT, Brian Burkhalter wrote:
>> Please review this minor specification update to highlight that
>> `File.renameTo(File)` does not modify the `File` instance on which the
>> method is invoked.
>
> Brian Burkhalter has updated the pull request incrementally with one
> Please review this minor specification update to highlight that
> `File.renameTo(File)` does not modify the `File` instance on which the method
> is invoked.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
6245663: Update copy
On Wed, 17 Feb 2021 22:12:06 GMT, Brian Burkhalter wrote:
>> Please review this minor specification update to highlight that
>> `File.renameTo(File)` does not modify the `File` instance on which the
>> method is invoked.
>
> Brian Burkhalter has updated the pull request incrementally with one
On Wed, 17 Feb 2021 22:24:53 GMT, Naoto Sato wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 6245663: Mention 'dest' parameter in the added doc
>
> src/java.base/share/classes/java/io/File.java line 1381:
>
>>
On Wed, 17 Feb 2021 22:12:06 GMT, Brian Burkhalter wrote:
>> Please review this minor specification update to highlight that
>> `File.renameTo(File)` does not modify the `File` instance on which the
>> method is invoked.
>
> Brian Burkhalter has updated the pull request incrementally with one
On Fri, 12 Feb 2021 02:50:35 GMT, Naoto Sato wrote:
> Please review this doc fix to j.l.Character, which now includes the table of
> the history of supported Unicode versions. A corresponding CSR will be filed
> accordingly.
This pull request has now been integrated.
Changeset: ea5bf45c
Autho
On Wed, 17 Feb 2021 22:04:38 GMT, Roger Riggs wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 6245663: Mention 'dest' parameter in the added doc
>
> src/java.base/share/classes/java/io/File.java line 1383:
>
>
> Please review this minor specification update to highlight that
> `File.renameTo(File)` does not modify the `File` instance on which the method
> is invoked.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
6245663: Mention 'de
On Wed, 17 Feb 2021 22:08:47 GMT, Brian Burkhalter wrote:
>> Please review this minor specification update to highlight that
>> `File.renameTo(File)` does not modify the `File` instance on which the
>> method is invoked.
>
> Brian Burkhalter has updated the pull request incrementally with one
Please review this minor specification update to highlight that
`File.renameTo(File)` does not modify the `File` instance on which the method
is invoked.
-
Commit messages:
- 6245663: (spec) File.renameTo(File) changes the file-system object, not the
File instance
Changes: https:
On Wed, 17 Feb 2021 20:04:33 GMT, Lance Andersen wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Made the additional text an @apiNote
>
> Hi Naoto,
>
> Looks good.
>
> Any thoughts to making the new wording stick
On Wed, 17 Feb 2021 20:18:56 GMT, Naoto Sato wrote:
>> Please review this simple doc fix. A CSR will be filed accordingly.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Made the additional text an @apiNote
Marked as review
On Wed, 17 Feb 2021 20:18:56 GMT, Naoto Sato wrote:
>> Please review this simple doc fix. A CSR will be filed accordingly.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Made the additional text an @apiNote
Marked as review
> Please review this simple doc fix. A CSR will be filed accordingly.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Made the additional text an @apiNote
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2616/file
On Wed, 17 Feb 2021 14:14:57 GMT, Claes Redestad wrote:
>> No? This unmodifiable set here just delegates call to the backing field `c`,
>> so all exceptions from `c`'s calls are just delegated, aren't they? The NPE
>> will still be thrown; it's just that the stack trace will be different (i.e.
On Wed, 17 Feb 2021 19:34:47 GMT, Naoto Sato wrote:
> Please review this simple doc fix. A CSR will be filed accordingly.
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2616
On Wed, 17 Feb 2021 19:34:47 GMT, Naoto Sato wrote:
> Please review this simple doc fix. A CSR will be filed accordingly.
Hi Naoto,
Looks good.
Any thoughts to making the new wording stick out more perhaps via a something
like "Note: Consider" and bolding "Note:"
Not sure if it is @
> Modify the `unmodifiable*` methods in `java.util.Collections` to be
> idempotent. That is, when given an immutable collection from
> `java.util.ImmutableCollections` or `java.util.Collections`, these methods
> will return the reference instead of creating a new immutable collection that
> wra
8261483: jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java failed with
"AssertionError: Should have GCd a method handle by now"
-
Commit messages:
- 8261483: Try to eliminate flakiness of the test by extending its allowed
runtime and reducing the memory
Changes: https://git.ope
On Wed, 17 Feb 2021 19:34:47 GMT, Naoto Sato wrote:
> Please review this simple doc fix. A CSR will be filed accordingly.
LGTM
-
Marked as reviewed by bpb (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2616
Please review this simple doc fix. A CSR will be filed accordingly.
-
Commit messages:
- 8261728: SimpleDateFormat should link to DateTimeFormatter
Changes: https://git.openjdk.java.net/jdk/pull/2616/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2616&range=00
Issue:
On Wed, 17 Feb 2021 18:24:39 GMT, Ian Graves wrote:
>> 2 remarks:
>> 1. MapN's entry set extends abstract set, whose `contains` is null-friendly
>> like
>> https://github.com/openjdk/jdk/blob/cb84539d56209a6687c4ec71a61fdbe6f06a46ea/src/java.base/share/classes/java/util/AbstractCollection.java#
On Wed, 17 Feb 2021 17:39:00 GMT, Naoto Sato wrote:
>> Please review this doc fix to j.l.Character, which now includes the table of
>> the history of supported Unicode versions. A corresponding CSR will be filed
>> accordingly.
>
> Naoto Sato has updated the pull request incrementally with one
On Wed, 17 Feb 2021 14:37:52 GMT, liach
wrote:
>> This sounds like an inconsistency between `Map1` and `MapN` that should
>> perhaps be considered a bug that needs fixing. /ping @stuart-marks
>
> 2 remarks:
> 1. MapN's entry set extends abstract set, whose `contains` is null-friendly
> like
>
> Modify the `unmodifiable*` methods in `java.util.Collections` to be
> idempotent. That is, when given an immutable collection from
> `java.util.ImmutableCollections` or `java.util.Collections`, these methods
> will return the reference instead of creating a new immutable collection that
> wra
On Wed, 17 Feb 2021 17:24:50 GMT, Claes Redestad wrote:
>> For static methods, since in java language you cannot declare static method
>> in instance inner classes, I'd say making them static makes more sense
>> language-wise. Also making them static reduces compiler synthetic instance
>> fiel
On Sat, 13 Feb 2021 21:30:12 GMT, Andrey Turbanov
wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added table of available algorithms.
>
> test/jdk/java/util/Random/RandomTestBsi1999.java line 227:
>
>> 225: st
> Please review this doc fix to j.l.Character, which now includes the table of
> the history of supported Unicode versions. A corresponding CSR will be filed
> accordingly.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Added a text
On Tue, 16 Feb 2021 22:27:12 GMT, Mandy Chung wrote:
> Update test/jdk/java/lang/reflect/callerCache/ReflectionCallerCacheTest.java
> to use ForceGC from test library which has additional instrumentation to
> diagnose problem. In addition, this will get the fix for JDK-8258007.
This pull req
> This PR is to introduce a new random number API for the JDK. The primary API
> is found in RandomGenerator and RandomGeneratorFactory. Further description
> can be found in the JEP https://openjdk.java.net/jeps/356 .
>
> javadoc can be found at
> http://cr.openjdk.java.net/~jlaskey/prng/doc/a
On Wed, 17 Feb 2021 16:35:02 GMT, liach
wrote:
>> I'll just revert them
>
> For static methods, since in java language you cannot declare static method
> in instance inner classes, I'd say making them static makes more sense
> language-wise. Also making them static reduces compiler synthetic i
On Wed, 17 Feb 2021 17:19:58 GMT, Alan Bateman wrote:
>> Great improvement! Looks good to me overall. I wondered about the changes in
>> JLA as Alan already mentioned.
>
>> Right, I'm not exactly sure why the more limited changes I attempted in
>> [5f4e87f](https://github.com/openjdk/jdk/commit
On Tue, 16 Feb 2021 19:51:21 GMT, Naoto Sato wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert rem assertions
>
> Great improvement! Looks good to me overall. I wondered about the changes in
> JLA as Alan a
> Non-static classes hold a link to their parent classes, which in many cases
> can be avoided.
Сергей Цыпанов has updated the pull request incrementally with one additional
commit since the last revision:
8261880: Remove static from declarations of Holder nested classes
-
Chang
On Wed, 17 Feb 2021 16:32:39 GMT, Сергей Цыпанов
wrote:
>> src/java.base/share/classes/java/lang/invoke/DelegatingMethodHandle.java
>> line 192:
>>
>>> 190:
>>> 191: /* Placeholder class for DelegatingMethodHandles generated ahead
>>> of time */
>>> 192: static final class Holder {}
On Wed, 17 Feb 2021 16:24:46 GMT, Claes Redestad wrote:
>> Сергей Цыпанов has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8261880: Remove static from declarations of Holder nested classes
>
> src/java.base/share/classes/java/lang/invoke/
On Tue, 16 Feb 2021 14:30:58 GMT, Сергей Цыпанов
wrote:
> Non-static classes hold a link to their parent classes, which in many cases
> can be avoided.
src/java.base/share/classes/java/lang/invoke/DelegatingMethodHandle.java line
192:
> 190:
> 191: /* Placeholder class for DelegatingMet
On Mon, 15 Feb 2021 17:45:32 GMT, Anton Kozlov wrote:
>> I'm not sure it can wait. This change turns already-messy code into
>> something significantly messier, to the extent that it's not really good
>> enough to go into mainline.
>
> The latest merge with JDK-8261071 should resolve the issue.
On Tue, 16 Feb 2021 06:24:05 GMT, Vladimir Kempik wrote:
>> This is when passing a float, yes? In the case where we have more float
>> arguments than n_float_register_parameters_c.
>> I don't understand why you think it's acceptable to bail in this case. Can
>> you explain, please?
>
> it's for
On Fri, 12 Feb 2021 09:18:10 GMT, Philippe Marschall
wrote:
>> Implement three optimiztations for Reader.read(CharBuffer)
>>
>> * Add a code path for heap buffers in Reader#read to use the backing array
>> instead of allocating a new one.
>> * Change the code path for direct buffers in Reader#
Non-static classes hold a link to their parent classes, which in many cases can
be avoided.
-
Commit messages:
- 8261880: Change nested classes in java.base to static nested classes where
possible
Changes: https://git.openjdk.java.net/jdk/pull/2589/files
Webrev: https://webrevs.o
On Wed, 17 Feb 2021 12:24:46 GMT, Daniel Fuchs wrote:
>> Evan Whelan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8252883: Remove ClassPathException copyright statement
>
> test/jdk/java/util/logging/FileHandlerAccessTest.java line 45
> Hi,
>
> Please review this fix for JDK-8252883. This handles the case when an
> AccessDeniedException is being thrown on Windows, due to a delay in deleting
> the lock file it is trying to write to.
>
> This fix passes all testing.
>
> Kind regards,
> Evan
Evan Whelan has updated the pull r
On Wed, 17 Feb 2021 14:21:37 GMT, Claes Redestad wrote:
>> src/java.base/share/classes/java/util/Collections.java line 1473:
>>
>>> 1471: public static Map unmodifiableMap(Map>> extends V> m) {
>>> 1472: if(m.getClass() == UnmodifiableMap.class ||
>>> 1473:m.getClass() =
On Wed, 17 Feb 2021 00:30:09 GMT, Michael Hixson
wrote:
>> Modify the `unmodifiable*` methods in `java.util.Collections` to be
>> idempotent. That is, when given an immutable collection from
>> `java.util.ImmutableCollections` or `java.util.Collections`, these methods
>> will return the refer
On Wed, 17 Feb 2021 02:27:57 GMT, liach
wrote:
>> src/java.base/share/classes/java/util/Collections.java line 1130:
>>
>>> 1128: public static Set unmodifiableSet(Set s) {
>>> 1129: if(s.getClass() == UnmodifiableSet.class ||
>>> 1130:s.getClass() == ImmutableCollection
Hello Raffaello,
I have added this comment from you, to that JDK-8259896 issue.
-Jaikiran
On 02/02/21 12:43 am, Raffaello Giulietti wrote:
Hi,
in my opinion, the reporter of [1] is right in requiring that
extraneous characters be discarded, even inside the padding.
Indeed, the first full p
On Tue, 2 Feb 2021 22:42:22 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/share/logging/logStream.hpp line 35:
>
>> 33: class LogStream : p
On Mon, 15 Feb 2021 16:21:53 GMT, Bernhard Urban-Forster
wrote:
>> This is the version of w^x on-demand switch implemented by microsoft guys.
>> This is enabled only for debug builds.
>> @lewurm could you comment here please
>
> Those values can be observed in the debugger, but aren't documente
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On Tue, 2 Feb 2021 21:51:56 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp line 31:
>
>> 29: #include
On Wed, 17 Feb 2021 11:50:05 GMT, Evan Whelan wrote:
>> Hi,
>>
>> Please review this fix for JDK-8252883. This handles the case when an
>> AccessDeniedException is being thrown on Windows, due to a delay in deleting
>> the lock file it is trying to write to.
>>
>> This fix passes all testing.
> Hi,
>
> Please review this fix for JDK-8252883. This handles the case when an
> AccessDeniedException is being thrown on Windows, due to a delay in deleting
> the lock file it is trying to write to.
>
> This fix passes all testing.
>
> Kind regards,
> Evan
Evan Whelan has updated the pull r
On Wed, 17 Feb 2021 07:37:42 GMT, David Holmes wrote:
>> Evan Whelan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8252883: Throw exception if exit code of child process is non-zero
>
> test/jdk/java/util/logging/FileHandlerAccessTest.
60 matches
Mail list logo
