On Sat, 6 Mar 2021 01:35:28 GMT, Craig Andrews
wrote:
>> `java.net.URLClassLoader.getResource` can throw an undocumented
>> `IllegalArgumentException`.
>>
>> According to the javadoc for the `getResource` and `findResource` methods,
>> neither should be throwing `IllegalArgumentException` -
On Fri, 5 Mar 2021 18:53:29 GMT, Claes Redestad wrote:
>> This patch refactors Locale.getDefault(Category) so that the volatile field
>> holding the Locale is typically only read once. This has a small performance
>> advantage, and might be more robust if initialization is racy.
>
> Claes
> `java.net.URLClassLoader.getResource` can throw an undocumented
> `IllegalArgumentException`.
>
> According to the javadoc for the `getResource` and `findResource` methods,
> neither should be throwing `IllegalArgumentException` - they should return
> null if the resource can't be resolved.
On Fri, 5 Mar 2021 23:35:46 GMT, Brent Christian wrote:
>> Craig Andrews has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new
On Fri, 5 Mar 2021 16:02:49 GMT, Craig Andrews
wrote:
>> `java.net.URLClassLoader.getResource` can throw an undocumented
>> `IllegalArgumentException`.
>>
>> According to the javadoc for the `getResource` and `findResource` methods,
>> neither should be throwing `IllegalArgumentException` -
On Fri, 5 Mar 2021 14:24:34 GMT, Claes Redestad wrote:
> This patch removes the CharacterData.isOtherUppercase and isOtherLowercase
> methods. It also exploits the fact that isOtherUppercase is always false for
> all codepoints in the CharacterDataLatin1 range for a small speed-up.
>
> I have
>
> But before that. Alan Bateman said to me that Loom project has much
> simpler implementation to what you want.
>
Ahh! Another good reason why I'm seriously considering just going to the
beach and returning once Loom is shipped! :-)
Can't do that. JIT have to update underlying hash table to
Eirik
See my answers bellow.
But before that. Alan Bateman said to me that Loom project has much simpler
implementation to what you want.
Thread local scopedCache which is Object[] array referenced from current thread:
On Thu, 4 Mar 2021 21:10:56 GMT, Craig Andrews
wrote:
>> Hi, Craig
>> The commented-out lines should be removed from the change.
>>
>> As Alan said, a regression test will be needed. At minimum, it should test
>> a method that returns a URL, as well as a method that returns an
>>
On Fri, Mar 5, 2021 at 6:41 PM Vladimir Kozlov
wrote:
Vladimir,
Thanks a lot for taking time to consider this! Some comments inline:
> Currently it is "impossible" for JIT compiler to reliably know that value
> stored by set() in hash map is the same as
> read by get().
>
My layman (perhaps
On Fri, 5 Mar 2021 18:53:29 GMT, Claes Redestad wrote:
>> This patch refactors Locale.getDefault(Category) so that the volatile field
>> holding the Locale is typically only read once. This has a small performance
>> advantage, and might be more robust if initialization is racy.
>
> Claes
> This patch refactors Locale.getDefault(Category) so that the volatile field
> holding the Locale is typically only read once. This has a small performance
> advantage, and might be more robust if initialization is racy.
Claes Redestad has updated the pull request incrementally with one
On Fri, 5 Mar 2021 17:29:16 GMT, Naoto Sato wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix omitted synchronized
>
> src/java.base/share/classes/java/util/Locale.java line 959:
>
>> 957: }
>> 958:
>>
On Fri, 5 Mar 2021 14:24:34 GMT, Claes Redestad wrote:
> This patch removes the CharacterData.isOtherUppercase and isOtherLowercase
> methods. It also exploits the fact that isOtherUppercase is always false for
> all codepoints in the CharacterDataLatin1 range for a small speed-up.
>
> I have
Hi Erik,
The implementation of ThreadLocal is based on HashMap:
https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/ThreadLocal.java#L76
Currently it is "impossible" for JIT compiler to reliably know that value stored by set() in hash map is the same as
read by
On Fri, 5 Mar 2021 14:14:14 GMT, Claes Redestad wrote:
> This patch refactors Locale.getDefault(Category) so that the volatile field
> holding the Locale is typically only read once. This has a small performance
> advantage, and might be more robust if initialization is racy.
On Fri, 5 Mar 2021 11:11:44 GMT, Alan Hayward
wrote:
>>> I was building this PR on a new machine, and I now get the following error:
>>>
>>> > /Users/alahay01/java/gerrit_jdk/src/java.desktop/macosx/native/libjsound/PLATFORM_API_MacOSX_MidiUtils.c:258:31:
>>> > error: cast to smaller integer
On Fri, 5 Mar 2021 14:24:34 GMT, Claes Redestad wrote:
> This patch removes the CharacterData.isOtherUppercase and isOtherLowercase
> methods. It also exploits the fact that isOtherUppercase is always false for
> all codepoints in the CharacterDataLatin1 range for a small speed-up.
>
> I have
On Fri, 5 Mar 2021 14:14:14 GMT, Claes Redestad wrote:
> This patch refactors Locale.getDefault(Category) so that the volatile field
> holding the Locale is typically only read once. This has a small performance
> advantage, and might be more robust if initialization is racy.
Marked as
On Fri, 5 Mar 2021 17:03:34 GMT, Claes Redestad wrote:
>> src/java.base/share/classes/java/util/Formatter.java line 3017:
>>
>>> 3015: s = ((Character)arg).toString();
>>> 3016: } else if (arg instanceof Byte) {
>>> 3017: byte i = (Byte) arg;
>>
>>
On Fri, 5 Mar 2021 16:36:03 GMT, Roger Riggs wrote:
>> This patch optimizes String.format expressions that uses trivial specifiers.
>> In the JDK, the most common variation of String.format is a variation of
>> format("foo: %s", s), which gets a significant speed-up from this.
>>
>> Various
On Thu, 4 Mar 2021 17:20:40 GMT, Claes Redestad wrote:
> This patch optimizes String.format expressions that uses trivial specifiers.
> In the JDK, the most common variation of String.format is a variation of
> format("foo: %s", s), which gets a significant speed-up from this.
>
> Various
On Fri, 5 Mar 2021 14:14:14 GMT, Claes Redestad wrote:
> This patch refactors Locale.getDefault(Category) so that the volatile field
> holding the Locale is typically only read once. This has a small performance
> advantage, and might be more robust if initialization is racy.
Results on the
This patch refactors Locale.getDefault(Category) so that the volatile field
holding the Locale is typically only read once. This has a small performance
advantage, and might be more robust if initialization is racy.
-
Commit messages:
- Add microbenchmark
- Reduce volatile reads
On Fri, 5 Mar 2021 15:46:40 GMT, Craig Andrews
wrote:
>> test/jdk/java/net/URLClassLoader/TestBug8262277.java line 30:
>>
>>> 28: * @summary Test to see if URLClassLoader.getResource and
>>> URLClassLoader.getResources
>>> 29: * throw IllegalArgumentException
>>> 30: */
>>
>> I'd prefer
On Fri, 5 Mar 2021 15:42:11 GMT, Alan Bateman wrote:
> I'd prefer if the test checked that findResource returned null and that
> findResources returned an empty enumeration.
I'll update the test accordingly.
> think we should be able to find a better name for the test too.
> Do you really
On Thu, 4 Mar 2021 22:16:10 GMT, Craig Andrews
wrote:
>> `java.net.URLClassLoader.getResource` can throw an undocumented
>> `IllegalArgumentException`.
>>
>> According to the javadoc for the `getResource` and `findResource` methods,
>> neither should be throwing `IllegalArgumentException` -
> `java.net.URLClassLoader.getResource` can throw an undocumented
> `IllegalArgumentException`.
>
> According to the javadoc for the `getResource` and `findResource` methods,
> neither should be throwing `IllegalArgumentException` - they should return
> null if the resource can't be resolved.
On Fri, 5 Mar 2021 14:24:34 GMT, Claes Redestad wrote:
> This patch removes the CharacterData.isOtherUppercase and isOtherLowercase
> methods. It also exploits the fact that isOtherUppercase is always false for
> all codepoints in the CharacterDataLatin1 range for a small speed-up.
>
> I have
This patch removes the CharacterData.isOtherUppercase and isOtherLowercase
methods. It also exploits the fact that isOtherUppercase is always false for
all codepoints in the CharacterDataLatin1 range for a small speed-up.
I have no means to test if this is correct on PPC, which has intrinsics
Hello,
I can contribute in solving the issue [1] mentioned in [2].
But before investing time, I just want to make sure that there is some
consensus that it needs to be solved in the first place. Maybe there are
diverging opinions that consider the current behavior as correct.
Greetings
On Thu, 4 Mar 2021 18:19:33 GMT, Vladimir Kempik wrote:
> Hello
> there is one issue with the info you provided, it's from Xcode12.5 beta.
> And beta license agreement forbids sharing output of beta version of
> compiler
> So we can't say we have issue with newer xcode beta until that beta went
32 matches
Mail list logo
