On Fri, 19 Mar 2021 18:41:51 GMT, Roger Riggs wrote:
>> Intermittent failures on Windows in a test of destroying the child warrant
>> extending the time the parent waits after starting the child before
>> destroying the child.
>
> Roger Riggs has updated the pull request incrementally with one
On Fri, 19 Mar 2021 17:57:31 GMT, Naoto Sato wrote:
> Fixed several broken links to Unicode.org.
This pull request has now been integrated.
Changeset: 96e5c3f1
Author:Naoto Sato
URL: https://git.openjdk.java.net/jdk/commit/96e5c3f1
Stats: 37 lines in 8 files changed: 4 ins; 0
On Sun, 14 Mar 2021 12:57:01 GMT, Alan Bateman wrote:
>> Philippe Marschall has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 15 commits:
>>
>> - Merge master
>> - Fix bug in CharArrayReader and add unit test
>> - Clean up unit
On Fri, 19 Mar 2021 21:23:03 GMT, Naoto Sato wrote:
>> Fixed several broken links to Unicode.org.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressed review comments.
Looks all good. Thanks Naoto.
-
On Fri, 19 Mar 2021 18:43:30 GMT, Joe Wang wrote:
> Some minor comments.
Thanks, Joe. Addressed them as suggested.
-
PR: https://git.openjdk.java.net/jdk/pull/3093
> Fixed several broken links to Unicode.org.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Addressed review comments.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3093/files
- new:
On Fri, 19 Mar 2021 18:23:00 GMT, Alex Blewitt
wrote:
> Additional changes found in `java.base` of `final private` -> `private
> final`. Filed with existing bug because it's the same module; can change to a
> different bug number if required.
This pull request has now been integrated.
On Fri, 19 Mar 2021 18:23:00 GMT, Alex Blewitt
wrote:
> Additional changes found in `java.base` of `final private` -> `private
> final`. Filed with existing bug because it's the same module; can change to a
> different bug number if required.
Marked as reviewed by redestad (Reviewer).
On Fri, 19 Mar 2021 15:27:00 GMT, Alex Blewitt
wrote:
> Fixes for the `java.sql`, `java.sql.rowset` and `java.transaction.xa`
> packages.
>
> @cl4es would you mind creating a subtask of JDK-8263854 so I can update the
> PR title?
This pull request has now been integrated.
Changeset:
On Fri, 19 Mar 2021 18:23:00 GMT, Alex Blewitt
wrote:
> Additional changes found in `java.base` of `final private` -> `private
> final`. Filed with existing bug because it's the same module; can change to a
> different bug number if required.
Marked as reviewed by iris (Reviewer).
On Sun, 14 Mar 2021 18:22:50 GMT, Ian Graves wrote:
> This converts jpackage to use `Stream.toList()` instead of
> `Stream.collect(Collectors.toList())`. One piece of code was modified to not
> mutate a list in addition to one test that used a mutating sort on a list.
> The rest of the
On Fri, 19 Mar 2021 15:27:00 GMT, Alex Blewitt
wrote:
> Fixes for the `java.sql`, `java.sql.rowset` and `java.transaction.xa`
> packages.
>
> @cl4es would you mind creating a subtask of JDK-8263854 so I can update the
> PR title?
Marked as reviewed by lancea (Reviewer).
-
PR:
On Fri, 19 Mar 2021 17:57:31 GMT, Naoto Sato wrote:
> Fixed several broken links to Unicode.org.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3093
On Fri, 19 Mar 2021 17:57:31 GMT, Naoto Sato wrote:
> Fixed several broken links to Unicode.org.
Some minor comments.
src/java.base/share/classes/java/text/Collator.java line 211:
> 209: * FULL_DECOMPOSITION corresponds to Normalization Form KD as
> 210: * described in
> 211: *
> Intermittent failures on Windows in a test of destroying the child warrant
> extending the time the parent waits after starting the child before
> destroying the child.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Clarify
On Fri, 19 Mar 2021 18:31:02 GMT, Naoto Sato wrote:
>> Additional changes found in `java.base` of `final private` -> `private
>> final`. Filed with existing bug because it's the same module; can change to
>> a different bug number if required.
>
> Marked as reviewed by naoto (Reviewer).
Can't
On Fri, 19 Mar 2021 18:23:00 GMT, Alex Blewitt
wrote:
> Additional changes found in `java.base` of `final private` -> `private
> final`. Filed with existing bug because it's the same module; can change to a
> different bug number if required.
Marked as reviewed by naoto (Reviewer).
Additional changes found in `java.base` of `final private` -> `private final`.
Filed with existing bug because it's the same module; can change to a different
bug number if required.
-
Commit messages:
- 8263658: Use the blessed modifier order in java.base
Changes:
On Fri, 19 Mar 2021 15:27:00 GMT, Alex Blewitt
wrote:
> Fixes for the `java.sql`, `java.sql.rowset` and `java.transaction.xa`
> packages.
>
> @cl4es would you mind creating a subtask of JDK-8263854 so I can update the
> PR title?
Marked as reviewed by redestad (Reviewer).
-
Fixes for the `java.sql`, `java.sql.rowset` and `java.transaction.xa` packages.
@cl4es would you mind creating a subtask of JDK-8263854 so I can update the PR
title?
-
Commit messages:
- Use the blessed modifier order in java.sql/rowset/transation.xa
Changes:
On Fri, 19 Mar 2021 15:27:00 GMT, Alex Blewitt
wrote:
> Fixes for the `java.sql`, `java.sql.rowset` and `java.transaction.xa`
> packages.
>
> @cl4es would you mind creating a subtask of JDK-8263854 so I can update the
> PR title?
8263885
-
PR:
On Fri, 19 Mar 2021 17:17:02 GMT, Roger Riggs wrote:
>> Intermittent failures on Windows in a test of destroying the child warrant
>> extending the time the parent waits after starting the child before
>> destroying the child.
>
> Roger Riggs has updated the pull request incrementally with one
On Fri, 19 Mar 2021 17:57:31 GMT, Naoto Sato wrote:
> Fixed several broken links to Unicode.org.
Marked as reviewed by redestad (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3093
Fixed several broken links to Unicode.org.
-
Commit messages:
- 8263890: Broken links to Unicode.org
Changes: https://git.openjdk.java.net/jdk/pull/3093/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=3093=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8263890
On Fri, 19 Mar 2021 17:13:58 GMT, Alex Blewitt
wrote:
>> As with #2993 changing the order of `final static` to `static final` for the
>> `java.management`, `java.management.rmi` and `java.naming` modules.
>
> Alex Blewitt has updated the pull request incrementally with one additional
> commit
On Fri, 19 Mar 2021 17:01:26 GMT, Roger Riggs wrote:
>> test/jdk/java/lang/ProcessBuilder/Basic.java line 2156:
>>
>>> 2154: case 1:
>>> 2155: childArgs.set(1,
>>> "-XX:+DisplayVMOutputToStdout");
>>> 2156:
On Fri, 19 Mar 2021 01:17:34 GMT, Alexey Semenyuk wrote:
>> Ian Graves has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains two commits:
>>
>> - Clarifying type argument and shorting a toArray invocation
>> - Converting jpackage to
> Intermittent failures on Windows in a test of destroying the child warrant
> extending the time the parent waits after starting the child before
> destroying the child.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Correct
> As with #2993 changing the order of `final static` to `static final` for the
> `java.management`, `java.management.rmi` and `java.naming` modules.
Alex Blewitt has updated the pull request incrementally with one additional
commit since the last revision:
Added more replacements of 'final
On Fri, 19 Mar 2021 16:54:43 GMT, Thomas Stuefe wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Redirect VM output away from stream under test
>
> test/jdk/java/lang/ProcessBuilder/Basic.java line 2156:
>
>> 2154:
On Fri, 19 Mar 2021 14:23:55 GMT, Roger Riggs wrote:
>> Intermittent failures on Windows in a test of destroying the child warrant
>> extending the time the parent waits after starting the child before
>> destroying the child.
>
> Roger Riggs has updated the pull request incrementally with one
> 8263763: The constructor of an enumeration prefixes with two synthetic
> arguments for constant name and ordinal index. For this reason, the
> constructor annotations need to be shifted two indices to the right, such
> that the annotation indices match with the parameter indices.
Rafael
On Fri, 19 Mar 2021 05:24:24 GMT, Joe Darcy wrote:
>> 8263763: The constructor of an enumeration prefixes with two synthetic
>> arguments for constant name and ordinal index. For this reason, the
>> constructor annotations need to be shifted two indices to the right, such
>> that the
> Intermittent failures on Windows in a test of destroying the child warrant
> extending the time the parent waits after starting the child before
> destroying the child.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Redirect VM
On Thu, 18 Mar 2021 18:26:20 GMT, Alex Blewitt
wrote:
> As with #2993 changing the order of `final static` to `static final` for the
> `java.management`, `java.management.rmi` and `java.naming` modules.
Overall good - found a few cases where the private modifier is in the wrong
place that
On Fri, 19 Mar 2021 13:28:12 GMT, Claes Redestad wrote:
>> Thanks @cl4es -- do I need to update the git commit message as well, or is
>> updating the title of the PR sufficient? I recall you suggesting not to do
>> amend/rebases previously.
>
> No, the git commit messages here doesn't matter,
On Fri, 19 Mar 2021 13:08:24 GMT, Alex Blewitt
wrote:
>> Created the subtask https://bugs.openjdk.java.net/browse/JDK-8263855 for
>> this along with an umbrella RFE.
>
> Thanks @cl4es -- do I need to update the git commit message as well, or is
> updating the title of the PR sufficient? I
On Fri, 19 Mar 2021 10:20:39 GMT, Alex Blewitt
wrote:
>> Would someone mind creating a bug for me? In addition, if it would help, we
>> could create a parent bug for applying cleanups and associate #2993 and
>> #2991.
>
> @cl4es would you mind creating a parent task of something like "Source
On Fri, 19 Mar 2021 11:01:45 GMT, Claes Redestad wrote:
>> @cl4es would you mind creating a parent task of something like "Source code
>> cleanups" and then another sub task for this change please?
>
> Created the subtask https://bugs.openjdk.java.net/browse/JDK-8263855 for this
> along with
On Thu, 18 Mar 2021 19:33:59 GMT, Alex Blewitt
wrote:
>> As with #2993 changing the order of `final static` to `static final` for the
>> `java.management`, `java.management.rmi` and `java.naming` modules.
>
> Would someone mind creating a bug for me? In addition, if it would help, we
> could
On Thu, 18 Mar 2021 18:26:20 GMT, Alex Blewitt
wrote:
> As with #2993 changing the order of `final static` to `static final` for the
> `java.management`, `java.management.rmi` and `java.naming` modules.
Would someone mind creating a bug for me? In addition, if it would help, we
could create
As with #2993 changing the order of `final static` to `static final` for the
`java.management`, `java.management.rmi` and `java.naming` modules.
-
Commit messages:
- Use the blessed modifier order in java.management/naming
Changes: https://git.openjdk.java.net/jdk/pull/3078/files
On Sat, 13 Mar 2021 22:45:30 GMT, Alex Blewitt
wrote:
> Sonar displays a warning message that modifiers should be declared in the
> order listed in the JLS; specifically, that isntead of using `final static`
> the `static final` should be preferred.
>
> This fixes the issues in the
On Thu, 18 Mar 2021 15:42:49 GMT, Claes Redestad wrote:
> MethodTypeForm.INTS, LONGS and RAW_RETURN are effectively unused. This
> removes these canonicalization codes and cleans up related code.
This pull request has now been integrated.
Changeset: 57497ab0
Author:Claes Redestad
URL:
> 4890732: GZIPOutputStream doesn't support, in fact thwarts, use of optional
> GZIP fields
Lin Zang has updated the pull request incrementally with two additional commits
since the last revision:
- update copyright
- reuse arguments constructor for non-argument one.
-
Changes:
> 4890732: GZIPOutputStream doesn't support, in fact thwarts, use of optional
> GZIP fields
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
add test case
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3072/files
On Thu, 18 Mar 2021 10:50:05 GMT, Lin Zang wrote:
>> 4890732: GZIPOutputStream doesn't support, in fact thwarts, use of optional
>> GZIP fields
>
> Dear All,
> This PR introduce new constructor of GZIPOutputStream to support adding extra
> field info in gzip file header, as decribed in RFC
47 matches
Mail list logo
