8264031: Fix typo in ZipFileSystem.deleteFile ZipException
-
Commit messages:
- ZipFileSystem: fix typo in ZipException
Changes: https://git.openjdk.java.net/jdk/pull/2588/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2588=00
Issue:
On Tue, 16 Feb 2021 13:48:20 GMT, Simon Legner
wrote:
> 8264031: Fix typo in ZipFileSystem.deleteFile ZipException
This looks good to me. Are you willing to continue with this PR? I see that OCA
is still pending. I have created the bug for this issue:
On Wed, 24 Mar 2021 19:01:04 GMT, Alexey Semenyuk wrote:
> Add support for `--about-url`, `--win-update-url` and `--win-help-url`
> parameters.
> Implementation for `--about-url` is provided on Windows only.
> This parameter may be supported on Linux as well.
>
On Wed, 24 Mar 2021 19:01:04 GMT, Alexey Semenyuk wrote:
> Add support for `--about-url`, `--win-update-url` and `--win-help-url`
> parameters.
> Implementation for `--about-url` is provided on Windows only.
> This parameter may be supported on Linux as well.
>
On Wed, 24 Mar 2021 19:01:04 GMT, Alexey Semenyuk wrote:
> Add support for `--about-url`, `--win-update-url` and `--win-help-url`
> parameters.
> Implementation for `--about-url` is provided on Windows only.
> This parameter may be supported on Linux as well.
>
Add support for --about-url, --win-update-url and --win-help-url parameters
-
Commit messages:
- Remove unused import-s
- 8220266: add support for additional metadata in add/remove programs
Changes: https://git.openjdk.java.net/jdk/pull/3178/files
Webrev:
On Mon, 22 Mar 2021 15:57:12 GMT, Jaroslav Bachorik
wrote:
> With this change it becomes possible to surface various cgroup level metrics
> (available via `jdk.internal.platform.Metrics`) as JFR events.
>
> Only a subset of the metrics exposed by `jdk.internal.platform.Metrics` is
> turned
On Tue, 23 Mar 2021 21:54:33 GMT, Pavel Rappo wrote:
>> I'm not sure how String.repeat can be used here. Repeated String is not
>> constant and different for each iteration.
>
> Long runs of whitespace, especially in blank strings, may have poor
> readability. I was thinking that
>
> "
Hi Zlatin,
There are no plans to deprecate "jpackage.app-path" system property. It
will be available in the next LTS release.
- Alexey
On 3/20/2021 1:25 PM, Zlatin Balevsky wrote:
Hi,
In my application I need to know the absolute path of the executable
generated by jpackage at runtime. I
On Mon, 22 Mar 2021 20:40:09 GMT, Andy Herrick wrote:
> JDK-8259926: Error in jpackage sample usage in the help text
This pull request has now been integrated.
Changeset: 5ca5962d
Author:Andy Herrick
URL: https://git.openjdk.java.net/jdk/commit/5ca5962d
Stats: 4 lines in 3 files
On Mon, 22 Mar 2021 13:03:10 GMT, Andy Herrick wrote:
> JDK-8263887: Re-create default icons
This pull request has now been integrated.
Changeset: 70d34017
Author:Andy Herrick
URL: https://git.openjdk.java.net/jdk/commit/70d34017
Stats: 32 lines in 2 files changed: 7 ins; 21
On Tue, 23 Mar 2021 08:04:09 GMT, Aleksei Voitylov
wrote:
>> With CDS and G1, test api/java_lang/ModuleLayer/Boot.html fails in JDK 16.
>>
>> After JDK-8253081 with CDS enabled two instances of empty layer appear in
>> the runtime. One comes from default initialization of
>>
On Mon, 22 Mar 2021 19:40:19 GMT, Aleksei Voitylov
wrote:
> With CDS and G1, test api/java_lang/ModuleLayer/Boot.html fails in JDK 16.
>
> After JDK-8253081 with CDS enabled two instances of empty layer appear in the
> runtime. One comes from default initialization of
>
On Tue, 23 Mar 2021 08:21:27 GMT, Alan Bateman wrote:
>> Aleksei Voitylov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fix style
>
> Marked as reviewed by alanb (Reviewer).
Thanks Ioi, David and Alan for your reviews!
-
On Wed, 24 Mar 2021 11:00:53 GMT, Andy Herrick wrote:
> Restoring fix to JDK-8248904: Add support to jpackage for the Mac App Store.
This pull request has now been integrated.
Changeset: deda80f0
Author:Andy Herrick
URL: https://git.openjdk.java.net/jdk/commit/deda80f0
Stats:
On Wed, 24 Mar 2021 11:00:53 GMT, Andy Herrick wrote:
> Restoring fix to JDK-8248904: Add support to jpackage for the Mac App Store.
Marked as reviewed by asemenyuk (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3172
On Mon, 22 Mar 2021 10:35:03 GMT, Mahendra Chhipa
wrote:
> https://bugs.openjdk.java.net/browse/JDK-8064681
the tests set a system property and then clear that system property at the end
of the test. Is it always the case that the property being set in the test
does not have a value prior
On Wed, 24 Mar 2021 09:56:16 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
In addition to the other suggestions, java.time could use
On Wed, 24 Mar 2021 09:56:16 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
LGTM. Thanks for the cleanup!
-
Marked as
- Mail original -
> De: "Michael Kuhlmann"
> À: "core-libs-dev"
> Envoyé: Mercredi 24 Mars 2021 13:23:08
> Objet: Re: RFR: 8263668: Update java.time to use instanceof pattern variable
> On 3/24/21 12:09 PM, Rémi Forax wrote:
>> On Wed, 24 Mar 2021 09:56:16 GMT, Patrick Concannon
>>
On Wed, 24 Mar 2021 09:56:16 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
LGTM!
-
Marked as reviewed by ryadav
> With this change it becomes possible to surface various cgroup level metrics
> (available via `jdk.internal.platform.Metrics`) as JFR events.
>
> Only a subset of the metrics exposed by `jdk.internal.platform.Metrics` is
> turned into JFR events to start with.
> * CPU related metrics
> *
On 3/24/21 12:09 PM, Rémi Forax wrote:
On Wed, 24 Mar 2021 09:56:16 GMT, Patrick Concannon
wrote:
Hi,
Could someone please review my code for updating the code in the `java.time`
package to make use of the `instanceof` pattern variable?
Kind regards,
Patrick
On Wed, 24 Mar 2021 11:00:53 GMT, Andy Herrick wrote:
> Restoring fix to JDK-8248904: Add support to jpackage for the Mac App Store.
I can confirm that this restores the fix for JDK-8248904. There are no diffs in
any jpackage file between the commit prior to the backout and this PR.
On Wed, 24 Mar 2021 09:56:16 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Restoring fix to JDK-8248904: Add support to jpackage for the Mac App Store.
-
Commit messages:
- JDK-8264057: [redo] JDK-8248904: Add support to jpackage for the Mac App
Store.
Changes: https://git.openjdk.java.net/jdk/pull/3172/files
Webrev:
On Wed, 24 Mar 2021 09:56:16 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
src/java.base/share/classes/java/time/LocalDateTime.java
> Can I please get a review for this patch which proposes to implement the
> enhancement request noted in https://bugs.openjdk.java.net/browse/JDK-8173970?
>
> The commit in this PR introduces the `-o` and `--output-dir` option to the
> `jar` command. The option takes a path to a destination
On Wed, 24 Mar 2021 09:56:16 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Changes look good Patrick.
-
Marked as
Based on the inputs so far, I've updated the PR to include the provided
feedback. Since the PR code review hadn't yet started, I decided to do a
force push to the PR so that we can start it afresh.
Command option:
In this current discussion, we seem to have an agreement for using -C
and
> With this change it becomes possible to surface various cgroup level metrics
> (available via `jdk.internal.platform.Metrics`) as JFR events.
>
> Only a subset of the metrics exposed by `jdk.internal.platform.Metrics` is
> turned into JFR events to start with.
> * CPU related metrics
> *
On Wed, 24 Mar 2021 06:51:16 GMT, Lin Zang wrote:
>> Hi Lin,
>>
>> Again, thank you for taking on this 19+ year feature request.
>>
>> I have not done a deep dive on the CSR, but wanted to get a few comments
>> back to you on a quick scan of the last PR update.
>>
>> Personally, I would
Hi,
Could someone please review my code for updating the code in the `java.time`
package to make use of the `instanceof` pattern variable?
Kind regards,
Patrick
-
Commit messages:
- Merge remote-tracking branch 'origin/master' into JDK-8263668
- 8263668: Update java.time to use
On Wed, 10 Mar 2021 12:59:18 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.lang`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
This pull request has now been integrated.
Changeset:
On Tue, 23 Mar 2021 21:41:32 GMT, Alex Blewitt
wrote:
> 8264091: Use the blessed modifier order in java.logging
This pull request has now been integrated.
Changeset: 45e1bab8
Author:Alex Blewitt
Committer: Aleksey Shipilev
URL: https://git.openjdk.java.net/jdk/commit/45e1bab8
On Tue, 23 Mar 2021 21:41:32 GMT, Alex Blewitt
wrote:
> 8264091: Use the blessed modifier order in java.logging
Marked as reviewed by shade (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3163
On Mon, 22 Mar 2021 21:37:27 GMT, Lance Andersen wrote:
>> Lin Zang has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - update copyright
>> - reuse arguments constructor for non-argument one.
>
> Hi Lin,
>
> Again, thank you for taking
On Wed, 24 Mar 2021 02:00:28 GMT, Iris Clark wrote:
>> 8264091: Use the blessed modifier order in java.logging
>
> Marked as reviewed by iris (Reviewer).
>
> On 24 Mar 2021, at 02:00, Iris Clark ***@***.***> wrote:
>
>
> @irisclark approved this pull request.
>
> —
> You are receiving this
38 matches
Mail list logo
