On Mon, 22 Mar 2021 20:18:37 GMT, Lance Andersen wrote:
>> Lin Zang has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - update copyright
>> - reuse arguments constructor for non-argument one.
>
>
On Mon, 22 Mar 2021 20:15:38 GMT, Lance Andersen wrote:
> on operating systems using
> EBCDIC or any other character set for file names, the name
> must be translated to the ISO LATIN-1 character set. This
> is the original name of the file being compressed, with any
>
On Mon, 22 Mar 2021 20:06:33 GMT, Lance Andersen wrote:
>> Lin Zang has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - update copyright
>> - reuse arguments constructor for non-argument one.
>
>
On Wed, 24 Mar 2021 10:25:44 GMT, Lance Andersen wrote:
>> Hi Lance，
>> Thanks a lot for your review. I will update the PR ASAP.
>> May I ask your help to also review the CSR？ Thanks!
>>
>> BRs,
>> Lin
>
> Hi Lin,
>
> On Mar 24, 2021, at 2:51 AM, Lin Zang ***@***.**@***.***>> wrote:
>
>
On Thu, 25 Mar 2021 22:58:53 GMT, Andy Herrick wrote:
>> implementation of
>> JDK-8256145: JEP 398: Deprecate the Applet API for Removal
>
> Andy Herrick has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
>
On Thu, 25 Mar 2021 22:58:53 GMT, Andy Herrick wrote:
>> implementation of
>> JDK-8256145: JEP 398: Deprecate the Applet API for Removal
>
> Andy Herrick has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
>
On Wed, 24 Mar 2021 18:39:06 GMT, Severin Gehwolf wrote:
>> With this change it becomes possible to surface various cgroup level metrics
>> (available via `jdk.internal.platform.Metrics`) as JFR events.
>>
>> Only a subset of the metrics exposed by `jdk.internal.platform.Metrics` is
>> turned
On Thu, 25 Mar 2021 22:58:53 GMT, Andy Herrick wrote:
>> implementation of
>> JDK-8256145: JEP 398: Deprecate the Applet API for Removal
>
> Andy Herrick has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
>
> implementation of
> JDK-8256145: JEP 398: Deprecate the Applet API for Removal
Andy Herrick has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains 301
On Wed, 17 Mar 2021 20:33:09 GMT, Andy Herrick wrote:
>>> I cannot find any instances where the scope can be narrowed
>>
>> Are you about AquaInternalFrameUI.mouseRelased, BasicPopupMenuUI.
>> stateChanged, and other non-trivial methods?
>
>>
>>
>> > I cannot find any instances where the
On Thu, 25 Mar 2021 21:50:46 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/sun/security/tools/keytool/Main.java line 4582:
>>
>>> 4580: int pos = 0;
>>> 4581: for (char c: value.toCharArray()) {
>>> 4582:
On Thu, 25 Mar 2021 21:05:47 GMT, Claes Redestad wrote:
>> A number of HexFormat methods converting from strings to numbers do not use
>> delimiter, prefix, suffix, and uppercase parameters and would be more
>> convenient if the methods were static.
>>
>> These APIs were added early in JDK
On Thu, 25 Mar 2021 20:08:14 GMT, Roger Riggs wrote:
> A number of HexFormat methods converting from strings to numbers do not use
> delimiter, prefix, suffix, and uppercase parameters and would be more
> convenient if the methods were static.
>
> These APIs were added early in JDK 17 and
On Thu, 25 Mar 2021 20:08:14 GMT, Roger Riggs wrote:
> A number of HexFormat methods converting from strings to numbers do not use
> delimiter, prefix, suffix, and uppercase parameters and would be more
> convenient if the methods were static.
>
> These APIs were added early in JDK 17 and
On Thu, 25 Mar 2021 19:30:01 GMT, Joe Darcy wrote:
> While some of the existing text in BigDecimal could be read as implying
> exponent overflow/underflow will throw an ArithmeticException, it is
> reasonable to simply state that explicitly.
>
> The next text is meant to cover the usage of
On Thu, 25 Mar 2021 19:55:44 GMT, Joe Darcy wrote:
>> While some of the existing text in BigDecimal could be read as implying
>> exponent overflow/underflow will throw an ArithmeticException, it is
>> reasonable to simply state that explicitly.
>>
>> The next text is meant to cover the usage
On Wed, 10 Mar 2021 18:33:37 GMT, Andy Herrick wrote:
> implementation of
> JDK-8256145: JEP 398: Deprecate the Applet API for Removal
src/java.desktop/share/classes/java/applet/package-info.java line 39:
> 37: * applet development environment.
> 38: *
> 39: * @deprecated. This package
A number of HexFormat methods converting from strings to numbers do not use
delimiter, prefix, suffix, and uppercase parameters and would be more
convenient if the methods were static.
These APIs were added early in JDK 17 and are being updated before GA.
This PR updates existing uses in the
> While some of the existing text in BigDecimal could be read as implying
> exponent overflow/underflow will throw an ArithmeticException, it is
> reasonable to simply state that explicitly.
>
> The next text is meant to cover the usage of the checkScale family of methods.
>
> I'll reflow the
On Thu, 25 Mar 2021 19:30:01 GMT, Joe Darcy wrote:
> While some of the existing text in BigDecimal could be read as implying
> exponent overflow/underflow will throw an ArithmeticException, it is
> reasonable to simply state that explicitly.
>
> The next text is meant to cover the usage of
While some of the existing text in BigDecimal could be read as implying
exponent overflow/underflow will throw an ArithmeticException, it is reasonable
to simply state that explicitly.
The next text is meant to cover the usage of the checkScale family of methods.
I'll reflow the existing
On Tue, 23 Mar 2021 16:33:50 GMT, Andrew Haley wrote:
>> Marked as reviewed by luhenry (Author).
>
>> > > > [ Back-porting this patch to JDK 11] depends on the will of openjdk11
>> > > > maintainers to accept this (and few other, like jep-388, as we depend
>> > > > on it) contribution.
>> > >
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On Fri, 22 Jan 2021 18:49:42 GMT, Anton Kozlov wrote:
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new
Please review the fix to the DST transition bug after the year 2037. The logic
had the side effect that it adjusted the dst offset every time the method
`getOffsets()` is issued. Only adjust the offset when issued with wall time.
-
Commit messages:
- Set time zone to the
> This PR is to introduce a new random number API for the JDK. The primary API
> is found in RandomGenerator and RandomGeneratorFactory. Further description
> can be found in the JEP https://openjdk.java.net/jeps/356 .
>
> javadoc can be found at
>
On Thu, 25 Mar 2021 13:27:45 GMT, Alexey Semenyuk wrote:
> Add missing escape single quote (') and typo fix
This pull request has now been integrated.
Changeset: 8307aa6d
Author:Alexey Semenyuk
URL: https://git.openjdk.java.net/jdk/commit/8307aa6d
Stats: 4 lines in 4 files
On Thu, 25 Mar 2021 13:27:45 GMT, Alexey Semenyuk wrote:
> Add missing escape single quote (') and typo fix
The original change in JDK-8220266 shows the introduction
of three single quotes and this fix addresses all three along
with another typo.
Thumbs up.
-
Marked as reviewed
On Thu, 25 Mar 2021 13:27:45 GMT, Alexey Semenyuk wrote:
> Add missing escape single quote (') and typo fix
Marked as reviewed by herrick (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3193
Add missing escape single quote (') and typo fix
-
Commit messages:
- 8264165: jpackage BasicTest fails after JDK-8220266: Check help text
contains plaform specific parameters
Changes: https://git.openjdk.java.net/jdk/pull/3193/files
Webrev:
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a rebase. The incremental
On Tue, 16 Feb 2021 13:48:20 GMT, Simon Legner
wrote:
> 8264031: Fix typo in ZipFileSystem.deleteFile ZipException
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2588
On Thu, 25 Mar 2021 06:13:28 GMT, Aleksey Shipilev wrote:
>> 8264031: Fix typo in ZipFileSystem.deleteFile ZipException
>
> Looks fine to me.
Note that the PR synopsis should now match the bug title, as bot says in
"Integration Blocker". I think "(zipfs)" is missing.
-
PR:
On Tue, 16 Feb 2021 13:48:20 GMT, Simon Legner
wrote:
> 8264031: Fix typo in ZipFileSystem.deleteFile ZipException
Looks fine to me.
-
Marked as reviewed by shade (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2588
34 matches
Mail list logo
