Re: RFR: 8256245: AArch64: Implement Base64 decoding intrinsic

2021-03-28 Thread Dong Bo
On Mon, 29 Mar 2021 03:15:57 GMT, Nick Gasson wrote: >> Firstly, I wonder how important this is for most applications. I don't >> actually know, but let's put that to one side. >> >> There's a lot of unrolling, particularly in the non-SIMD case. Please >> consider taking out some of the

Re: RFR: 8256245: AArch64: Implement Base64 decoding intrinsic

2021-03-28 Thread Dong Bo
On Mon, 29 Mar 2021 03:15:57 GMT, Nick Gasson wrote: >> Firstly, I wonder how important this is for most applications. I don't >> actually know, but let's put that to one side. >> >> There's a lot of unrolling, particularly in the non-SIMD case. Please >> consider taking out some of the

Re: RFR: 8256245: AArch64: Implement Base64 decoding intrinsic

2021-03-28 Thread Nick Gasson
On Sat, 27 Mar 2021 09:53:37 GMT, Andrew Haley wrote: > > There's a lot of unrolling, particularly in the non-SIMD case. Please > consider taking out some of the unrolling; I suspect it'd not increase time > by very much but would greatly reduce the code cache pollution. It's very > tempting

Re: RFR: 8256245: AArch64: Implement Base64 decoding intrinsic

2021-03-28 Thread Nick Gasson
On Sat, 27 Mar 2021 09:54:57 GMT, Andrew Haley wrote: >> In JDK-8248188, IntrinsicCandidate and API is added for Base64 decoding. >> Base64 decoding can be improved on aarch64 with ld4/tbl/tbx/st3, a basic >> idea can be found at >>

Re: RFR: 8256245: AArch64: Implement Base64 decoding intrinsic

2021-03-28 Thread Nick Gasson
On Sat, 27 Mar 2021 08:58:03 GMT, Dong Bo wrote: > In JDK-8248188, IntrinsicCandidate and API is added for Base64 decoding. > Base64 decoding can be improved on aarch64 with ld4/tbl/tbx/st3, a basic idea > can be found at > http://0x80.pl/articles/base64-simd-neon.html#encoding-quadwords. > >

Re: RFR: 4890732: GZIPOutputStream doesn't support, in fact thwarts, use of optional GZIP fields [v3]

2021-03-28 Thread Lance Andersen
On Mar 27, 2021, at 12:44 PM, Alan Bateman mailto:al...@openjdk.java.net>> wrote: Dear Lanceļ¼Œ Sorry that I reply so late, I got stuck at some work recently. * We should have tests that include some , but not all of the additional fields as I believe they are all optional according to the

Re: RFR: 8173970: jar tool should have a way to extract to a directory

2021-03-28 Thread Lance Andersen
On Mar 28, 2021, at 9:24 AM, Jaikiran Pai mailto:jai.forums2...@gmail.com>> wrote: Lance ran some tests against the proposed patch and that has exposed an area which we haven't yet taken into account for this feature. The jar tool has a (hidden) option "-P" which can be used with the "c"

Re: RFR: 8264334: Use the blessed modifier order in jdk.jpackage

2021-03-28 Thread Andy Herrick
On Sun, 28 Mar 2021 13:53:27 GMT, Alex Blewitt wrote: > 8264334: Use the blessed modifier order in jdk.jpackage Marked as reviewed by herrick (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3234

RFR: 8264334: Use the blessed modifier order in jdk.jpackage

2021-03-28 Thread Alex Blewitt
8264334: Use the blessed modifier order in jdk.jpackage - Commit messages: - 8264334: Use the blessed modifier order in jdk.jpackage Changes: https://git.openjdk.java.net/jdk/pull/3234/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=3234=00 Issue:

Re: RFR: 8264326: Modernize javax.script.ScriptEngineManager and related classes' implementation [v2]

2021-03-28 Thread Attila Szegedi
> I noticed that `javax.script.ScriptEngineManager` `getEngineByXxx` methods > had a lot of code duplication among themselves, and even within each method. > I refactored them into a modern unified implementation. While there I also > took the opportunity to introduce `Objects.requireNonNull`

Re: RFR: 8264326: Modernize javax.script.ScriptEngineManager and related classes' implementation [v2]

2021-03-28 Thread Attila Szegedi
On Sat, 27 Mar 2021 15:46:36 GMT, Alan Bateman wrote: >> Attila Szegedi has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains 13 new >>

Re: RFR: 8173970: jar tool should have a way to extract to a directory

2021-03-28 Thread Jaikiran Pai
Lance ran some tests against the proposed patch and that has exposed an area which we haven't yet taken into account for this feature. The jar tool has a (hidden) option "-P" which can be used with the "c" (create), "u" (update) and "x" (extract) main operations. When this -P option is used,