Re: RFR: 8264109: Add vectorized implementation for VectorMask.andNot() [v2]

2021-04-01 Thread Xiaohong Gong
On Thu, 1 Apr 2021 15:13:31 GMT, Paul Sandoz wrote: >> Xiaohong Gong has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Move the changing to AbstractMask.andNot and revert changes in VectorMask >> >> Change-Id:

Re: RFR: 8256245: AArch64: Implement Base64 decoding intrinsic [v3]

2021-04-01 Thread Dong Bo
> In JDK-8248188, IntrinsicCandidate and API is added for Base64 decoding. > Base64 decoding can be improved on aarch64 with ld4/tbl/tbx/st3, a basic idea > can be found at > http://0x80.pl/articles/base64-simd-neon.html#encoding-quadwords. > > Patch passed jtreg tier1-3 tests with

Integrated: 8205502: Make exception message from AnnotationInvocationHandler more informative

2021-04-01 Thread Joe Darcy
On Thu, 1 Apr 2021 22:15:01 GMT, Joe Darcy wrote: > Simple change to make the exception/error messages more informative for > various malformed annotation situations. This pull request has now been integrated. Changeset: 66d9961c Author:Joe Darcy URL:

Re: RFR: 8205502: Make exception message from AnnotationInvocationHandler more informative

2021-04-01 Thread Iris Clark
On Thu, 1 Apr 2021 22:15:01 GMT, Joe Darcy wrote: > Simple change to make the exception/error messages more informative for > various malformed annotation situations. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3317

Re: RFR: 8264544: Case-insensitive comparison issue with supplementary characters.

2021-04-01 Thread Iris Clark
On Thu, 1 Apr 2021 03:24:04 GMT, Naoto Sato wrote: > Please review the fix to the subject issue. Thanks to the contribution by > Chris Johnson. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3300

Re: RFR: 8264544: Case-insensitive comparison issue with supplementary characters.

2021-04-01 Thread Joe Wang
On Thu, 1 Apr 2021 03:24:04 GMT, Naoto Sato wrote: > Please review the fix to the subject issue. Thanks to the contribution by > Chris Johnson. Marked as reviewed by joehw (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3300

Re: RFR: 8205502: Make exception message from AnnotationInvocationHandler more informative

2021-04-01 Thread Naoto Sato
On Thu, 1 Apr 2021 22:15:01 GMT, Joe Darcy wrote: > Simple change to make the exception/error messages more informative for > various malformed annotation situations. Marked as reviewed by naoto (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3317

Re: RFR: 8205502: Make exception message from AnnotationInvocationHandler more informative

2021-04-01 Thread Brian Burkhalter
On Thu, 1 Apr 2021 22:15:01 GMT, Joe Darcy wrote: > Simple change to make the exception/error messages more informative for > various malformed annotation situations. Looks fine. - Marked as reviewed by bpb (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3317

RFR: 8205502: Make exception message from AnnotationInvocationHandler more informative

2021-04-01 Thread Joe Darcy
Simple change to make the exception/error messages more informative for various malformed annotation situations. - Commit messages: - Appease jcheck. - 8205502: Make exception message from AnnotationInvocationHandler more informative Changes:

Re: RFR: 8037397: Lost nested character class after intersection && [v2]

2021-04-01 Thread Ian Graves
> Bug fix with the intersection `&&` operator in regex patterns. In > JDK-8037397, some character classes on the right hand side of the operator > are dropped in cases where nested `[..]` classes are used with non "nested" > ones. Ian Graves has updated the pull request incrementally with one

RFR: 8264544: Case-insensitive comparison issue with supplementary characters.

2021-04-01 Thread Naoto Sato
Please review the fix to the subject issue. Thanks to the contribution by Chris Johnson. - Commit messages: - 8264544: Case-insensitive comparison issue with supplementary characters. Changes: https://git.openjdk.java.net/jdk/pull/3300/files Webrev:

Integrated: JDK-8264403: [macos]: App names containing '.' characters results in an error message when launching

2021-04-01 Thread Andy Herrick
On Wed, 31 Mar 2021 19:30:10 GMT, Andy Herrick wrote: > Deriving the cfg file name is broken on mac and linux when the application > name has a "." in it. This pull request has now been integrated. Changeset: 04f24fe9 Author:Andy Herrick URL:

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v41]

2021-04-01 Thread Jim Laskey
> This PR is to introduce a new random number API for the JDK. The primary API > is found in RandomGenerator and RandomGeneratorFactory. Further description > can be found in the JEP https://openjdk.java.net/jeps/356 . > > javadoc can be found at >

Integrated: 8264609 : Number.{byteValue, shortValue} spec should use @implSpec

2021-04-01 Thread Joe Darcy
On Thu, 1 Apr 2021 18:12:43 GMT, Joe Darcy wrote: > Please review this small code change and its accompanying CSR: > > https://bugs.openjdk.java.net/browse/JDK-8264610 This pull request has now been integrated. Changeset: b953386d Author:Joe Darcy URL:

Re: RFR: 8264288: Performance issue with MethodHandle.asCollector

2021-04-01 Thread Jorn Vernee
On Thu, 1 Apr 2021 19:09:53 GMT, John R Rose wrote: >> This patch speeds up MethodHandle.asCollector handles where the array type >> is not Object[], as well as speeding up all collectors where the arity is >> greater than 10. >> >> The old code is creating a collector handle by combining a

Re: RFR: 8264610: Number.{byteValue, shortValue} spec should use @implSpec

2021-04-01 Thread Brian Burkhalter
On Thu, 1 Apr 2021 18:12:43 GMT, Joe Darcy wrote: > Please review this small code change and its accompanying CSR: > > https://bugs.openjdk.java.net/browse/JDK-8264610 CSR also reviewed. - Marked as reviewed by bpb (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3314

Re: RFR: 8264288: Performance issue with MethodHandle.asCollector

2021-04-01 Thread Jorn Vernee
On Thu, 1 Apr 2021 19:09:14 GMT, John R Rose wrote: >> This patch speeds up MethodHandle.asCollector handles where the array type >> is not Object[], as well as speeding up all collectors where the arity is >> greater than 10. >> >> The old code is creating a collector handle by combining a

Re: RFR: 8264288: Performance issue with MethodHandle.asCollector

2021-04-01 Thread Jorn Vernee
On Thu, 1 Apr 2021 19:12:42 GMT, Paul Sandoz wrote: >> This patch speeds up MethodHandle.asCollector handles where the array type >> is not Object[], as well as speeding up all collectors where the arity is >> greater than 10. >> >> The old code is creating a collector handle by combining a

Re: RFR: 8264610: Number.{byteValue, shortValue} spec should use @implSpec

2021-04-01 Thread Paul Sandoz
On Thu, 1 Apr 2021 18:12:43 GMT, Joe Darcy wrote: > Please review this small code change and its accompanying CSR: > > https://bugs.openjdk.java.net/browse/JDK-8264610 Marked as reviewed by psandoz (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3314

Re: RFR: 8264288: Performance issue with MethodHandle.asCollector

2021-04-01 Thread Paul Sandoz
On Thu, 1 Apr 2021 13:25:05 GMT, Jorn Vernee wrote: > This patch speeds up MethodHandle.asCollector handles where the array type is > not Object[], as well as speeding up all collectors where the arity is > greater than 10. > > The old code is creating a collector handle by combining a set of

Re: RFR: 8264288: Performance issue with MethodHandle.asCollector

2021-04-01 Thread John R Rose
On Thu, 1 Apr 2021 13:25:05 GMT, Jorn Vernee wrote: > This patch speeds up MethodHandle.asCollector handles where the array type is > not Object[], as well as speeding up all collectors where the arity is > greater than 10. > > The old code is creating a collector handle by combining a set of

Re: RFR: 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28

2021-04-01 Thread Jim Laskey
On Thu, 1 Apr 2021 18:19:35 GMT, Alan Bateman wrote: >> We should never close the jimage since java threads can still be running >> after a hard exit(). > > src/java.base/share/native/libjimage/imageFile.cpp line 219: > >> 217: // WARNING: Should never close the jimage file. >> 218: //

Re: RFR: 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28

2021-04-01 Thread Alan Bateman
On Thu, 1 Apr 2021 11:48:21 GMT, Jim Laskey wrote: > We should never close the jimage since java threads can still be running > after a hard exit(). src/java.base/share/native/libjimage/imageFile.cpp line 219: > 217: // WARNING: Should never close the jimage file. > 218: // Threads

RFR: 8264610: Number.{byteValue, shortValue} spec should use @implSpec

2021-04-01 Thread Joe Darcy
Please review this small code change and its accompanying CSR: https://bugs.openjdk.java.net/browse/JDK-8264610 - Commit messages: - Update second method. - 8264609: Number.shortValue spec should use @implSpec Changes: https://git.openjdk.java.net/jdk/pull/3314/files Webrev:

Re: RFR: 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28

2021-04-01 Thread Ioi Lam
On Thu, 1 Apr 2021 11:48:21 GMT, Jim Laskey wrote: > We should never close the jimage since java threads can still be running > after a hard exit(). LGTM. - Marked as reviewed by iklam (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3304

RFR: 8264288: Performance issue with MethodHandle.asCollector

2021-04-01 Thread Jorn Vernee
This patch speeds up MethodHandle.asCollector handles where the array type is not Object[], as well as speeding up all collectors where the arity is greater than 10. The old code is creating a collector handle by combining a set of hard coded methods for collecting arguments into an Object[],

Integrated: 8169629: Annotations with lambda expressions cause AnnotationFormatError

2021-04-01 Thread Joe Darcy
On Wed, 31 Mar 2021 21:32:35 GMT, Joe Darcy wrote: > The stricter checks added by > 8035781: Improve equality for annotations > in creating the proxy objects used to implement annotations has an unintended > by-catch of rejecting annotation's whose type has, say, a field initialized > with

Re: RFR: 8169629: Annotations with lambda expressions cause AnnotationFormatError [v2]

2021-04-01 Thread Joe Darcy
> The stricter checks added by > 8035781: Improve equality for annotations > in creating the proxy objects used to implement annotations has an unintended > by-catch of rejecting annotation's whose type has, say, a field initialized > with a lambda expression. While uncommon, it is legal

Re: RFR: 8169629: Annotations with lambda expressions cause AnnotationFormatError [v2]

2021-04-01 Thread Joe Darcy
On Thu, 1 Apr 2021 12:36:56 GMT, Joel Borggrén-Franck wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Respond to review feedback. > >

Re: RFR: 8203359: Container level resources events

2021-04-01 Thread Jaroslav Bachorik
On Fri, 26 Mar 2021 11:05:56 GMT, Severin Gehwolf wrote: >> Does each getter call result in parsing /proc, or do things aggregated over >> several calls or hooks? >> >> Do you have any data how expensive the invocations are? >> >> You could for example try to measure it by temporary making

Re: RFR: 8264048: Fix caching in Jar URL connections when an entry is missing [v2]

2021-04-01 Thread Daniel Fuchs
On Wed, 31 Mar 2021 12:47:50 GMT, Aleksei Efimov wrote: >> Current fix tries to tackle an issue with URL connection referencing >> non-existing Jar file entries: >> If an entry that doesn't exist is specified in an URL connection the >> underlying Jar file is still cached even if an exception

Re: RFR: 8203359: Container level resources events [v4]

2021-04-01 Thread Jaroslav Bachorik
> With this change it becomes possible to surface various cgroup level metrics > (available via `jdk.internal.platform.Metrics`) as JFR events. > > Only a subset of the metrics exposed by `jdk.internal.platform.Metrics` is > turned into JFR events to start with. > * CPU related metrics > *

Re: RFR: 8264109: Add vectorized implementation for VectorMask.andNot() [v2]

2021-04-01 Thread Paul Sandoz
On Thu, 1 Apr 2021 03:39:43 GMT, Xiaohong Gong wrote: >> Currently "VectorMask.andNot()" is not vectorized: >> public VectorMask andNot(VectorMask m) { >> // FIXME: Generate good code here. >> return bOp(m, (i, a, b) -> a && !b); >> } >> This can be implemented with`

Re: RFR: 8173970: jar tool should have a way to extract to a directory [v3]

2021-04-01 Thread Jaikiran Pai
On Wed, 31 Mar 2021 17:22:55 GMT, Lance Andersen wrote: >> Jaikiran Pai has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Alan's review feedback for -C help text >> - Keep -xfP backward compatible but don't allow -C/--dir with -xfP > >

Re: RFR: 8173970: jar tool should have a way to extract to a directory [v4]

2021-04-01 Thread Jaikiran Pai
> Can I please get a review for this patch which proposes to implement the > enhancement request noted in https://bugs.openjdk.java.net/browse/JDK-8173970? > > The commit in this PR introduces the `-o` and `--output-dir` option to the > `jar` command. The option takes a path to a destination

Re: RFR: JDK-8264403: [macos]: App names containing '.' characters results in an error message when launching [v3]

2021-04-01 Thread Alexey Semenyuk
On Thu, 1 Apr 2021 12:19:21 GMT, Andy Herrick wrote: >> Deriving the cfg file name is broken on mac and linux when the application >> name has a "." in it. > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > > Fix trailing

Re: RFR: 8037397: Lost nested character class after intersection &

2021-04-01 Thread Roger Riggs
On Wed, 31 Mar 2021 20:38:33 GMT, Ian Graves wrote: > Bug fix with the intersection `&&` operator in regex patterns. In > JDK-8037397, some character classes on the right hand side of the operator > are dropped in cases where nested `[..]` classes are used with non "nested" > ones. Please

Re: RFR: 8169629: Annotations with lambda expressions cause AnnotationFormatError

2021-04-01 Thread Joel Borggrén-Franck
On Wed, 31 Mar 2021 21:32:35 GMT, Joe Darcy wrote: > The stricter checks added by > 8035781: Improve equality for annotations > in creating the proxy objects used to implement annotations has an unintended > by-catch of rejecting annotation's whose type has, say, a field initialized > with

RFR: 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28

2021-04-01 Thread Jim Laskey
We should never close the jimage since java threads can still be running after a hard exit(). - Commit messages: - 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28 Changes: https://git.openjdk.java.net/jdk/pull/3304/files Webrev:

Re: RFR: JDK-8264403: [macos]: App names containing '.' characters results in an error message when launching [v3]

2021-04-01 Thread Andy Herrick
> Deriving the cfg file name is broken on mac and linux when the application > name has a "." in it. Andy Herrick has updated the pull request incrementally with one additional commit since the last revision: Fix trailing whitespace - Changes: - all:

Re: RFR: JDK-8264403: [macos]: App names containing '.' characters results in an error message when launching [v2]

2021-04-01 Thread Andy Herrick
> Deriving the cfg file name is broken on mac and linux when the application > name has a "." in it. Andy Herrick has updated the pull request incrementally with one additional commit since the last revision: JDK-8264403: [macos]: App names containing '.' characters results in an error

Re: RFR: JDK-8264403: [macos]: App names containing '.' characters results in an error message when launching [v2]

2021-04-01 Thread Andy Herrick
On Wed, 31 Mar 2021 21:59:55 GMT, Alexey Semenyuk wrote: >> Andy Herrick has updated the pull request incrementally with one additional >> commit since the last revision: >> >> JDK-8264403: [macos]: App names containing '.' characters results in an >> error message when launching > >

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v40]

2021-04-01 Thread Jim Laskey
> This PR is to introduce a new random number API for the JDK. The primary API > is found in RandomGenerator and RandomGeneratorFactory. Further description > can be found in the JEP https://openjdk.java.net/jeps/356 . > > javadoc can be found at >

Re: Proposal for Decimal64 and Decimal128 value-based classes

2021-04-01 Thread Maurizio Cimadamore
On 31/03/2021 23:54, Dan Smith wrote: On Mar 31, 2021, at 3:27 PM, Maurizio Cimadamore wrote: What I'd be curious though, is if the @ValueBased annotation could be enhanced to say _which_ primitive class default you want (and then javac could enforce extra checks if you pick the "val"