Re: jpackage ea-17 --mac-entitlements

2021-04-11 Thread Michael Hall
> On Apr 9, 2021, at 9:27 PM, Michael Hall wrote: > >> >> OK, probable user error. I eliminated my entitlement changes and it worked. >> > Related to the same functionality that I am trying to add, I should, or have > to, make changes to my Info.plist > This being the addition of

Re: RFR: 8264208: Console charset API [v2]

2021-04-11 Thread Alan Bateman
On Fri, 9 Apr 2021 21:06:00 GMT, Naoto Sato wrote: >> Please review the changes for the subject issue. This has been suggested in >> a recent discussion thread for the JEP 400 >> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)]. >> A CSR has also been

Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v3]

2021-04-11 Thread Lance Andersen
Hi Lin On Apr 10, 2021, at 11:16 PM, Lin Zang mailto:lz...@openjdk.java.net>> wrote: Dear @AlanBateman and @LanceAndersen, Thanks a lot for your review and comments! We should look to see if it makes sense to use some of the more recent java features such as Record. If we are adding a

Re: RFR: 8264806: Remove the experimental JIT compiler [v2]

2021-04-11 Thread Doug Simon
On Sat, 10 Apr 2021 17:41:05 GMT, Vladimir Kozlov wrote: >> Marked as reviewed by iignatyev (Reviewer). > > Thank you, Igor. I filed https://bugs.openjdk.java.net/browse/JDK-8265032 We would definitely like to be able to continue testing of GraalVM with the JDK set of jtreg tests. So keeping

Re: RFR: 8265029: Preserve SIZED characteristics on slice operations (skip, limit) [v2]

2021-04-11 Thread Tagir F . Valeev
> With the introduction of `toList()`, preserving the SIZED characteristics in > more cases becomes more important. This patch preserves SIZED on `skip()` and > `limit()` operations, so now every combination of > `map/mapToX/boxed/asXyzStream/skip/limit/sorted` preserves size, and >

Re: RFR: 8265029: Preserve SIZED characteristics on slice operations (skip, limit) [v2]

2021-04-11 Thread Tagir F . Valeev
On Sat, 10 Apr 2021 14:18:57 GMT, Vladimir Sitnikov wrote: >> Tagir F. Valeev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixes according to review: >> >> 1. Comments in adjustSize >> 2. repeating code extracted from

Re: RFR: 8265029: Preserve SIZED characteristics on slice operations (skip, limit)

2021-04-11 Thread Tagir F . Valeev
On Sat, 10 Apr 2021 14:16:40 GMT, Vladimir Sitnikov wrote: >> With the introduction of `toList()`, preserving the SIZED characteristics in >> more cases becomes more important. This patch preserves SIZED on `skip()` >> and `limit()` operations, so now every combination of >>

Re: RFR: 8265029: Preserve SIZED characteristics on slice operations (skip, limit)

2021-04-11 Thread Tagir F . Valeev
On Sat, 10 Apr 2021 14:13:55 GMT, Vladimir Sitnikov wrote: >> With the introduction of `toList()`, preserving the SIZED characteristics in >> more cases becomes more important. This patch preserves SIZED on `skip()` >> and `limit()` operations, so now every combination of >>