Re: 8252827: Caching Integer.toString just like Integer.valueOf

2021-04-17 Thread Tagir Valeev
Hello! I would vote to close this. The benefit for all JDK users is questionable. If it's necessary in a particular application, it could be implemented in user code. With best regards, Tagir Valeev. пт, 16 апр. 2021 г., 23:49 Raffaello Giulietti < raffaello.giulie...@gmail.com>: > Hello, > >

Re: ReversibleCollection proposal

2021-04-17 Thread Tagir Valeev
Hello, Remi! On Sat, Apr 17, 2021 at 11:50 PM Remi Forax wrote: > Introducing a new interface (two in this case) has a really huge cost and in > this case, i've trouble to see why i will want to write a method that takes a > ReversibleCollection as parameter, ReversibleCollection as a type

Re: ReversibleCollection proposal

2021-04-17 Thread Tagir Valeev
> Adding a REVERSIBLE characteristic to spliterators is easy enough Actually not. There are already tons of delegating spliterators in the wild, and many of them delegate characteristics in one or another way. Usually, it's like 'copy all the source characteristics except A and B' (i.e.

Re: ReversibleCollection proposal

2021-04-17 Thread Donald Raab
> I'm also concerned about conflicts over the other method names; something > like addFirst() is a pretty obvious method to add to a custom List > implementation. I haven't seen any, but that doesn't mean there aren't any. > > s'marks The getFirst() and getLast() methods will have

Re: ReversibleCollection proposal

2021-04-17 Thread Donald Raab
Hi, Stuart, happy to help. I took a look at Groovy and Kotlin. Groovy has reverse() [1] and Kotlin has reversed() [2] and asReversed() [3] and reverse() [4]. I’m not quite familiar enough with Kotlin to know whether the reversed() method will collide. [1]

Re: ReversibleCollection proposal

2021-04-17 Thread Stuart Marks
On 4/17/21 4:49 AM, Tagir Valeev wrote: Great proposal, thanks! It has most functionality from my previous proposal, except the ability to iterate LinkedHashSet starting from a specific element. Well, probably we can skip this for now. Thanks! And thanks for making that proposal a year

Re: ReversibleCollection proposal

2021-04-17 Thread Stuart Marks
On 4/17/21 2:48 AM, Stephen Colebourne wrote: On Fri, 16 Apr 2021 at 18:41, Stuart Marks wrote: This is a proposal to add a ReversibleCollection interface to the Collections Framework. I'm looking for comments on overall design before I work on detailed specifications and tests. Please send

Re: ReversibleCollection proposal

2021-04-17 Thread Stuart Marks
On 4/16/21 3:06 PM, Donald Raab wrote: We should be cautious when adding new APIs to existing interfaces. There may be libraries which extend JDK types and already have reversed(), toReversed() or asReversed() APIs and corresponding interfaces. There are OrderedIterable and

How to know if cpu supports unaligned memory accesses ?

2021-04-17 Thread Laurent Bourgès
Hi, In the Marlin renderer & in other Unsafe use cases (pixel tile processing) for java2d pipelines, I do use putInt()/putLong() primitives even if the address is not aligned (to 4 or 8 bytes) to get faster processing of byte buffer or arrays... Is it possible in java (jdk internals) to query cpu

Re: ReversibleCollection proposal

2021-04-17 Thread Remi Forax
- Mail original - > De: "Stuart Marks" > À: "core-libs-dev" > Envoyé: Vendredi 16 Avril 2021 19:40:55 > Objet: ReversibleCollection proposal > This is a proposal to add a ReversibleCollection interface to the Collections > Framework. I'm looking for comments on overall design before I

Re: jpackage bugs

2021-04-17 Thread Michael Hall
> On Apr 17, 2021, at 9:37 AM, Michael Hall wrote: > > So apparently ‘cp’ is not a good idea on a signed application. At least not > on a signed java one. Fyi for anyone who wants to copy a Mac signed java app from a script or maybe from java Runtime. Instead of… cp -r

Re: ReversibleCollection proposal

2021-04-17 Thread Brian Goetz
Adding a REVERSIBLE characteristic to spliterators is easy enough, and as you say, many useful sources can easily provide an efficient reverse operation.  Filtering and mapping can preserve reversibility. The real question is what to do if someone calls reverse() on a non-reversible stream. 

Re: jpackage bugs

2021-04-17 Thread Michael Hall
> On Apr 17, 2021, at 9:14 AM, Michael Hall wrote: > >> only executables and libraries are signed - this tool running across the >> whole app will find unsigned files, that would be expected. > > Hmm. ok. Is the jdk separately signed? Would something in copying it change a > date or

Re: jpackage bugs

2021-04-17 Thread Michael Hall
> On Apr 17, 2021, at 9:14 AM, Michael Hall wrote: > With —install-dir this remains a reproducible bug for me at 17-ea. >> yes - but what is value of "--install-dir" - can you insure it is a fully >> qualified directory path that exists on all users machines and all users >> have

Re: jpackage bugs

2021-04-17 Thread Michael Hall
> On Apr 17, 2021, at 8:57 AM, Andy Herrick wrote: > > > On 4/17/2021 1:14 AM, David Holmes wrote: >> Hi Michael, >> >> On 17/04/2021 10:57 am, Michael Hall wrote: >>> Is there anyway to get a simple/test reference type application available >>> that could be used in reproducing bugs? > I

Re: jpackage bugs

2021-04-17 Thread Andy Herrick
On 4/17/2021 1:14 AM, David Holmes wrote: Hi Michael, On 17/04/2021 10:57 am, Michael Hall wrote: Is there anyway to get a simple/test reference type application available that could be used in reproducing bugs? I put a simple test application I was using in your bug report:

Re: 8252827: Caching Integer.toString just like Integer.valueOf

2021-04-17 Thread Raffaello Giulietti
Hi, in view of Integer becoming a primitive class [1], the IntegerCache is probably going to disappear. For a small, fixed range like the one you are proposing [-1, 16], there's no real need for a separate cache class. You could have a switch in the implementation of toString(), with the

Re: ReversibleCollection proposal

2021-04-17 Thread Tagir Valeev
Great proposal, thanks! It has most functionality from my previous proposal, except the ability to iterate LinkedHashSet starting from a specific element. Well, probably we can skip this for now. Some people really want to reverse Streams as well. E. g., the corresponding StackOverflow question

Re: ReversibleCollection proposal

2021-04-17 Thread Anthony Vanelverdinghe
On Saturday, April 17, 2021 11:48 CEST, Stephen Colebourne wrote: > On Fri, 16 Apr 2021 at 18:41, Stuart Marks wrote: > > This is a proposal to add a ReversibleCollection interface to the > > Collections > > Framework. I'm looking for comments on overall design before I work on > > detailed

Re: ReversibleCollection proposal

2021-04-17 Thread Stephen Colebourne
On Fri, 16 Apr 2021 at 18:41, Stuart Marks wrote: > This is a proposal to add a ReversibleCollection interface to the Collections > Framework. I'm looking for comments on overall design before I work on > detailed > specifications and tests. Please send such comments as replies on this email >

Re: 8252827: Caching Integer.toString just like Integer.valueOf

2021-04-17 Thread Laurent Bourgès
Hi, I read the JBS bug and I interpret it as: - IntegerCache provides Integer instances for [-128, 127] by default - Having Integer.toString(int) could behave the same or at least cache most probable values like [-1 to 16] or using the IntegerCache range. It looks trivial and potentially could

Re: RFR: 8265237: String.join and StringJoiner can be improved further [v2]

2021-04-17 Thread Tagir F . Valeev
On Thu, 15 Apr 2021 19:26:48 GMT, Peter Levart wrote: >> While JDK-8148937 improved StringJoiner class by replacing internal use of >> getChars that copies out characters from String elements into a char[] array >> with StringBuilder which is somehow more optimal, the improvement was >>

Re: 8252827: Caching Integer.toString just like Integer.valueOf

2021-04-17 Thread Raffaello Giulietti
On 2021-04-17 07:07, David Holmes wrote: On 17/04/2021 4:54 am, Raffaello Giulietti wrote: I guess the reporter meant to limit the cache range similarly to the one used for valueOf(). I have no clue about the benefit/cost ratio for the proposed String cache. It really depends on usage,

Re: jpackage bugs

2021-04-17 Thread Michael Hall
> On Apr 17, 2021, at 12:14 AM, David Holmes wrote: > >> > > Note the bug referenced is closed as "incomplete" - that is a temporary state > while awaiting additional information (usually from the submitter). If we > never hear back from the submitter then it will be closed with a

RFR: 8265356: need code example for getting canonical constructor of a Record

2021-04-17 Thread Tagir F . Valeev
I decided to show a complete static method in the example, so it could be copied to user utility class as is. Not sure if it's reasonable to add `assert cls.isRecord();` there. Also I don't know whether there's a limitation on max characters in the sample code. Probable a line break in `static